| Message ID | 20250306-topic-dt_bindings_fixups-v1-3-0c84aceb0ef9@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Various dt-bindings fixes | expand |
On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. Ok, I should have read dt-bindigns before sending a comment. But this commit doesn't explain, why do you need an extra compat string. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 > --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > @@ -18,7 +18,9 @@ description: > > properties: > compatible: > - const: qcom,kpss-acc-v2 > + enum: > + - qcom,msm8916-kpss-acc > + - qcom,kpss-acc-v2 > > reg: > items: > > -- > 2.48.1 >
On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 > --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > @@ -18,7 +18,9 @@ description: > > properties: > compatible: > - const: qcom,kpss-acc-v2 > + enum: > + - qcom,msm8916-kpss-acc Hm, MSM8916 doesn't have a *K*PSS (Krait Processor SubSystem), it has an *A*PSS (ARM Cortex – A53 SubSystem, or Application Processor SubSystem). I think this should be either qcom,msm8916-apss-acc, or you just keep the qcom,msm8916-acc we already use. I'm guessing ACC stands for "Application Clock Controller", so it would be unique enough already. There is actually a patch from Rayyan already with a R-b from Krzysztof. Maybe you, or whoever is responsible, can pick it up? https://lore.kernel.org/linux-arm-msm/20240710155226.130086-1-rayyan.ansari@linaro.org/ Thanks, Stephan
On 7.03.2025 12:07 PM, Stephan Gerhold wrote: > On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> >> >> MSM8916 seems to reuse the same hardware as MSM8974 and friends (for >> whom this binding document was created). Add a new compatible for it. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> >> --- >> Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 >> --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> @@ -18,7 +18,9 @@ description: >> >> properties: >> compatible: >> - const: qcom,kpss-acc-v2 >> + enum: >> + - qcom,msm8916-kpss-acc > > Hm, MSM8916 doesn't have a *K*PSS (Krait Processor SubSystem), it has an > *A*PSS (ARM Cortex – A53 SubSystem, or Application Processor SubSystem). You would think that, but actually it's still called KPSS internally.. > > I think this should be either qcom,msm8916-apss-acc, or you just keep > the qcom,msm8916-acc we already use. I'm guessing ACC stands for > "Application Clock Controller", so it would be unique enough already. > > There is actually a patch from Rayyan already with a R-b from Krzysztof. > Maybe you, or whoever is responsible, can pick it up? > > https://lore.kernel.org/linux-arm-msm/20240710155226.130086-1-rayyan.ansari@linaro.org/ I'm not opposed to this either Looks like Sebastian Reichel and/or Ulf pick up power dt-bindings patches Konrad
On 06/03/2025 19:11, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 + Folks, please merge Ryan work instead... I keep carrying this patch for half a year: https://lore.kernel.org/all/20240710155226.130086-1-rayyan.ansari@linaro.org/ Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml @@ -18,7 +18,9 @@ description: properties: compatible: - const: qcom,kpss-acc-v2 + enum: + - qcom,msm8916-kpss-acc + - qcom,kpss-acc-v2 reg: items: