| Message ID | 20250307124841.23777-15-darren.ye@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: mediatek: Add support for MT8196 SoC | expand |
On Fri, 07 Mar 2025 20:47:40 +0800, Darren.Ye wrote: > From: Darren Ye <darren.ye@mediatek.com> > > Add document for mt8196 board with mt6681. > > Signed-off-by: Darren Ye <darren.ye@mediatek.com> > --- > .../sound/mediatek,mt8196-mt6681.yaml | 122 ++++++++++++++++++ > 1 file changed, 122 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250307124841.23777-15-darren.ye@mediatek.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 07/03/2025 13:47, Darren.Ye wrote: > From: Darren Ye <darren.ye@mediatek.com> > > Add document for mt8196 board with mt6681. Why do you add bindings after its users? Fix the order (see DT submitting patches). Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > Signed-off-by: Darren Ye <darren.ye@mediatek.com> > --- > .../sound/mediatek,mt8196-mt6681.yaml | 122 ++++++++++++++++++ > 1 file changed, 122 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml > new file mode 100644 > index 000000000000..b144ba748c23 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml > @@ -0,0 +1,122 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mediatek,mt8196-mt6681.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT8196 ASoC sound card > + > +maintainers: > + - Darren Ye <darren.ye@mediatek.com> > + > +allOf: > + - $ref: sound-card-common.yaml# > + > +properties: > + compatible: > + oneOf: > + - enum: > + - mediatek,mt8196-mt6681-sound > + - mediatek,mt8196-nau8825-sound > + - mediatek,mt8196-rt5682s-sound > + - mediatek,mt8196-rt5650-sound So this is not compatible with nau8825? > + - items: > + - const: mediatek,mt8196-mt6681-sound This makes no sense. Either it is or it is not compatible with nau8825. > + - const: mediatek,mt8196-nau8825-sound > + > + audio-routing: > + description: > + Valid names could be the input or output widgets of audio components, > + power supplies, MicBias of codec and the software switch. Drop property, not needed. > + Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml new file mode 100644 index 000000000000..b144ba748c23 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml @@ -0,0 +1,122 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mediatek,mt8196-mt6681.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MT8196 ASoC sound card + +maintainers: + - Darren Ye <darren.ye@mediatek.com> + +allOf: + - $ref: sound-card-common.yaml# + +properties: + compatible: + oneOf: + - enum: + - mediatek,mt8196-mt6681-sound + - mediatek,mt8196-nau8825-sound + - mediatek,mt8196-rt5682s-sound + - mediatek,mt8196-rt5650-sound + - items: + - const: mediatek,mt8196-mt6681-sound + - const: mediatek,mt8196-nau8825-sound + + audio-routing: + description: + Valid names could be the input or output widgets of audio components, + power supplies, MicBias of codec and the software switch. + + mediatek,platform: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of MT8188 ASoC platform. + + mediatek,adsp: + $ref: /schemas/types.yaml#/definitions/phandle + description: + The phandle of the MT8188 ADSP platform, which is the optional Audio DSP + hardware that provides additional audio functionalities if present. + The AFE will link to ADSP when the phandle is provided. + +patternProperties: + "^dai-link-[0-9]+$": + type: object + description: + Container for dai-link level properties and CODEC sub-nodes. + + properties: + link-name: + description: + This property corresponds to the name of the BE dai-link to which + we are going to update parameters in this node. + items: + enum: + - TDM_DPTX_BE + - I2SOUT6_BE + - I2SIN6_BE + - I2SOUT4_BE + - I2SOUT3_BE + + codec: + description: Holds subnode which indicates codec dai. + type: object + additionalProperties: false + properties: + sound-dai: + minItems: 1 + maxItems: 2 + required: + - sound-dai + + dai-format: + description: audio format. + items: + enum: + - i2s + - right_j + - left_j + - dsp_a + - dsp_b + + mediatek,clk-provider: + $ref: /schemas/types.yaml#/definitions/string + description: Indicates dai-link clock master. + items: + enum: + - cpu + - codec + + additionalProperties: false + + required: + - link-name + +unevaluatedProperties: false + +required: + - compatible + - mediatek,platform + +examples: + - | + sound { + compatible = "mediatek,mt8196-mt6681-sound"; + model = "mt8196-mt6681"; + mediatek,platform = <&afe>; + audio-routing = "I2SOUT4", "I2SIN4_GPIO", + "I2SOUT4", "I2OUT4_GPIO", + "I2SOUT6", "I2SIN6_GPIO", + "I2SOUT6", "I2SOUT6_GPIO"; + + dai-link-0 { + link-name = "I2SOUT6_BE"; + dai-format = "i2s"; + mediatek,clk-provider = "cpu"; + codec { + sound-dai = <&nau8825>; + }; + }; + }; +