| Message ID | 20250307120004.959980-2-amadeus@jmu.edu.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Add pwm nodes for RK3528 | expand |
On Fri, Mar 07, 2025 at 08:00:03PM +0800, Chukun Pan wrote: > Document pwm compatible for rk3528 which is fallback compatible > of rk3328-pwm group. > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > index e4e1976c542d..c8cdfb723336 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml > @@ -30,6 +30,7 @@ properties: > - enum: > - rockchip,px30-pwm > - rockchip,rk3308-pwm > + - rockchip,rk3528-pwm > - rockchip,rk3562-pwm > - rockchip,rk3568-pwm > - rockchip,rk3588-pwm > -- > 2.25.1 >
Hello, On Fri, Mar 07, 2025 at 08:00:03PM +0800, Chukun Pan wrote: > Document pwm compatible for rk3528 which is fallback compatible > of rk3328-pwm group. > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> to prevent binding warnings it's probably sensible to let both patches go in via the same tree at the same time. Feel free to take the binding patch via rockchip/arm-soc. Acked-by: Uwe Kleine-König <ukleinek@kernel.org> Thanks Uwe
Hi Uwe, Am Freitag, 7. März 2025, 18:07:47 MEZ schrieb Uwe Kleine-König: > On Fri, Mar 07, 2025 at 08:00:03PM +0800, Chukun Pan wrote: > > Document pwm compatible for rk3528 which is fallback compatible > > of rk3328-pwm group. > > > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> > > to prevent binding warnings it's probably sensible to let both patches > go in via the same tree at the same time. Feel free to take the binding > patch via rockchip/arm-soc. > > Acked-by: Uwe Kleine-König <ukleinek@kernel.org> You already have the rk3562 binding in your for-next branch [0], which could create merge-conflicts later on. This patch already contains it, so should fit neatly onto your branch. And binding warnings only come from linux-next, so won't trigger as the pwm will feed the binding there too :-) So I guess it might be better to take the binding through the pwm tree and me then picking up the dts patch. For the binding Reviewed-by: Heiko Stuebner <heiko@sntech.de> [0] https://web.git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git/commit/?h=pwm/for-next&id=058210e84b48dbb670a6bf72afaed6fbd8043a37
Hey Heiko, On Sat, Mar 08, 2025 at 05:25:09PM +0100, Heiko Stuebner wrote: > Am Freitag, 7. März 2025, 18:07:47 MEZ schrieb Uwe Kleine-König: > > On Fri, Mar 07, 2025 at 08:00:03PM +0800, Chukun Pan wrote: > > > Document pwm compatible for rk3528 which is fallback compatible > > > of rk3328-pwm group. > > > > > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> > > > > to prevent binding warnings it's probably sensible to let both patches > > go in via the same tree at the same time. Feel free to take the binding > > patch via rockchip/arm-soc. > > > > Acked-by: Uwe Kleine-König <ukleinek@kernel.org> > > You already have the rk3562 binding in your for-next branch [0], which > could create merge-conflicts later on. Oh indeed. > This patch already contains it, so should fit neatly onto your branch. > > And binding warnings only come from linux-next, so won't trigger as the > pwm will feed the binding there too :-) > > So I guess it might be better to take the binding through the pwm tree > and me then picking up the dts patch. Fine for me, so I applied the first patch to https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next . Best regards Uwe
diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml index e4e1976c542d..c8cdfb723336 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml @@ -30,6 +30,7 @@ properties: - enum: - rockchip,px30-pwm - rockchip,rk3308-pwm + - rockchip,rk3528-pwm - rockchip,rk3562-pwm - rockchip,rk3568-pwm - rockchip,rk3588-pwm
Document pwm compatible for rk3528 which is fallback compatible of rk3328-pwm group. Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> --- Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + 1 file changed, 1 insertion(+)