mbox series

[0/2] iio: accel: adis16203: cleanup and standardization

Message ID 20250305155712.49833-2-simeddon@gmail.com (mailing list archive)
Headers show
Series iio: accel: adis16203: cleanup and standardization | expand

Message

Siddharth Menon March 5, 2025, 3:29 p.m. UTC
This series improves the adis16203 driver by using standard unit macros
and removing an unused spi_set_drvdata() call.

Siddharth Menon (2):
  iio: accel: adis16203: Use units.h macros for voltage values
  iio: accel: adis16203: Remove spi_set_drvdata()

 drivers/staging/iio/accel/adis16203.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Jonathan Cameron March 8, 2025, 2:43 p.m. UTC | #1
On Wed,  5 Mar 2025 20:59:10 +0530
Siddharth Menon <simeddon@gmail.com> wrote:

> This series improves the adis16203 driver by using standard unit macros
> and removing an unused spi_set_drvdata() call.
> 
> Siddharth Menon (2):
>   iio: accel: adis16203: Use units.h macros for voltage values
>   iio: accel: adis16203: Remove spi_set_drvdata()
> 
>  drivers/staging/iio/accel/adis16203.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 

I'm not going to apply these because I think you correct
identified that the device support should just be added
to the adis16201 driver and this one dropped.
Good thing you were more awake on this than me ;)

Jonathan
Jonathan Cameron March 8, 2025, 2:49 p.m. UTC | #2
On Sat, 8 Mar 2025 14:43:57 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Wed,  5 Mar 2025 20:59:10 +0530
> Siddharth Menon <simeddon@gmail.com> wrote:
> 
> > This series improves the adis16203 driver by using standard unit macros
> > and removing an unused spi_set_drvdata() call.
> > 
> > Siddharth Menon (2):
> >   iio: accel: adis16203: Use units.h macros for voltage values
> >   iio: accel: adis16203: Remove spi_set_drvdata()
> > 
> >  drivers/staging/iio/accel/adis16203.c | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> >   
> 
> I'm not going to apply these because I think you correct
> identified that the device support should just be added
> to the adis16201 driver and this one dropped.
> Good thing you were more awake on this than me ;)
> 
Sorry - wrong person.  
https://lore.kernel.org/all/20250306002645.1555569-1-danascape@gmail.com/

I'm definitely not awake today.

Jonathan

> Jonathan
Siddharth Menon March 9, 2025, 5:48 a.m. UTC | #3
On Sat, 8 Mar 2025 at 20:19, Jonathan Cameron <jic23@kernel.org> wrote:
>
> > I'm not going to apply these because I think you correct
> > identified that the device support should just be added
> > to the adis16201 driver and this one dropped.
> > Good thing you were more awake on this than me ;)
> >
> Sorry - wrong person.

Well, I’ll assume these won't be getting applied.

Siddharth Menon
Jonathan Cameron March 9, 2025, 4:27 p.m. UTC | #4
On Sun, 9 Mar 2025 11:18:18 +0530
Siddharth Menon <simeddon@gmail.com> wrote:

> On Sat, 8 Mar 2025 at 20:19, Jonathan Cameron <jic23@kernel.org> wrote:
> >  
> > > I'm not going to apply these because I think you correct
> > > identified that the device support should just be added
> > > to the adis16201 driver and this one dropped.
> > > Good thing you were more awake on this than me ;)
> > >  
> > Sorry - wrong person.  
> 
> Well, I’ll assume these won't be getting applied.

Yes, sorry you wasted your time on this!

Jonathan

> 
> Siddharth Menon
>