diff mbox series

[3/3] arm64: dts: rockchip: Add onboard EEPROM for Radxa E20C

Message ID 20250309070603.35254-4-ziyao@disroot.org (mailing list archive)
State New
Headers show
Series Support I2C controllers in RK3528 | expand

Commit Message

Yao Zi March 9, 2025, 7:06 a.m. UTC
Radxa E20C ships an onboard I2C EEPROM for storing production
information. Enable it in devicetree.

Signed-off-by: Yao Zi <ziyao@disroot.org>
---
 arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Chukun Pan March 10, 2025, 7 a.m. UTC | #1
Hi,

> +&i2c1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c1m0_xfer>;
> +	status = "okay";
> +
> +	eeprom@50 {
> +		compatible = "belling,bl24c16a", "atmel,24c16";
> +		reg = <0x50>;
> +		pagesize = <16>;
> +		vcc-supply = <&vcc_3v3>;
> +	};
> +};

This eeprom stores the device information written by the manufacturer,
such as mac address and sn. So it should be marked as read-only.

Thanks,
Chukun
Yao Zi March 10, 2025, 7:15 a.m. UTC | #2
On Mon, Mar 10, 2025 at 03:00:23PM +0800, Chukun Pan wrote:
> Hi,
> 
> > +&i2c1 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&i2c1m0_xfer>;
> > +	status = "okay";
> > +
> > +	eeprom@50 {
> > +		compatible = "belling,bl24c16a", "atmel,24c16";
> > +		reg = <0x50>;
> > +		pagesize = <16>;
> > +		vcc-supply = <&vcc_3v3>;
> > +	};
> > +};
> 
> This eeprom stores the device information written by the manufacturer,
> such as mac address and sn. So it should be marked as read-only.

Thanks, this makes sense.

> Thanks,
> Chukun
> 
> -- 
> 2.25.1
> 

Best regards,
Yao Zi
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
index b74e605a5a82..ddcf690eb513 100644
--- a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
@@ -122,6 +122,19 @@  vccio_sd: regulator-vccio-sd {
 	};
 };
 
+&i2c1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c1m0_xfer>;
+	status = "okay";
+
+	eeprom@50 {
+		compatible = "belling,bl24c16a", "atmel,24c16";
+		reg = <0x50>;
+		pagesize = <16>;
+		vcc-supply = <&vcc_3v3>;
+	};
+};
+
 &pinctrl {
 	gpio-keys {
 		user_key: user-key {