mbox series

[v4,0/2] Add Goodix Berlin-A series support

Message ID 20250309062315.35720-1-adrian@mainlining.org (mailing list archive)
Headers show
Series Add Goodix Berlin-A series support | expand

Message

Jens Reidel March 9, 2025, 6:23 a.m. UTC
This series adds support for the Goodix Berlin-A series touch ICs
(gt9897). This was tested on a Xiaomi 11 Lite 5G NE (xiaomi-lisa),
which uses the gt9897 IC connected over SPI. I am not aware of any
device that has gt9897 connected over I2C and therefore could not
test it, so I didn't add a compatible in the I2C driver.

Changes in v4:
- Fix the build for the i2c driver
- Add Neil's R-b tag (patch no. 2)
- Link to v3:
  https://lore.kernel.org/all/20250307094823.478152-1-adrian@mainlining.org/

Changes in v3:
- Store the ic data in the goodix_berlin_core struct and pass it to
  goodix_berlin_probe from the i2c/spi probes (requested by Neil)
- Resent from my now preferred e-mail for kernel work
- Link to v2:
  https://lore.kernel.org/all/20250214052959.222668-1-adrian@travitia.xyz/

Changes in v2:
- Added Rob's A-b tag (patch no. 1)
- Added Luca's T-b tag (patch no. 2)
- Updated the i2c and spi device id tables with the driver data and
  switched to spi_get_device_match_data where possible (requested by
  Neil)
- Switched to device_get_match_data in goodix_berlin_core.c
- Move all revision specific addresses and other properties into the
  goodix_berlin_ic_data struct (requested by Dmitry)
- Link to v1:
  https://lore.kernel.org/all/20250203174309.21574-1-adrian@travitia.xyz/

To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Bastien Nocera <hadess@hadess.net>
To: Hans de Goede <hdegoede@redhat.com>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Luca Weiss <luca.weiss@fairphone.com>
Cc: linux-input@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: phone-devel@vger.kernel.org
Cc: linux@mainlining.org
Cc: ~postmarketos/upstreaming@lists.sr.ht
Signed-off-by: Jens Reidel <adrian@mainlining.org>

Jens Reidel (2):
  dt-bindings: input: goodix,gt9916: Document gt9897 compatible
  Input: goodix_berlin - Add support for Berlin-A series

 .../input/touchscreen/goodix,gt9916.yaml      |  1 +
 drivers/input/touchscreen/goodix_berlin.h     | 16 ++++++-
 .../input/touchscreen/goodix_berlin_core.c    | 21 ++++----
 drivers/input/touchscreen/goodix_berlin_i2c.c | 14 ++++--
 drivers/input/touchscreen/goodix_berlin_spi.c | 48 ++++++++++++++-----
 5 files changed, 74 insertions(+), 26 deletions(-)

Comments

Dmitry Torokhov March 10, 2025, 6:53 p.m. UTC | #1
On Sun, Mar 09, 2025 at 07:23:13AM +0100, Jens Reidel wrote:
> This series adds support for the Goodix Berlin-A series touch ICs
> (gt9897). This was tested on a Xiaomi 11 Lite 5G NE (xiaomi-lisa),
> which uses the gt9897 IC connected over SPI. I am not aware of any
> device that has gt9897 connected over I2C and therefore could not
> test it, so I didn't add a compatible in the I2C driver.

Applied the lot, thank you.