diff mbox series

[v2,08/16] exec/memory-internal: remove dependency on cpu.h

Message ID 20250311040838.3937136-9-pierrick.bouvier@linaro.org (mailing list archive)
State Superseded
Headers show
Series make system memory API available for common code | expand

Commit Message

Pierrick Bouvier March 11, 2025, 4:08 a.m. UTC 
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 include/exec/memory-internal.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Philippe Mathieu-Daudé March 11, 2025, 7:26 a.m. UTC | #1 
On 11/3/25 05:08, Pierrick Bouvier wrote:
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Missing the "why" justification we couldn't do that before.

> ---
>   include/exec/memory-internal.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
> index 100c1237ac2..b729f3b25ad 100644
> --- a/include/exec/memory-internal.h
> +++ b/include/exec/memory-internal.h
> @@ -20,8 +20,6 @@
>   #ifndef MEMORY_INTERNAL_H
>   #define MEMORY_INTERNAL_H
>   
> -#include "cpu.h"
> -
>   #ifndef CONFIG_USER_ONLY
>   static inline AddressSpaceDispatch *flatview_to_dispatch(FlatView *fv)
>   {
Pierrick Bouvier March 11, 2025, 3:13 p.m. UTC | #2 
On 3/11/25 00:26, Philippe Mathieu-Daudé wrote:
> On 11/3/25 05:08, Pierrick Bouvier wrote:
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> 
> Missing the "why" justification we couldn't do that before.
> 
>> ---
>>    include/exec/memory-internal.h | 2 --
>>    1 file changed, 2 deletions(-)
>>
>> diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
>> index 100c1237ac2..b729f3b25ad 100644
>> --- a/include/exec/memory-internal.h
>> +++ b/include/exec/memory-internal.h
>> @@ -20,8 +20,6 @@
>>    #ifndef MEMORY_INTERNAL_H
>>    #define MEMORY_INTERNAL_H
>>    
>> -#include "cpu.h"
>> -
>>    #ifndef CONFIG_USER_ONLY
>>    static inline AddressSpaceDispatch *flatview_to_dispatch(FlatView *fv)
>>    {
> 

No direct dependency, but when a common code will include that (like 
system/memory.c), we can't have a dependency on cpu.h anymore.
I can reorder or squash commits if you prefer.
diff mbox series

Patch

diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index 100c1237ac2..b729f3b25ad 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -20,8 +20,6 @@ 
 #ifndef MEMORY_INTERNAL_H
 #define MEMORY_INTERNAL_H
 
-#include "cpu.h"
-
 #ifndef CONFIG_USER_ONLY
 static inline AddressSpaceDispatch *flatview_to_dispatch(FlatView *fv)
 {