[v3] i915/gt/selftests: Disable lrc_timestamp test

Commit Message

Mikolaj Wasiak March 11, 2025, 9:33 a.m. UTC

This test was designed to isolate a bug in tigerlake and dg2 hardware.
The bug was found and fixed in newer generations.
Since we won't support any new hardware with this driver, the test
should now be turned off in the CI to not pollute it with random failures
on previous hardware.

Fixes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13697

Signed-off-by: Mikolaj Wasiak <[e-mail]>
Reviewed-by: Chris Wilson <[e-mail]>
---
v1 -> v2:
- Disabled the test instead of removing it,
- Changed name from 'remove' to 'disable'

v2 -> v3:
- Fix vocabulary
- Disable this test only on related hardware

 drivers/gpu/drm/i915/gt/selftest_lrc.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Krzysztof Karas March 11, 2025, 11:23 a.m. UTC | #1

Hi Mikolaj,

> This test was designed to isolate a bug in tigerlake and dg2 hardware.
> The bug was found and fixed in newer generations.
> Since we won't support any new hardware with this driver, the test
> should now be turned off in the CI to not pollute it with random failures
> on previous hardware.
> 
> Fixes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13697
> 
> Signed-off-by: Mikolaj Wasiak <[e-mail]>
> Reviewed-by: Chris Wilson <[e-mail]>

Reviewed-by: Krzysztof Karas <[e-mail]>

Best Regards,
Krzysztof

Mikolaj Wasiak March 12, 2025, 3:17 p.m. UTC | #2

On 2025-03-11 at 11:03:23 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: i915/gt/selftests: Disable lrc_timestamp test
> URL   : https://patchwork.freedesktop.org/series/146125/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_16262 -> Patchwork_146125v1
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_146125v1 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_146125v1, please notify your bug team ([e-mail]) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146125v1/index.html
> 
> Participating hosts (44 -> 43)
> ------------------------------
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_pm_rpm@module-reload:
>     - bat-adls-6:         [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16262/bat-adls-6/igt@[e-mail]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_146125v1/bat-adls-6/igt@[e-mail]
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_16262 -> Patchwork_146125v1
> 
>   CI-20190529: 20190529
>   CI_DRM_16262: 777e1850811f9864aa8b55940634d3da19712bf7 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8270: 49751c5c11723262ec66e564c76503f74a9fa831 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_146125v1: 777e1850811f9864aa8b55940634d3da19712bf7 @ git://anongit.freedesktop.org/gfx-ci/linux
> 

Hi IGT ci infra

The above regression is unrelated, the patch only focuses on i915_lrc selftest.
Could you please update filters and re-report?

Thanks,
Mikolaj

Patch

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 22e750108c5f..c928b4723c38 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -7,6 +7,7 @@ 
 
 #include "gem/i915_gem_internal.h"
 
+#include "i915_drv.h"
 #include "i915_selftest.h"
 #include "intel_engine_heartbeat.h"
 #include "intel_engine_pm.h"
@@ -858,6 +859,16 @@  static int live_lrc_timestamp(void *arg)
 		U32_MAX,
 	};
 
+	/*
+	 * This test was designed to isolate a hardware bug.
+	 * The bug was found and fixed in future generations but 
+	 * now the test pollutes our CI on previous generation.
+	 *
+	 * https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13697
+	 */
+	if (GRAPHICS_VER(gt->i915) == 12)
+		return 0;
+
 	/*
 	 * We want to verify that the timestamp is saved and restore across
 	 * context switches and is monotonic.