[v2,07/16] exec/exec-all: remove dependency on cpu.h

Message ID	20250311040838.3937136-8-pierrick.bouvier@linaro.org (mailing list archive)
State	New
Headers	show Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27811E9B1A for <kvm@vger.kernel.org>; Tue, 11 Mar 2025 04:09:05 +0000 (UTC) From: Pierrick Bouvier <pierrick.bouvier@linaro.org> To: qemu-devel@nongnu.org Cc: Paul Durrant <paul@xen.org>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, David Hildenbrand <david@redhat.com>, Weiwei Li <liwei1518@gmail.com>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, xen-devel@lists.xenproject.org, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Peter Xu <peterx@redhat.com>, Nicholas Piggin <npiggin@gmail.com>, kvm@vger.kernel.org, qemu-ppc@nongnu.org, Alistair Francis <alistair.francis@wdc.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>, Harsh Prateek Bora <harshpb@linux.ibm.com>, alex.bennee@linaro.org, qemu-riscv@nongnu.org, manos.pitsidianakis@linaro.org, Yoshinori Sato <ysato@users.sourceforge.jp>, Palmer Dabbelt <palmer@dabbelt.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, Anthony PERARD <anthony@xenproject.org>, Pierrick Bouvier <pierrick.bouvier@linaro.org> Subject: [PATCH v2 07/16] exec/exec-all: remove dependency on cpu.h Date: Mon, 10 Mar 2025 21:08:29 -0700 Message-Id: <20250311040838.3937136-8-pierrick.bouvier@linaro.org> In-Reply-To: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> References: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	make system memory API available for common code \| expand [v2,00/16] make system memory API available for common code [v2,01/16] exec/tswap: target code can use TARGET_BIG_ENDIAN instead of target_words_bigendian() [v2,02/16] exec/tswap: implement {ld,st}.*_p as functions instead of macros [v2,03/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h [v2,04/16] exec/memory_ldst_phys: extract memory_ldst_phys declarations from cpu-all.h [v2,05/16] exec/memory.h: make devend_memop "target defines" agnostic [v2,06/16] codebase: prepare to remove cpu.h from exec/exec-all.h [v2,07/16] exec/exec-all: remove dependency on cpu.h [v2,08/16] exec/memory-internal: remove dependency on cpu.h [v2,09/16] exec/ram_addr: remove dependency on cpu.h [v2,10/16] system/kvm: make kvm_flush_coalesced_mmio_buffer() accessible for common code [v2,11/16] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled [v2,12/16] hw/xen: add stubs for various functions [v2,13/16] system/physmem: compilation unit is now common to all targets [v2,14/16] include/exec/memory: extract devend_big_endian from devend_memop [v2,15/16] system/memory: make compilation unit common [v2,16/16] system/ioport: make compilation unit common

Message ID

20250311040838.3937136-8-pierrick.bouvier@linaro.org (mailing list archive)

State

New

Headers

From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paul Durrant <paul@xen.org>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
 David Hildenbrand <david@redhat.com>, Weiwei Li <liwei1518@gmail.com>,
	=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
 xen-devel@lists.xenproject.org, Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Peter Xu <peterx@redhat.com>, Nicholas Piggin <npiggin@gmail.com>,
 kvm@vger.kernel.org, qemu-ppc@nongnu.org,
 Alistair Francis <alistair.francis@wdc.com>,
 "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Harsh Prateek Bora <harshpb@linux.ibm.com>, alex.bennee@linaro.org,
 qemu-riscv@nongnu.org, manos.pitsidianakis@linaro.org,
 Yoshinori Sato <ysato@users.sourceforge.jp>,
 Palmer Dabbelt <palmer@dabbelt.com>,
 Daniel Henrique Barboza <danielhb413@gmail.com>,
 Anthony PERARD <anthony@xenproject.org>,
 Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: [PATCH v2 07/16] exec/exec-all: remove dependency on cpu.h
Date: Mon, 10 Mar 2025 21:08:29 -0700
Message-Id: <20250311040838.3937136-8-pierrick.bouvier@linaro.org>
In-Reply-To: <20250311040838.3937136-1-pierrick.bouvier@linaro.org>
References: <20250311040838.3937136-1-pierrick.bouvier@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

make system memory API available for common code | expand

Comments

Philippe Mathieu-Daudé March 11, 2025, 7:26 a.m. UTC | #1

On 11/3/25 05:08, Pierrick Bouvier wrote:
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Missing the "why" justification we couldn't do that before.

> ---
>   include/exec/exec-all.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> index dd5c40f2233..19b0eda44a7 100644
> --- a/include/exec/exec-all.h
> +++ b/include/exec/exec-all.h
> @@ -20,7 +20,6 @@
>   #ifndef EXEC_ALL_H
>   #define EXEC_ALL_H
>   
> -#include "cpu.h"
>   #if defined(CONFIG_USER_ONLY)
>   #include "exec/cpu_ldst.h"
>   #endif

Pierrick Bouvier March 11, 2025, 3:10 p.m. UTC | #2

On 3/11/25 00:26, Philippe Mathieu-Daudé wrote:
> On 11/3/25 05:08, Pierrick Bouvier wrote:
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> 
> Missing the "why" justification we couldn't do that before.
> 
>> ---
>>    include/exec/exec-all.h | 1 -
>>    1 file changed, 1 deletion(-)
>>
>> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
>> index dd5c40f2233..19b0eda44a7 100644
>> --- a/include/exec/exec-all.h
>> +++ b/include/exec/exec-all.h
>> @@ -20,7 +20,6 @@
>>    #ifndef EXEC_ALL_H
>>    #define EXEC_ALL_H
>>    
>> -#include "cpu.h"
>>    #if defined(CONFIG_USER_ONLY)
>>    #include "exec/cpu_ldst.h"
>>    #endif
> 

Previous commit is named:
codebase: prepare to remove cpu.h from exec/exec-all.h
So before those changes, it's not possible.

I can repeat that here, or squash the patches together, as you prefer.

diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index dd5c40f2233..19b0eda44a7 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -20,7 +20,6 @@ 
 #ifndef EXEC_ALL_H
 #define EXEC_ALL_H
 
-#include "cpu.h"
 #if defined(CONFIG_USER_ONLY)
 #include "exec/cpu_ldst.h"
 #endif

[v2,07/16] exec/exec-all: remove dependency on cpu.h

Commit Message

Comments

Patch