diff mbox series

[4/4] media: iris: add compatible string for sa8775p

Message ID 20250311-dtbinding-v1-4-5c807d33f7ae@quicinc.com (mailing list archive)
State New
Headers show
Series media: qcom: iris: add support for SA8775P | expand

Commit Message

Vikash Garodia March 11, 2025, 12:03 p.m. UTC
Add required compatible string to enable video hardware
acceleration on sa8775p.

Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
---
 drivers/media/platform/qcom/iris/iris_probe.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Dmitry Baryshkov March 11, 2025, 3:32 p.m. UTC | #1
On Tue, Mar 11, 2025 at 05:33:56PM +0530, Vikash Garodia wrote:
> Add required compatible string to enable video hardware
> acceleration on sa8775p.

No, use fallback compatibles instead.

> 
> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
> ---
>  drivers/media/platform/qcom/iris/iris_probe.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
> index aca442dcc153830e6252d1dca87afb38c0b9eb8f..23c9e76a68013399b0fc1d68c1ccf0f8b0ddb037 100644
> --- a/drivers/media/platform/qcom/iris/iris_probe.c
> +++ b/drivers/media/platform/qcom/iris/iris_probe.c
> @@ -324,6 +324,10 @@ static const struct of_device_id iris_dt_match[] = {
>  		.compatible = "qcom,sm8550-iris",
>  		.data = &sm8550_data,
>  	},
> +	{
> +		.compatible = "qcom,sa8775p-iris",
> +		.data = &sm8550_data,
> +	},
>  #if (!IS_ENABLED(CONFIG_VIDEO_QCOM_VENUS))
>  		{
>  			.compatible = "qcom,sm8250-venus",
> 
> -- 
> 2.34.1
>
Krzysztof Kozlowski March 11, 2025, 5:34 p.m. UTC | #2
On 11/03/2025 13:03, Vikash Garodia wrote:
> Add required compatible string to enable video hardware
> acceleration on sa8775p.


Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
> ---
>  drivers/media/platform/qcom/iris/iris_probe.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
> index aca442dcc153830e6252d1dca87afb38c0b9eb8f..23c9e76a68013399b0fc1d68c1ccf0f8b0ddb037 100644
> --- a/drivers/media/platform/qcom/iris/iris_probe.c
> +++ b/drivers/media/platform/qcom/iris/iris_probe.c
> @@ -324,6 +324,10 @@ static const struct of_device_id iris_dt_match[] = {
>  		.compatible = "qcom,sm8550-iris",
>  		.data = &sm8550_data,
>  	},
> +	{
> +		.compatible = "qcom,sa8775p-iris",
Drop. Not needed.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
index aca442dcc153830e6252d1dca87afb38c0b9eb8f..23c9e76a68013399b0fc1d68c1ccf0f8b0ddb037 100644
--- a/drivers/media/platform/qcom/iris/iris_probe.c
+++ b/drivers/media/platform/qcom/iris/iris_probe.c
@@ -324,6 +324,10 @@  static const struct of_device_id iris_dt_match[] = {
 		.compatible = "qcom,sm8550-iris",
 		.data = &sm8550_data,
 	},
+	{
+		.compatible = "qcom,sa8775p-iris",
+		.data = &sm8550_data,
+	},
 #if (!IS_ENABLED(CONFIG_VIDEO_QCOM_VENUS))
 		{
 			.compatible = "qcom,sm8250-venus",