| Message ID | 20250311141045.66620-5-shameerali.kolothum.thodi@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm/virt: Add support for user-creatable accelerated SMMUv3 | expand |
On Tue, Mar 11, 2025 at 02:10:29PM +0000, Shameer Kolothum wrote: > Allow cold-plug smmuv3-accel to virt If the machine wide smmuv3 > is not specified. > > No FDT support is added for now. > > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> > --- > hw/arm/virt.c | 12 ++++++++++++ > hw/core/sysbus-fdt.c | 1 + > include/hw/arm/virt.h | 1 + > 3 files changed, 14 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 4a5a9666e9..84a323da55 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -73,6 +73,7 @@ > #include "qobject/qlist.h" > #include "standard-headers/linux/input.h" > #include "hw/arm/smmuv3.h" > +#include "hw/arm/smmuv3-accel.h" smmuv3-accel.h included smmuv3.h in the patch prior. > @@ -2911,6 +2912,16 @@ static void virt_machine_device_plug_cb(HotplugHandler *hotplug_dev, > platform_bus_link_device(PLATFORM_BUS_DEVICE(vms->platform_bus_dev), > SYS_BUS_DEVICE(dev)); > } > + if (object_dynamic_cast(OBJECT(dev), TYPE_ARM_SMMUV3_ACCEL)) { > + if (vms->iommu == VIRT_IOMMU_SMMUV3) { > + error_setg(errp, > + "iommu=smmuv3 is already specified. can't create smmuv3-accel dev"); > + return; > + } > + if (vms->iommu != VIRT_IOMMU_SMMUV3_ACCEL) { > + vms->iommu = VIRT_IOMMU_SMMUV3_ACCEL; > + } Looks like it is to support TYPE_VIRTIO_IOMMU_PCI? Just asking: should SMMUV3_ACCEL work with that? Nicolin
> -----Original Message----- > From: Nicolin Chen <nicolinc@nvidia.com> > Sent: Tuesday, March 11, 2025 8:23 PM > To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> > Cc: qemu-arm@nongnu.org; qemu-devel@nongnu.org; > eric.auger@redhat.com; peter.maydell@linaro.org; jgg@nvidia.com; > ddutile@redhat.com; berrange@redhat.com; nathanc@nvidia.com; > mochs@nvidia.com; smostafa@google.com; Linuxarm > <linuxarm@huawei.com>; Wangzhou (B) <wangzhou1@hisilicon.com>; > jiangkunkun <jiangkunkun@huawei.com>; Jonathan Cameron > <jonathan.cameron@huawei.com>; zhangfei.gao@linaro.org > Subject: Re: [RFC PATCH v2 04/20] hw/arm/virt: Add support for smmuv3- > accel > > On Tue, Mar 11, 2025 at 02:10:29PM +0000, Shameer Kolothum wrote: > > Allow cold-plug smmuv3-accel to virt If the machine wide smmuv3 > > is not specified. > > > > No FDT support is added for now. > > > > Signed-off-by: Shameer Kolothum > <shameerali.kolothum.thodi@huawei.com> > > --- > > hw/arm/virt.c | 12 ++++++++++++ > > hw/core/sysbus-fdt.c | 1 + > > include/hw/arm/virt.h | 1 + > > 3 files changed, 14 insertions(+) > > > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > index 4a5a9666e9..84a323da55 100644 > > --- a/hw/arm/virt.c > > +++ b/hw/arm/virt.c > > @@ -73,6 +73,7 @@ > > #include "qobject/qlist.h" > > #include "standard-headers/linux/input.h" > > #include "hw/arm/smmuv3.h" > > +#include "hw/arm/smmuv3-accel.h" > > smmuv3-accel.h included smmuv3.h in the patch prior. > > > @@ -2911,6 +2912,16 @@ static void > virt_machine_device_plug_cb(HotplugHandler *hotplug_dev, > > platform_bus_link_device(PLATFORM_BUS_DEVICE(vms- > >platform_bus_dev), > > SYS_BUS_DEVICE(dev)); > > } > > + if (object_dynamic_cast(OBJECT(dev), TYPE_ARM_SMMUV3_ACCEL)) > { > > + if (vms->iommu == VIRT_IOMMU_SMMUV3) { > > + error_setg(errp, > > + "iommu=smmuv3 is already specified. can't create > smmuv3-accel dev"); > > + return; > > + } > > + if (vms->iommu != VIRT_IOMMU_SMMUV3_ACCEL) { > > + vms->iommu = VIRT_IOMMU_SMMUV3_ACCEL; > > + } > > Looks like it is to support TYPE_VIRTIO_IOMMU_PCI? > > Just asking: should SMMUV3_ACCEL work with that? Hmm..That's true. It will conflict with virtio-iommu. I will add a blocker if both are specified. Thanks, Shameer
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 4a5a9666e9..84a323da55 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -73,6 +73,7 @@ #include "qobject/qlist.h" #include "standard-headers/linux/input.h" #include "hw/arm/smmuv3.h" +#include "hw/arm/smmuv3-accel.h" #include "hw/acpi/acpi.h" #include "target/arm/cpu-qom.h" #include "target/arm/internals.h" @@ -2911,6 +2912,16 @@ static void virt_machine_device_plug_cb(HotplugHandler *hotplug_dev, platform_bus_link_device(PLATFORM_BUS_DEVICE(vms->platform_bus_dev), SYS_BUS_DEVICE(dev)); } + if (object_dynamic_cast(OBJECT(dev), TYPE_ARM_SMMUV3_ACCEL)) { + if (vms->iommu == VIRT_IOMMU_SMMUV3) { + error_setg(errp, + "iommu=smmuv3 is already specified. can't create smmuv3-accel dev"); + return; + } + if (vms->iommu != VIRT_IOMMU_SMMUV3_ACCEL) { + vms->iommu = VIRT_IOMMU_SMMUV3_ACCEL; + } + } } if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { @@ -3120,6 +3131,7 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_AMD_XGBE); machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); machine_class_allow_dynamic_sysbus_dev(mc, TYPE_VFIO_PLATFORM); + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_ARM_SMMUV3_ACCEL); #ifdef CONFIG_TPM machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS); #endif diff --git a/hw/core/sysbus-fdt.c b/hw/core/sysbus-fdt.c index 774c0aed41..c8502ad830 100644 --- a/hw/core/sysbus-fdt.c +++ b/hw/core/sysbus-fdt.c @@ -489,6 +489,7 @@ static const BindingEntry bindings[] = { #ifdef CONFIG_LINUX TYPE_BINDING(TYPE_VFIO_CALXEDA_XGMAC, add_calxeda_midway_xgmac_fdt_node), TYPE_BINDING(TYPE_VFIO_AMD_XGBE, add_amd_xgbe_fdt_node), + TYPE_BINDING("arm-smmuv3-accel", no_fdt_node), VFIO_PLATFORM_BINDING("amd,xgbe-seattle-v1a", add_amd_xgbe_fdt_node), #endif #ifdef CONFIG_TPM diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index c8e94e6aed..849d1cd5b5 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -92,6 +92,7 @@ enum { typedef enum VirtIOMMUType { VIRT_IOMMU_NONE, VIRT_IOMMU_SMMUV3, + VIRT_IOMMU_SMMUV3_ACCEL, VIRT_IOMMU_VIRTIO, } VirtIOMMUType;
Allow cold-plug smmuv3-accel to virt If the machine wide smmuv3 is not specified. No FDT support is added for now. Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> --- hw/arm/virt.c | 12 ++++++++++++ hw/core/sysbus-fdt.c | 1 + include/hw/arm/virt.h | 1 + 3 files changed, 14 insertions(+)