diff mbox series

[2/4] dt-bindings: media: qcom,sm8550-iris: document SA8775p IRIS accelerator

Message ID 20250311-dtbinding-v1-2-5c807d33f7ae@quicinc.com (mailing list archive)
State New
Headers show
Series media: qcom: iris: add support for SA8775P | expand

Commit Message

Vikash Garodia March 11, 2025, 12:03 p.m. UTC
Document the IRIS video decoder and encoder accelerator found in the
SA8775P platform. SA8775P has collapsible MX compared to SM8550.

Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
---
 Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Dmitry Baryshkov March 11, 2025, 3:31 p.m. UTC | #1
On Tue, Mar 11, 2025 at 05:33:54PM +0530, Vikash Garodia wrote:
> Document the IRIS video decoder and encoder accelerator found in the
> SA8775P platform. SA8775P has collapsible MX compared to SM8550.

How compatible is SA8775P to SM8550? Should it be using a fallback
compatible?

This kind of comes as a more generic question: is there anything like
'IP version' or 'core version'? It would be really nice to determine the
'baseline' SoCs and make other instances compatible with the baseline.

> 
> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
> ---
>  Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> index 440a0d7cdfe19a1ccedefc207d96b26eed5d6630..20ac596638ba33f49cce9e42d70d31a8aaa7c36e 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> @@ -19,7 +19,9 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: qcom,sm8550-iris
> +    enum:
> +      - qcom,sm8550-iris
> +      - qcom,sa8775p-iris
>  
>    power-domains:
>      maxItems: 4
> 
> -- 
> 2.34.1
>
Krzysztof Kozlowski March 11, 2025, 5:35 p.m. UTC | #2
On 11/03/2025 13:03, Vikash Garodia wrote:
> Document the IRIS video decoder and encoder accelerator found in the
> SA8775P platform. SA8775P has collapsible MX compared to SM8550.
Does this make interface incompatible? Does not look like.

Best regards,
Krzysztof
Vikash Garodia March 11, 2025, 5:57 p.m. UTC | #3
On 3/11/2025 11:05 PM, Krzysztof Kozlowski wrote:
> On 11/03/2025 13:03, Vikash Garodia wrote:
>> Document the IRIS video decoder and encoder accelerator found in the
>> SA8775P platform. SA8775P has collapsible MX compared to SM8550.
> Does this make interface incompatible? Does not look like.
Just the phandle specifier in the DT property, otherwise same.

Regards,
Vikash
Vikash Garodia March 12, 2025, 8:07 a.m. UTC | #4
On 3/11/2025 9:01 PM, Dmitry Baryshkov wrote:
> On Tue, Mar 11, 2025 at 05:33:54PM +0530, Vikash Garodia wrote:
>> Document the IRIS video decoder and encoder accelerator found in the
>> SA8775P platform. SA8775P has collapsible MX compared to SM8550.
> 
> How compatible is SA8775P to SM8550? Should it be using a fallback
> compatible?
They are quite compatible. At the moment i do not see any reason for not using
fallback compatible. Later, if we want to distinguish the associated platform
data for SA8775P and SM8550, the compatible can be made independent and use it
in driver to associate with its own platform data ?
> 
> This kind of comes as a more generic question: is there anything like
> 'IP version' or 'core version'? It would be really nice to determine the
> 'baseline' SoCs and make other instances compatible with the baseline.
It would be helpful if you can elaborate more on this with some drivers
following it (if any) ?

Regards,
Vikash
>>
>> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
>> ---
>>  Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>> index 440a0d7cdfe19a1ccedefc207d96b26eed5d6630..20ac596638ba33f49cce9e42d70d31a8aaa7c36e 100644
>> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
>> @@ -19,7 +19,9 @@ allOf:
>>  
>>  properties:
>>    compatible:
>> -    const: qcom,sm8550-iris
>> +    enum:
>> +      - qcom,sm8550-iris
>> +      - qcom,sa8775p-iris
>>  
>>    power-domains:
>>      maxItems: 4
>>
>> -- 
>> 2.34.1
>>
>
Krzysztof Kozlowski March 12, 2025, 8:42 a.m. UTC | #5
On 11/03/2025 18:57, Vikash Garodia wrote:
> 
> 
> On 3/11/2025 11:05 PM, Krzysztof Kozlowski wrote:
>> On 11/03/2025 13:03, Vikash Garodia wrote:
>>> Document the IRIS video decoder and encoder accelerator found in the
>>> SA8775P platform. SA8775P has collapsible MX compared to SM8550.
>> Does this make interface incompatible? Does not look like.
> Just the phandle specifier in the DT property, otherwise same.
I don't understand above. This is about hardware and its interface.
Hardware does not care about DT or its phandles.

Best regards,
Krzysztof
Dmitry Baryshkov March 12, 2025, 8:51 a.m. UTC | #6
On Wed, 12 Mar 2025 at 10:07, Vikash Garodia <quic_vgarodia@quicinc.com> wrote:
>
>
> On 3/11/2025 9:01 PM, Dmitry Baryshkov wrote:
> > On Tue, Mar 11, 2025 at 05:33:54PM +0530, Vikash Garodia wrote:
> >> Document the IRIS video decoder and encoder accelerator found in the
> >> SA8775P platform. SA8775P has collapsible MX compared to SM8550.
> >
> > How compatible is SA8775P to SM8550? Should it be using a fallback
> > compatible?
> They are quite compatible. At the moment i do not see any reason for not using
> fallback compatible. Later, if we want to distinguish the associated platform
> data for SA8775P and SM8550, the compatible can be made independent and use it
> in driver to associate with its own platform data ?

It is already independent, even if you have a fallback. Nothing stops
you from using platform-specific compat at any point in the future,
you don't even have to change schema for that.

> >
> > This kind of comes as a more generic question: is there anything like
> > 'IP version' or 'core version'? It would be really nice to determine the
> > 'baseline' SoCs and make other instances compatible with the baseline.
> It would be helpful if you can elaborate more on this with some drivers
> following it (if any) ?

iMX platforms have a lot of examples, see any of the device trees.
Another perfect example is the Qualcomm SMMU, where we stopped adding
new compats to the driver, because all implementations are declared
compatible with "qcom,smmu-500' and "arm,smmu-500".

>
> Regards,
> Vikash
> >>
> >> Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
> >> ---
> >>  Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> >> index 440a0d7cdfe19a1ccedefc207d96b26eed5d6630..20ac596638ba33f49cce9e42d70d31a8aaa7c36e 100644
> >> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> >> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> >> @@ -19,7 +19,9 @@ allOf:
> >>
> >>  properties:
> >>    compatible:
> >> -    const: qcom,sm8550-iris
> >> +    enum:
> >> +      - qcom,sm8550-iris
> >> +      - qcom,sa8775p-iris
> >>
> >>    power-domains:
> >>      maxItems: 4
> >>
> >> --
> >> 2.34.1
> >>
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
index 440a0d7cdfe19a1ccedefc207d96b26eed5d6630..20ac596638ba33f49cce9e42d70d31a8aaa7c36e 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
@@ -19,7 +19,9 @@  allOf:
 
 properties:
   compatible:
-    const: qcom,sm8550-iris
+    enum:
+      - qcom,sm8550-iris
+      - qcom,sa8775p-iris
 
   power-domains:
     maxItems: 4