diff mbox series

Bluetooth: HCI: Fix value of HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE

Message ID 20250312083847.7364-1-sy2239101@buaa.edu.cn (mailing list archive)
State Accepted
Commit 8d35126f69f25964a14be45e770d050782cbe9e2
Headers show
Series Bluetooth: HCI: Fix value of HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/SubjectPrefix success Gitlint PASS
tedd_an/BuildKernel success BuildKernel PASS
tedd_an/CheckAllWarning success CheckAllWarning PASS
tedd_an/CheckSparse success CheckSparse PASS
tedd_an/BuildKernel32 success BuildKernel32 PASS
tedd_an/TestRunnerSetup success TestRunnerSetup PASS
tedd_an/TestRunner_l2cap-tester success TestRunner PASS
tedd_an/TestRunner_iso-tester success TestRunner PASS
tedd_an/TestRunner_bnep-tester success TestRunner PASS
tedd_an/TestRunner_mgmt-tester success TestRunner PASS
tedd_an/TestRunner_rfcomm-tester success TestRunner PASS
tedd_an/TestRunner_sco-tester success TestRunner PASS
tedd_an/TestRunner_ioctl-tester success TestRunner PASS
tedd_an/TestRunner_mesh-tester success TestRunner PASS
tedd_an/TestRunner_smp-tester success TestRunner PASS
tedd_an/TestRunner_userchan-tester success TestRunner PASS

Commit Message

Si-Jie Bai March 12, 2025, 8:38 a.m. UTC 
HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE is actually 0x1a not 0x1e:

BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 1, Part F
page 371:

  0x1A  Unsupported Remote Feature

Signed-off-by: Si-Jie Bai <sy2239101@buaa.edu.cn>
---
 include/net/bluetooth/hci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Menzel March 12, 2025, 8:54 a.m. UTC | #1 
[Cc: +Jonas Dreßler]

Dear Si-Jie,


Welcome to the mailing list, and thank you for your patch!

Am 12.03.25 um 09:38 schrieb Si-Jie Bai:
> HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE is actually 0x1a not 0x1e:
> 
> BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 1, Part F
> page 371:

The above length is 66 characters (< 72), and fits in one line.

>    0x1A  Unsupported Remote Feature
> 

Maybe add:

The value was probably changed by mistake, when defining the macro.

Please add a Fixes: tag. It should be:

Fixes: 79c0868ad65a ("Bluetooth: hci_event: Use HCI error defines 
instead of magic values")

> Signed-off-by: Si-Jie Bai <sy2239101@buaa.edu.cn>
> ---
>   include/net/bluetooth/hci.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 0d51970d8..3ec915738 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -683,7 +683,7 @@ enum {
>   #define HCI_ERROR_REMOTE_POWER_OFF	0x15
>   #define HCI_ERROR_LOCAL_HOST_TERM	0x16
>   #define HCI_ERROR_PAIRING_NOT_ALLOWED	0x18
> -#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE	0x1e
> +#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE	0x1a
>   #define HCI_ERROR_INVALID_LL_PARAMS	0x1e
>   #define HCI_ERROR_UNSPECIFIED		0x1f
>   #define HCI_ERROR_ADVERTISING_TIMEOUT	0x3c

With the above fixes, you can add:

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul
bluez.test.bot@gmail.com March 12, 2025, 9:02 a.m. UTC | #2 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=943013

---Test result---

Test Summary:
CheckPatch                    PENDING   0.29 seconds
GitLint                       PENDING   0.22 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      24.61 seconds
CheckAllWarning               PASS      27.21 seconds
CheckSparse                   PASS      30.56 seconds
BuildKernel32                 PASS      24.01 seconds
TestRunnerSetup               PASS      430.35 seconds
TestRunner_l2cap-tester       PASS      20.79 seconds
TestRunner_iso-tester         PASS      28.31 seconds
TestRunner_bnep-tester        PASS      4.73 seconds
TestRunner_mgmt-tester        PASS      122.13 seconds
TestRunner_rfcomm-tester      PASS      7.84 seconds
TestRunner_sco-tester         PASS      16.20 seconds
TestRunner_ioctl-tester       PASS      8.37 seconds
TestRunner_mesh-tester        PASS      6.09 seconds
TestRunner_smp-tester         PASS      7.21 seconds
TestRunner_userchan-tester    PASS      4.98 seconds
IncrementalBuild              PENDING   1.00 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz March 12, 2025, 7:28 p.m. UTC | #3 
Hi Si-Jie,

On Wed, Mar 12, 2025 at 4:39 AM Si-Jie Bai <sy2239101@buaa.edu.cn> wrote:
>
> HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE is actually 0x1a not 0x1e:
>
> BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 1, Part F
> page 371:
>
>   0x1A  Unsupported Remote Feature
>
> Signed-off-by: Si-Jie Bai <sy2239101@buaa.edu.cn>
> ---
>  include/net/bluetooth/hci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 0d51970d8..3ec915738 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -683,7 +683,7 @@ enum {
>  #define HCI_ERROR_REMOTE_POWER_OFF     0x15
>  #define HCI_ERROR_LOCAL_HOST_TERM      0x16
>  #define HCI_ERROR_PAIRING_NOT_ALLOWED  0x18
> -#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE   0x1e
> +#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE   0x1a
>  #define HCI_ERROR_INVALID_LL_PARAMS    0x1e
>  #define HCI_ERROR_UNSPECIFIED          0x1f
>  #define HCI_ERROR_ADVERTISING_TIMEOUT  0x3c
> --
> 2.25.1

I tooked the following one over this since it better explains the
issue and had the Fixes tag:

https://patchwork.kernel.org/project/bluetooth/patch/20250312190943.152482-1-arkadiusz.bokowy@gmail.com/
patchwork-bot+bluetooth@kernel.org March 12, 2025, 7:30 p.m. UTC | #4 
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 12 Mar 2025 16:38:47 +0800 you wrote:
> HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE is actually 0x1a not 0x1e:
> 
> BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 1, Part F
> page 371:
> 
>   0x1A  Unsupported Remote Feature
> 
> [...]

Here is the summary with links:
  - Bluetooth: HCI: Fix value of HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE
    https://git.kernel.org/bluetooth/bluetooth-next/c/8d35126f69f2

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 0d51970d8..3ec915738 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -683,7 +683,7 @@  enum {
 #define HCI_ERROR_REMOTE_POWER_OFF	0x15
 #define HCI_ERROR_LOCAL_HOST_TERM	0x16
 #define HCI_ERROR_PAIRING_NOT_ALLOWED	0x18
-#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE	0x1e
+#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE	0x1a
 #define HCI_ERROR_INVALID_LL_PARAMS	0x1e
 #define HCI_ERROR_UNSPECIFIED		0x1f
 #define HCI_ERROR_ADVERTISING_TIMEOUT	0x3c