mbox series

[0/9] drm/i915/display: conversions to struct intel_display

Message ID cover.1741715981.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915/display: conversions to struct intel_display | expand

Message

Jani Nikula March 11, 2025, 6 p.m. UTC
Primarily convert all hotplug and irq code to struct intel_display, and
then some.

Jani Nikula (9):
  drm/i915/color: prefer display->platform.<platform> checks
  drm/i915/connector: convert intel_connector.c to struct intel_display
  drm/i915/hotplug: convert intel_hotplug.[ch] to struct intel_display
  drm/i915/hotplug: convert hotplug debugfs to struct intel_display
  drm/i915/hotplug: convert hotplug irq handling to intel_de_*()
  drm/i915/hotplug: convert intel_hotplug_irq.[ch] to struct
    intel_display
  drm/i915/irq: convert intel_display_irq.[ch] interfaces to struct
    intel_display
  drm/i915/irq: convert rest of intel_display_irq.[ch] to struct
    intel_display
  drm/i915/display: rename I915_HAS_HOTPLUG() to HAS_HOTPLUG

 drivers/gpu/drm/i915/display/i9xx_plane.c     |  24 +-
 drivers/gpu/drm/i915/display/intel_color.c    |  16 +-
 .../gpu/drm/i915/display/intel_connector.c    |  45 +-
 drivers/gpu/drm/i915/display/intel_crt.c      |  10 +-
 .../drm/i915/display/intel_display_debugfs.c  |   2 +-
 .../drm/i915/display/intel_display_device.h   |   2 +-
 .../drm/i915/display/intel_display_driver.c   |  16 +-
 .../gpu/drm/i915/display/intel_display_irq.c  | 742 +++++++++---------
 .../gpu/drm/i915/display/intel_display_irq.h  |  75 +-
 .../i915/display/intel_display_power_well.c   |  18 +-
 .../drm/i915/display/intel_display_reset.c    |   4 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |   2 +-
 .../drm/i915/display/intel_fifo_underrun.c    |  27 +-
 drivers/gpu/drm/i915/display/intel_hotplug.c  | 348 ++++----
 drivers/gpu/drm/i915/display/intel_hotplug.h  |  26 +-
 .../gpu/drm/i915/display/intel_hotplug_irq.c  | 623 +++++++--------
 .../gpu/drm/i915/display/intel_hotplug_irq.h  |  28 +-
 drivers/gpu/drm/i915/display/intel_pipe_crc.c |   3 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c     |   2 +-
 drivers/gpu/drm/i915/display/intel_tv.c       |   4 +-
 .../drm/i915/display/skl_universal_plane.c    |   6 +-
 drivers/gpu/drm/i915/gt/intel_rps.c           |   6 +-
 drivers/gpu/drm/i915/i915_driver.c            |  14 +-
 drivers/gpu/drm/i915/i915_irq.c               | 123 +--
 drivers/gpu/drm/xe/display/xe_display.c       |  38 +-
 25 files changed, 1118 insertions(+), 1086 deletions(-)

Comments

Ville Syrjälä March 11, 2025, 7:13 p.m. UTC | #1
On Tue, Mar 11, 2025 at 08:00:34PM +0200, Jani Nikula wrote:
> Primarily convert all hotplug and irq code to struct intel_display, and
> then some.
> 
> Jani Nikula (9):
>   drm/i915/color: prefer display->platform.<platform> checks
>   drm/i915/connector: convert intel_connector.c to struct intel_display
>   drm/i915/hotplug: convert intel_hotplug.[ch] to struct intel_display
>   drm/i915/hotplug: convert hotplug debugfs to struct intel_display
>   drm/i915/hotplug: convert hotplug irq handling to intel_de_*()
>   drm/i915/hotplug: convert intel_hotplug_irq.[ch] to struct
>     intel_display
>   drm/i915/irq: convert intel_display_irq.[ch] interfaces to struct
>     intel_display
>   drm/i915/irq: convert rest of intel_display_irq.[ch] to struct
>     intel_display
>   drm/i915/display: rename I915_HAS_HOTPLUG() to HAS_HOTPLUG

Looked reasonable to me. Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
>  drivers/gpu/drm/i915/display/i9xx_plane.c     |  24 +-
>  drivers/gpu/drm/i915/display/intel_color.c    |  16 +-
>  .../gpu/drm/i915/display/intel_connector.c    |  45 +-
>  drivers/gpu/drm/i915/display/intel_crt.c      |  10 +-
>  .../drm/i915/display/intel_display_debugfs.c  |   2 +-
>  .../drm/i915/display/intel_display_device.h   |   2 +-
>  .../drm/i915/display/intel_display_driver.c   |  16 +-
>  .../gpu/drm/i915/display/intel_display_irq.c  | 742 +++++++++---------
>  .../gpu/drm/i915/display/intel_display_irq.h  |  75 +-
>  .../i915/display/intel_display_power_well.c   |  18 +-
>  .../drm/i915/display/intel_display_reset.c    |   4 +-
>  drivers/gpu/drm/i915/display/intel_dp.c       |   2 +-
>  .../drm/i915/display/intel_fifo_underrun.c    |  27 +-
>  drivers/gpu/drm/i915/display/intel_hotplug.c  | 348 ++++----
>  drivers/gpu/drm/i915/display/intel_hotplug.h  |  26 +-
>  .../gpu/drm/i915/display/intel_hotplug_irq.c  | 623 +++++++--------
>  .../gpu/drm/i915/display/intel_hotplug_irq.h  |  28 +-
>  drivers/gpu/drm/i915/display/intel_pipe_crc.c |   3 +-
>  drivers/gpu/drm/i915/display/intel_sdvo.c     |   2 +-
>  drivers/gpu/drm/i915/display/intel_tv.c       |   4 +-
>  .../drm/i915/display/skl_universal_plane.c    |   6 +-
>  drivers/gpu/drm/i915/gt/intel_rps.c           |   6 +-
>  drivers/gpu/drm/i915/i915_driver.c            |  14 +-
>  drivers/gpu/drm/i915/i915_irq.c               | 123 +--
>  drivers/gpu/drm/xe/display/xe_display.c       |  38 +-
>  25 files changed, 1118 insertions(+), 1086 deletions(-)
> 
> -- 
> 2.39.5
Jani Nikula March 12, 2025, 8:51 a.m. UTC | #2
On Tue, 11 Mar 2025, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/display: conversions to struct intel_display (rev2)
> URL   : https://patchwork.freedesktop.org/series/144748/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_16265 -> Patchwork_144748v2
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_144748v2 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_144748v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/index.html
>
> Participating hosts (44 -> 43)
> ------------------------------
>
>   Missing    (1): fi-snb-2520m 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_144748v2:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@i915_pm_rpm@module-reload:
>     - bat-rpls-4:         [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-rpls-4/igt@i915_pm_rpm@module-reload.html

Seems unrelated.

>
>   * igt@kms_addfb_basic@too-high:
>     - fi-kbl-8809g:       NOTRUN -> [FAIL][3] +3 other tests fail
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@kms_addfb_basic@too-high.html
>
>   * igt@kms_force_connector_basic@force-connector-state:
>     - fi-kbl-8809g:       NOTRUN -> [DMESG-WARN][4]
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@kms_force_connector_basic@force-connector-state.html
>
>   * igt@kms_force_connector_basic@force-edid:
>     - fi-kbl-8809g:       NOTRUN -> [DMESG-FAIL][5]
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@kms_force_connector_basic@force-edid.html

We seem to be probing amdgpu again for fi-kbl-8809g. Weren't we supposed
to block that?

Please fix/re-report.

BR,
Jani.


>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_144748v2 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@core_auth@basic-auth:
>     - fi-kbl-8809g:       NOTRUN -> [DMESG-WARN][6] ([i915#10462]) +1 other test dmesg-warn
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@core_auth@basic-auth.html
>
>   * igt@debugfs_test@basic-hwmon:
>     - bat-twl-2:          NOTRUN -> [SKIP][7] ([i915#9318])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@debugfs_test@basic-hwmon.html
>
>   * igt@dmabuf@all-tests:
>     - fi-pnv-d510:        NOTRUN -> [INCOMPLETE][8] ([i915#12904]) +1 other test incomplete
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-pnv-d510/igt@dmabuf@all-tests.html
>     - bat-apl-1:          NOTRUN -> [INCOMPLETE][9] ([i915#12904]) +1 other test incomplete
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-apl-1/igt@dmabuf@all-tests.html
>
>   * igt@fbdev@info:
>     - fi-kbl-8809g:       NOTRUN -> [SKIP][10] ([i915#1849])
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@fbdev@info.html
>
>   * igt@gem_huc_copy@huc-copy:
>     - fi-kbl-8809g:       NOTRUN -> [SKIP][11] ([i915#2190])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
>     - fi-skl-6600u:       NOTRUN -> [SKIP][12] ([i915#2190])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html
>
>   * igt@gem_lmem_swapping@basic:
>     - bat-twl-2:          NOTRUN -> [SKIP][13] ([i915#10213] / [i915#11671]) +3 other tests skip
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@gem_lmem_swapping@basic.html
>
>   * igt@gem_lmem_swapping@parallel-random-engines:
>     - bat-adls-6:         NOTRUN -> [SKIP][14] ([i915#4613]) +3 other tests skip
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-adls-6/igt@gem_lmem_swapping@parallel-random-engines.html
>     - fi-kbl-8809g:       NOTRUN -> [SKIP][15] ([i915#4613]) +3 other tests skip
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@gem_lmem_swapping@parallel-random-engines.html
>     - bat-apl-1:          NOTRUN -> [SKIP][16] +3 other tests skip
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-apl-1/igt@gem_lmem_swapping@parallel-random-engines.html
>
>   * igt@gem_lmem_swapping@random-engines:
>     - fi-skl-6600u:       NOTRUN -> [SKIP][17] ([i915#4613]) +3 other tests skip
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-skl-6600u/igt@gem_lmem_swapping@random-engines.html
>
>   * igt@gem_tiled_pread_basic:
>     - bat-twl-2:          NOTRUN -> [SKIP][18] ([i915#11031])
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@gem_tiled_pread_basic.html
>
>   * igt@i915_pm_rps@basic-api:
>     - bat-twl-2:          NOTRUN -> [SKIP][19] ([i915#10209] / [i915#11681])
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@i915_pm_rps@basic-api.html
>
>   * igt@i915_selftest@live@workarounds:
>     - bat-mtlp-6:         [PASS][20] -> [DMESG-FAIL][21] ([i915#12061]) +1 other test dmesg-fail
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>     - bat-twl-2:          NOTRUN -> [SKIP][22] ([i915#11030] / [i915#11731]) +1 other test skip
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>
>   * igt@kms_dsc@dsc-basic:
>     - fi-kbl-8809g:       NOTRUN -> [SKIP][23] +62 other tests skip
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@kms_dsc@dsc-basic.html
>     - fi-skl-6600u:       NOTRUN -> [SKIP][24] +10 other tests skip
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-skl-6600u/igt@kms_dsc@dsc-basic.html
>     - bat-twl-2:          NOTRUN -> [SKIP][25] ([i915#9886])
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@kms_dsc@dsc-basic.html
>
>   * igt@kms_force_connector_basic@force-load-detect:
>     - bat-twl-2:          NOTRUN -> [SKIP][26] ([i915#11032])
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@kms_force_connector_basic@force-load-detect.html
>
>   * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
>     - bat-dg2-11:         [PASS][27] -> [SKIP][28] ([i915#9197]) +3 other tests skip
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>
>   * igt@kms_psr@psr-primary-mmap-gtt:
>     - fi-pnv-d510:        NOTRUN -> [SKIP][29] +33 other tests skip
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-pnv-d510/igt@kms_psr@psr-primary-mmap-gtt.html
>
>   * igt@kms_setmode@basic-clone-single-crtc:
>     - bat-twl-2:          NOTRUN -> [SKIP][30] ([i915#8809])
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@kms_setmode@basic-clone-single-crtc.html
>
>   * igt@prime_vgem@basic-fence-read:
>     - bat-twl-2:          NOTRUN -> [SKIP][31] ([i915#10212] / [i915#3708])
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@prime_vgem@basic-fence-read.html
>
>   * igt@prime_vgem@basic-read:
>     - bat-twl-2:          NOTRUN -> [SKIP][32] ([i915#10214] / [i915#3708])
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@prime_vgem@basic-read.html
>
>   * igt@prime_vgem@basic-write:
>     - bat-twl-2:          NOTRUN -> [SKIP][33] ([i915#10216] / [i915#3708])
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/igt@prime_vgem@basic-write.html
>
>   
> #### Possible fixes ####
>
>   * igt@core_hotunplug@unbind-rebind:
>     - bat-adls-6:         [ABORT][34] ([i915#13571]) -> [PASS][35]
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-adls-6/igt@core_hotunplug@unbind-rebind.html
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-adls-6/igt@core_hotunplug@unbind-rebind.html
>
>   * igt@i915_selftest@live:
>     - bat-mtlp-8:         [DMESG-FAIL][36] ([i915#12061]) -> [PASS][37] +1 other test pass
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-mtlp-8/igt@i915_selftest@live.html
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-mtlp-8/igt@i915_selftest@live.html
>     - fi-bsw-n3050:       [DMESG-FAIL][38] ([i915#12435]) -> [PASS][39] +1 other test pass
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/fi-bsw-n3050/igt@i915_selftest@live.html
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-bsw-n3050/igt@i915_selftest@live.html
>
>   * igt@i915_selftest@live@workarounds:
>     - bat-mtlp-9:         [DMESG-FAIL][40] ([i915#12061]) -> [PASS][41] +1 other test pass
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
>
>   * igt@vgem_basic@unload:
>     - bat-apl-1:          [ABORT][42] -> [PASS][43]
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-apl-1/igt@vgem_basic@unload.html
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-apl-1/igt@vgem_basic@unload.html
>
>   
>   [i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
>   [i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
>   [i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
>   [i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
>   [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
>   [i915#10462]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10462
>   [i915#11030]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11030
>   [i915#11031]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11031
>   [i915#11032]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11032
>   [i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
>   [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
>   [i915#11731]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11731
>   [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
>   [i915#12435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12435
>   [i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
>   [i915#13571]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13571
>   [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
>   [i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
>   [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
>   [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
>   [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
>   [i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
>   [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
>   [i915#9886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_16265 -> Patchwork_144748v2
>
>   CI-20190529: 20190529
>   CI_DRM_16265: eb17816e52395a403aa0b447aa0befa9d2f86dd5 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8270: 49751c5c11723262ec66e564c76503f74a9fa831 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_144748v2: eb17816e52395a403aa0b447aa0befa9d2f86dd5 @ git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/index.html
Ravali, JupallyX March 12, 2025, 10:30 a.m. UTC | #3
Hi,

https://patchwork.freedesktop.org/series/144748/ - Re-reported.
i915.CI.BAT - Re-reported.

Thanks,
Ravali.

-----Original Message-----
From: I915-ci-infra <i915-ci-infra-bounces@lists.freedesktop.org> On Behalf Of Jani Nikula
Sent: 12 March 2025 14:22
To: I915-ci-infra@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ i915.CI.BAT: failure for drm/i915/display: conversions to struct intel_display (rev2)

On Tue, 11 Mar 2025, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/display: conversions to struct intel_display (rev2)
> URL   : https://patchwork.freedesktop.org/series/144748/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_16265 -> Patchwork_144748v2 
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_144748v2 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_144748v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/index.html
>
> Participating hosts (44 -> 43)
> ------------------------------
>
>   Missing    (1): fi-snb-2520m 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_144748v2:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@i915_pm_rpm@module-reload:
>     - bat-rpls-4:         [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-rpls-4
> /igt@i915_pm_rpm@module-reload.html

Seems unrelated.

>
>   * igt@kms_addfb_basic@too-high:
>     - fi-kbl-8809g:       NOTRUN -> [FAIL][3] +3 other tests fail
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-880
> 9g/igt@kms_addfb_basic@too-high.html
>
>   * igt@kms_force_connector_basic@force-connector-state:
>     - fi-kbl-8809g:       NOTRUN -> [DMESG-WARN][4]
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-880
> 9g/igt@kms_force_connector_basic@force-connector-state.html
>
>   * igt@kms_force_connector_basic@force-edid:
>     - fi-kbl-8809g:       NOTRUN -> [DMESG-FAIL][5]
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-880
> 9g/igt@kms_force_connector_basic@force-edid.html

We seem to be probing amdgpu again for fi-kbl-8809g. Weren't we supposed to block that?

Please fix/re-report.

BR,
Jani.


>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_144748v2 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@core_auth@basic-auth:
>     - fi-kbl-8809g:       NOTRUN -> [DMESG-WARN][6] ([i915#10462]) +1 other test dmesg-warn
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-880
> 9g/igt@core_auth@basic-auth.html
>
>   * igt@debugfs_test@basic-hwmon:
>     - bat-twl-2:          NOTRUN -> [SKIP][7] ([i915#9318])
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@debugfs_test@basic-hwmon.html
>
>   * igt@dmabuf@all-tests:
>     - fi-pnv-d510:        NOTRUN -> [INCOMPLETE][8] ([i915#12904]) +1 other test incomplete
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-pnv-d510/igt@dmabuf@all-tests.html
>     - bat-apl-1:          NOTRUN -> [INCOMPLETE][9] ([i915#12904]) +1 other test incomplete
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-apl-1/
> igt@dmabuf@all-tests.html
>
>   * igt@fbdev@info:
>     - fi-kbl-8809g:       NOTRUN -> [SKIP][10] ([i915#1849])
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-880
> 9g/igt@fbdev@info.html
>
>   * igt@gem_huc_copy@huc-copy:
>     - fi-kbl-8809g:       NOTRUN -> [SKIP][11] ([i915#2190])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
>     - fi-skl-6600u:       NOTRUN -> [SKIP][12] ([i915#2190])
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-skl-660
> 0u/igt@gem_huc_copy@huc-copy.html
>
>   * igt@gem_lmem_swapping@basic:
>     - bat-twl-2:          NOTRUN -> [SKIP][13] ([i915#10213] / [i915#11671]) +3 other tests skip
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@gem_lmem_swapping@basic.html
>
>   * igt@gem_lmem_swapping@parallel-random-engines:
>     - bat-adls-6:         NOTRUN -> [SKIP][14] ([i915#4613]) +3 other tests skip
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-adls-6/igt@gem_lmem_swapping@parallel-random-engines.html
>     - fi-kbl-8809g:       NOTRUN -> [SKIP][15] ([i915#4613]) +3 other tests skip
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@gem_lmem_swapping@parallel-random-engines.html
>     - bat-apl-1:          NOTRUN -> [SKIP][16] +3 other tests skip
>    [16]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-apl-1/
> igt@gem_lmem_swapping@parallel-random-engines.html
>
>   * igt@gem_lmem_swapping@random-engines:
>     - fi-skl-6600u:       NOTRUN -> [SKIP][17] ([i915#4613]) +3 other tests skip
>    [17]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-skl-660
> 0u/igt@gem_lmem_swapping@random-engines.html
>
>   * igt@gem_tiled_pread_basic:
>     - bat-twl-2:          NOTRUN -> [SKIP][18] ([i915#11031])
>    [18]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@gem_tiled_pread_basic.html
>
>   * igt@i915_pm_rps@basic-api:
>     - bat-twl-2:          NOTRUN -> [SKIP][19] ([i915#10209] / [i915#11681])
>    [19]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@i915_pm_rps@basic-api.html
>
>   * igt@i915_selftest@live@workarounds:
>     - bat-mtlp-6:         [PASS][20] -> [DMESG-FAIL][21] ([i915#12061]) +1 other test dmesg-fail
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>    [21]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-mtlp-6
> /igt@i915_selftest@live@workarounds.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>     - bat-twl-2:          NOTRUN -> [SKIP][22] ([i915#11030] / [i915#11731]) +1 other test skip
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>
>   * igt@kms_dsc@dsc-basic:
>     - fi-kbl-8809g:       NOTRUN -> [SKIP][23] +62 other tests skip
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-kbl-8809g/igt@kms_dsc@dsc-basic.html
>     - fi-skl-6600u:       NOTRUN -> [SKIP][24] +10 other tests skip
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-skl-6600u/igt@kms_dsc@dsc-basic.html
>     - bat-twl-2:          NOTRUN -> [SKIP][25] ([i915#9886])
>    [25]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@kms_dsc@dsc-basic.html
>
>   * igt@kms_force_connector_basic@force-load-detect:
>     - bat-twl-2:          NOTRUN -> [SKIP][26] ([i915#11032])
>    [26]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@kms_force_connector_basic@force-load-detect.html
>
>   * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
>     - bat-dg2-11:         [PASS][27] -> [SKIP][28] ([i915#9197]) +3 other tests skip
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>    [28]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-dg2-11
> /igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>
>   * igt@kms_psr@psr-primary-mmap-gtt:
>     - fi-pnv-d510:        NOTRUN -> [SKIP][29] +33 other tests skip
>    [29]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-pnv-d51
> 0/igt@kms_psr@psr-primary-mmap-gtt.html
>
>   * igt@kms_setmode@basic-clone-single-crtc:
>     - bat-twl-2:          NOTRUN -> [SKIP][30] ([i915#8809])
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@kms_setmode@basic-clone-single-crtc.html
>
>   * igt@prime_vgem@basic-fence-read:
>     - bat-twl-2:          NOTRUN -> [SKIP][31] ([i915#10212] / [i915#3708])
>    [31]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@prime_vgem@basic-fence-read.html
>
>   * igt@prime_vgem@basic-read:
>     - bat-twl-2:          NOTRUN -> [SKIP][32] ([i915#10214] / [i915#3708])
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@prime_vgem@basic-read.html
>
>   * igt@prime_vgem@basic-write:
>     - bat-twl-2:          NOTRUN -> [SKIP][33] ([i915#10216] / [i915#3708])
>    [33]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-twl-2/
> igt@prime_vgem@basic-write.html
>
>   
> #### Possible fixes ####
>
>   * igt@core_hotunplug@unbind-rebind:
>     - bat-adls-6:         [ABORT][34] ([i915#13571]) -> [PASS][35]
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-adls-6/igt@core_hotunplug@unbind-rebind.html
>    [35]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-adls-6
> /igt@core_hotunplug@unbind-rebind.html
>
>   * igt@i915_selftest@live:
>     - bat-mtlp-8:         [DMESG-FAIL][36] ([i915#12061]) -> [PASS][37] +1 other test pass
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-mtlp-8/igt@i915_selftest@live.html
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-mtlp-8/igt@i915_selftest@live.html
>     - fi-bsw-n3050:       [DMESG-FAIL][38] ([i915#12435]) -> [PASS][39] +1 other test pass
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/fi-bsw-n3050/igt@i915_selftest@live.html
>    [39]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/fi-bsw-n30
> 50/igt@i915_selftest@live.html
>
>   * igt@i915_selftest@live@workarounds:
>     - bat-mtlp-9:         [DMESG-FAIL][40] ([i915#12061]) -> [PASS][41] +1 other test pass
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
>    [41]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-mtlp-9
> /igt@i915_selftest@live@workarounds.html
>
>   * igt@vgem_basic@unload:
>     - bat-apl-1:          [ABORT][42] -> [PASS][43]
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16265/bat-apl-1/igt@vgem_basic@unload.html
>    [43]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/bat-apl-1/
> igt@vgem_basic@unload.html
>
>   
>   [i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
>   [i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
>   [i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
>   [i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
>   [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
>   [i915#10462]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10462
>   [i915#11030]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11030
>   [i915#11031]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11031
>   [i915#11032]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11032
>   [i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
>   [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
>   [i915#11731]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11731
>   [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
>   [i915#12435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12435
>   [i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
>   [i915#13571]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13571
>   [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
>   [i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
>   [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
>   [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
>   [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
>   [i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
>   [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
>   [i915#9886]: 
> https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_16265 -> Patchwork_144748v2
>
>   CI-20190529: 20190529
>   CI_DRM_16265: eb17816e52395a403aa0b447aa0befa9d2f86dd5 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8270: 49751c5c11723262ec66e564c76503f74a9fa831 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_144748v2: eb17816e52395a403aa0b447aa0befa9d2f86dd5 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144748v2/index.html

--
Jani Nikula, Intel