| Message ID | 20250305214108.1327208-2-jonas@kwiboo.se (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | rockchip: Add support for onboard eMMC on Radxa E20C | expand |
On Wed, Mar 05, 2025 at 09:41:02PM +0000, Jonas Karlman wrote: > The SDHCI controller in Rockchip RK3528 is similar to the one included > in RK3588. > > Add compatible string for the SDHCI controller in RK3528. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> > --- No power domains here? Post complete support, so this won't have to be changed in near future. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Krzysztof, On 2025-03-06 10:36, Krzysztof Kozlowski wrote: > On Wed, Mar 05, 2025 at 09:41:02PM +0000, Jonas Karlman wrote: >> The SDHCI controller in Rockchip RK3528 is similar to the one included >> in RK3588. >> >> Add compatible string for the SDHCI controller in RK3528. >> >> Signed-off-by: Jonas Karlman <jonas@kwiboo.se> >> --- > > No power domains here? Post complete support, so this won't have to be > changed in near future. To my knowledge this should be complete support. However, there are some rx/tx tap num and strobe delay num configuration that needs to be tuned to fully support the faster HS400/HS400ES transfer modes. For that we could need something like the PHY output/input tap delays described in mmc/sdhci-am654.yaml. Still unclear to me if the different delayed used by vendor driver is SoC specific and can live in driver or if they instead are reference board specific and could be part of the device tree. Regards, Jonas > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
On Wed, 5 Mar 2025 at 22:41, Jonas Karlman <jonas@kwiboo.se> wrote: > > The SDHCI controller in Rockchip RK3528 is similar to the one included > in RK3588. > > Add compatible string for the SDHCI controller in RK3528. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> Applied for next, thanks! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > index c3d5e0230af1..fb2115e805f5 100644 > --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > @@ -14,7 +14,9 @@ properties: > compatible: > oneOf: > - items: > - - const: rockchip,rk3576-dwcmshc > + - enum: > + - rockchip,rk3528-dwcmshc > + - rockchip,rk3576-dwcmshc > - const: rockchip,rk3588-dwcmshc > - enum: > - rockchip,rk3568-dwcmshc > -- > 2.48.1 >
diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml index c3d5e0230af1..fb2115e805f5 100644 --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml @@ -14,7 +14,9 @@ properties: compatible: oneOf: - items: - - const: rockchip,rk3576-dwcmshc + - enum: + - rockchip,rk3528-dwcmshc + - rockchip,rk3576-dwcmshc - const: rockchip,rk3588-dwcmshc - enum: - rockchip,rk3568-dwcmshc
The SDHCI controller in Rockchip RK3528 is similar to the one included in RK3588. Add compatible string for the SDHCI controller in RK3528. Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)