diff mbox series

[BlueZ,v1,1/2] sco-tester: Fix closing the socket

Message ID 20250311194226.15109-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit df891f0ff44e0d67c4e60bd6f9e03b89a316164e
Headers show
Series [BlueZ,v1,1/2] sco-tester: Fix closing the socket | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch warning CheckSparse WARNING tools/sco-tester.c: note: in included file:./lib/bluetooth.h:232:15: warning: array of flexible structures./lib/bluetooth.h:237:31: warning: array of flexible structuresemulator/btdev.c:451:29: warning: Variable length array is used.
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Luiz Augusto von Dentz March 11, 2025, 7:42 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

When writting data the socket shall not be closed until all the data
could be transmitted or the test times out.
---
 tools/sco-tester.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

bluez.test.bot@gmail.com March 11, 2025, 9:11 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=942846

---Test result---

Test Summary:
CheckPatch                    PENDING   0.18 seconds
GitLint                       PENDING   0.23 seconds
BuildEll                      PASS      20.37 seconds
BluezMake                     PASS      1467.50 seconds
MakeCheck                     PASS      13.22 seconds
MakeDistcheck                 PASS      157.13 seconds
CheckValgrind                 PASS      214.41 seconds
CheckSmatch                   WARNING   284.15 seconds
bluezmakeextell               PASS      97.80 seconds
IncrementalBuild              PENDING   0.33 seconds
ScanBuild                     PASS      867.64 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
tools/sco-tester.c: note: in included file:./lib/bluetooth.h:232:15: warning: array of flexible structures./lib/bluetooth.h:237:31: warning: array of flexible structuresemulator/btdev.c:451:29: warning: Variable length array is used.
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org March 12, 2025, 2:40 p.m. UTC | #2
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 11 Mar 2025 15:42:25 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> When writting data the socket shall not be closed until all the data
> could be transmitted or the test times out.
> ---
>  tools/sco-tester.c | 3 +++
>  1 file changed, 3 insertions(+)

Here is the summary with links:
  - [BlueZ,v1,1/2] sco-tester: Fix closing the socket
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=df891f0ff44e
  - [BlueZ,v1,2/2] btdev: Fix double lookup
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=adcd73901831

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/sco-tester.c b/tools/sco-tester.c
index e6888348bfab..b88631d89034 100644
--- a/tools/sco-tester.c
+++ b/tools/sco-tester.c
@@ -821,6 +821,9 @@  static gboolean sco_connect_cb(GIOChannel *io, GIOCondition cond,
 					errno);
 			err = -errno;
 		}
+
+		/* Don't close the socket until all data is sent */
+		g_io_channel_set_close_on_unref(io, FALSE);
 	}
 
 	if (scodata->shutdown) {