diff mbox series

error: Strip trailing '\n' from an error string argument

Message ID 20250312143504.1659061-1-armbru@redhat.com (mailing list archive)
State New
Headers show
Series error: Strip trailing '\n' from an error string argument | expand

Commit Message

Markus Armbruster March 12, 2025, 2:35 p.m. UTC
Tracked down with scripts/coccinelle/err-bad-newline.cocci.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 net/vmnet-common.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Maydell March 12, 2025, 2:50 p.m. UTC | #1
On Wed, 12 Mar 2025 at 14:35, Markus Armbruster <armbru@redhat.com> wrote:
>
> Tracked down with scripts/coccinelle/err-bad-newline.cocci.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  net/vmnet-common.m | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/vmnet-common.m b/net/vmnet-common.m
> index 54d900ba67..ab33ce2b0c 100644
> --- a/net/vmnet-common.m
> +++ b/net/vmnet-common.m
> @@ -94,7 +94,7 @@ ssize_t vmnet_receive_common(NetClientState *nc,
>
>      if_status = vmnet_write(s->vmnet_if, &packet, &pkt_cnt);
>      if (if_status != VMNET_SUCCESS) {
> -        error_report("vmnet: write error: %s\n",
> +        error_report("vmnet: write error: %s",
>                       vmnet_status_map_str(if_status));
>          return -1;
>      }
> --

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM
Philippe Mathieu-Daudé March 12, 2025, 7:08 p.m. UTC | #2
On 12/3/25 15:35, Markus Armbruster wrote:
> Tracked down with scripts/coccinelle/err-bad-newline.cocci.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   net/vmnet-common.m | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/net/vmnet-common.m b/net/vmnet-common.m
index 54d900ba67..ab33ce2b0c 100644
--- a/net/vmnet-common.m
+++ b/net/vmnet-common.m
@@ -94,7 +94,7 @@  ssize_t vmnet_receive_common(NetClientState *nc,
 
     if_status = vmnet_write(s->vmnet_if, &packet, &pkt_cnt);
     if (if_status != VMNET_SUCCESS) {
-        error_report("vmnet: write error: %s\n",
+        error_report("vmnet: write error: %s",
                      vmnet_status_map_str(if_status));
         return -1;
     }