| Message ID | 20250313130918.4238-3-quic_kaushalk@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Enable QPIC BAM and QPIC NAND support for SDX75 | expand |
On 13/03/2025 14:09, Kaushal Kumar wrote: > SDX75 BAM DMA controller has DMA-coherent support so define > it in the properties section, without which 'dtbs_check' > reports the following error: > > controller@1c9c000: 'dma-coherent' does not match any of the > regexes: 'pinctrl-[0-9]+' How can I reproduce it? > Fixes tag? > Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com> > --- > Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > index 3ad0d9b1fbc5..c4dd6a503964 100644 > --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > @@ -39,6 +39,8 @@ properties: > "#dma-cells": > const: 1 > > + dma-coherent: true > + Which devices are DMA coherent? Best regards, Krzysztof
On 3/13/2025 8:20 PM, Krzysztof Kozlowski wrote: > On 13/03/2025 14:09, Kaushal Kumar wrote: >> SDX75 BAM DMA controller has DMA-coherent support so define >> it in the properties section, without which 'dtbs_check' >> reports the following error: >> >> controller@1c9c000: 'dma-coherent' does not match any of the >> regexes: 'pinctrl-[0-9]+' > How can I reproduce it? It is not an existing error. It is the error that would come unless the new property is defined. Will remove this part of commit text in v2. > Fixes tag? > >> Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com> >> --- >> Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> index 3ad0d9b1fbc5..c4dd6a503964 100644 >> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> @@ -39,6 +39,8 @@ properties: >> "#dma-cells": >> const: 1 >> >> + dma-coherent: true >> + > Which devices are DMA coherent? Will update it under a bam version check in v2. > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml index 3ad0d9b1fbc5..c4dd6a503964 100644 --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml @@ -39,6 +39,8 @@ properties: "#dma-cells": const: 1 + dma-coherent: true + interrupts: maxItems: 1
SDX75 BAM DMA controller has DMA-coherent support so define it in the properties section, without which 'dtbs_check' reports the following error: controller@1c9c000: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com> --- Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 ++ 1 file changed, 2 insertions(+)