| Message ID | dc39e555-8ef7-4a39-9253-65bcf3e50c01@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe() | expand |
Hi Dan Carpenter, Thanks for the patch. > -----Original Message----- > From: Dan Carpenter <dan.carpenter@linaro.org> > Sent: 14 March 2025 10:11 > Subject: [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe() > > If devm_regulator_register() fails then propagate the error code. Don't return success. > > Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Cheers, Biju > --- > drivers/mmc/host/renesas_sdhi_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index 396fa2816a15..fa6526be3638 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -1178,6 +1178,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, > of_node_put(rcfg.of_node); > if (IS_ERR(rdev)) { > dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev)); > + ret = PTR_ERR(rdev); > goto efree; > } > priv->rdev = rdev; > -- > 2.47.2
On Fri, 14 Mar 2025 at 11:12, Dan Carpenter <dan.carpenter@linaro.org> wrote: > If devm_regulator_register() fails then propagate the error code. Don't > return success. > > Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Fri, Mar 14, 2025 at 01:11:09PM +0300, Dan Carpenter wrote: > If devm_regulator_register() fails then propagate the error code. Don't > return success. > > Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Thanks for this and maintaining smatch! Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Fri, 14 Mar 2025 at 11:11, Dan Carpenter <dan.carpenter@linaro.org> wrote: > > If devm_regulator_register() fails then propagate the error code. Don't > return success. > > Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/renesas_sdhi_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index 396fa2816a15..fa6526be3638 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -1178,6 +1178,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, > of_node_put(rcfg.of_node); > if (IS_ERR(rdev)) { > dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev)); > + ret = PTR_ERR(rdev); > goto efree; > } > priv->rdev = rdev; > -- > 2.47.2 >
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index 396fa2816a15..fa6526be3638 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -1178,6 +1178,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, of_node_put(rcfg.of_node); if (IS_ERR(rdev)) { dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev)); + ret = PTR_ERR(rdev); goto efree; } priv->rdev = rdev;
If devm_regulator_register() fails then propagate the error code. Don't return success. Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/mmc/host/renesas_sdhi_core.c | 1 + 1 file changed, 1 insertion(+)