diff mbox series

[v4,2/3] x86:monitor: control monitor.c build with CONFIG_VM_EVENT option

Message ID 39235285ffe341e446bf0fd5cc345379ae394e50.1741772330.git.Sergiy_Kibrik@epam.com (mailing list archive)
State New
Headers show
Series make build of vm_event/mem_access/monitor optional | expand

Commit Message

Sergiy Kibrik March 14, 2025, 5:23 a.m. UTC
Replace more general CONFIG_HVM option with CONFIG_VM_EVENT which is more
relevant and specific to monitoring. This is only to clarify at build level
to which subsystem this file belongs.

No functional change here, as VM_EVENT depends on HVM.

Acked-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
---
 xen/arch/x86/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich March 14, 2025, 11:11 a.m. UTC | #1
On 14.03.2025 06:23, Sergiy Kibrik wrote:
> Replace more general CONFIG_HVM option with CONFIG_VM_EVENT which is more
> relevant and specific to monitoring. This is only to clarify at build level
> to which subsystem this file belongs.
> 
> No functional change here, as VM_EVENT depends on HVM.
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>

I see you've adjusted tag order in patch 3. Why not also here and in patch 1?

Jan
Sergiy Kibrik March 14, 2025, 3:02 p.m. UTC | #2
14.03.25 13:11, Jan Beulich:
> On 14.03.2025 06:23, Sergiy Kibrik wrote:
>> Replace more general CONFIG_HVM option with CONFIG_VM_EVENT which is more
>> relevant and specific to monitoring. This is only to clarify at build level
>> to which subsystem this file belongs.
>>
>> No functional change here, as VM_EVENT depends on HVM.
>>
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
> 
> I see you've adjusted tag order in patch 3. Why not also here and in patch 1?
> 

oops.. I've missed those, sorry..

   -Sergiy
diff mbox series

Patch

diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index c763f80b0b..f59c9665fd 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -49,7 +49,7 @@  obj-$(CONFIG_PV) += ioport_emulate.o
 obj-y += irq.o
 obj-$(CONFIG_KEXEC) += machine_kexec.o
 obj-y += mm.o x86_64/mm.o
-obj-$(CONFIG_HVM) += monitor.o
+obj-$(CONFIG_VM_EVENT) += monitor.o
 obj-y += mpparse.o
 obj-y += nmi.o
 obj-y += numa.o