Message ID | 20250314-ufs-dma-coherent-v1-0-bdf9f9be2919@linaro.org (mailing list archive) |
---|---|
Headers | show |
Series | Add dma-coherent for gs101 UFS dt node | expand |
On 3/14/25 8:38 AM, Peter Griffin wrote: > ufs-exynos driver enables the shareability option for gs101 which > means the descriptors need to be allocated as cacheable. Shouldn't that code be modified such that the shareability option is only set if the dma-coherent property is present in the device tree? Thanks, Bart.
On 03/14/2025, Bart Van Assche wrote: > On 3/14/25 8:38 AM, Peter Griffin wrote: > > ufs-exynos driver enables the shareability option for gs101 which > > means the descriptors need to be allocated as cacheable. > > Shouldn't that code be modified such that the shareability option is > only set if the dma-coherent property is present in the device tree? That's what we do downstream and would fix any issues when booting with an older DT that doesn't have the `dma-coherent` property set. So I agree that would be a worthy fix (which I did verify fixes the stability issues). Regards, Will > > Thanks, > > Bart.
ufs-exynos driver enables the shareability option for gs101 which means the descriptors need to be allocated as cacheable. Fix the DT node and update bindings to add the dma-coherent property. This fixes the UFS stability issues we have seen with the upstream UFS driver. Note this DT fix can go in independently of the other UFS fixes series I sent recently [1], as the bootloader already leaves the sharability bits enabled. regards, Peter [1] https://lore.kernel.org/linux-scsi/20250226220414.343659-1-peter.griffin@linaro.org/ To: André Draszik <andre.draszik@linaro.org> To: Tudor Ambarus <tudor.ambarus@linaro.org> To: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzk+dt@kernel.org> To: Conor Dooley <conor+dt@kernel.org> To: Alim Akhtar <alim.akhtar@samsung.com> To: Avri Altman <avri.altman@wdc.com> To: Bart Van Assche <bvanassche@acm.org> To: Martin K. Petersen <martin.petersen@oracle.com> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: kernel-team@android.com Cc: willmcvicker@google.com Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- Peter Griffin (2): arm64: dts: exynos: gs101: ufs: add dma-coherent property scsi: ufs: dt-bindings: exynos: add dma-coherent property for gs101 Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml | 2 ++ arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + 2 files changed, 3 insertions(+) --- base-commit: b323d8e7bc03d27dec646bfdccb7d1a92411f189 change-id: 20250314-ufs-dma-coherent-980f2467690d Best regards,