| Message ID | 20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-0-bd924634b889@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | RFT/RFC: Import IPU6 ov02e10 sensor driver and enable OF usage of it | expand |
Hi Bryan, Alan, On 17-Mar-25 01:39, Bryan O'Donoghue wrote: > Similar to Hans' progressive series on ov02c10 I've picked up via Hans the > IPU6 driver with some additional fixes from Alan Stern. > > https://lore.kernel.org/linux-media/20250313184314.91410-1-hdegoede@redhat.com > > I've made a number of initial changes to this driver sufficient to get it > working on the Dell Inspiron 14 Plus 7441 with the Qualcomm X Elite > x1e80100 SoC and its CAMSS stack. > > link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/x1e80100-6.14-rc6-inspirion14-slim7x-camss?ref_type=heads > > This is a first pass which adds in the minimum to get the sensor going on > the Qualcomm platform. What would be nice would be someone on the IPU6 side > giving it a test. > > A big TBD here is the YAML for this file but, I'd like to make sure nothing > has broken for IPU6/IPU7 with the modifications before diving into > Documentation. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Bryan, thank you for your work on this. Alan, can you give this version of the driver a test run on your laptop? Note you need to skip patch 3/8 for now until I've implemented the solution for handshake handling in the INT3472 driver. Also you need keep the sleep of at least 25 ms after setting the handshake GPIO. Regards, Hans > --- > Bryan O'Donoghue (7): > media: i2c: ov02e10: Fix initial indentation and spacing > media: i2c: ov02e10: Drop IPU6 FPGA specific handshake GPIO > media: i2c: ov02e10: Convert to regulator_bulk API > media: i2c: ov02e10: Rework MCLK clock get logic to facilitate OF > media: i2c: ov02e10: Implement specification t3 and t5 delays on power-up > media: i2c: ov02e10: Remove redundant dev_dbg() and some extra dev_err() > media: i2c: ov02e10: Add OF probe support > > Jingjing Xiong (1): > media: i2c: add OV02E10 image sensor driver > > drivers/media/i2c/Kconfig | 10 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/ov02e10.c | 978 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 989 insertions(+) > --- > base-commit: f2151613e040973c868d28c8b00885dfab69eb75 > change-id: 20250317-b4-media-comitters-next-25-03-13-ov02e10-23e68307d589 > > Best regards,
On Mon, Mar 17, 2025 at 10:02:41AM +0100, Hans de Goede wrote: > Bryan, thank you for your work on this. > > Alan, can you give this version of the driver a test run on your laptop? > > Note you need to skip patch 3/8 for now until I've implemented the > solution for handshake handling in the INT3472 driver. Also you need > keep the sleep of at least 25 ms after setting the handshake GPIO. After installing all the patches except for 3/8 (and adjusting some of the later ones to account for its lack), I can confirm that the camera on my laptop still works. Is there any particular aspect you want me to test or is basic functionality good enough? Alan
On 17/03/2025 17:33, Alan Stern wrote: > After installing all the patches except for 3/8 (and adjusting some of > the later ones to account for its lack), I can confirm that the camera > on my laptop still works. > > Is there any particular aspect you want me to test or is basic > functionality good enough? > > Alan No not really thank you, just a smoke test to make sure nothing broke. --- bod
Similar to Hans' progressive series on ov02c10 I've picked up via Hans the IPU6 driver with some additional fixes from Alan Stern. https://lore.kernel.org/linux-media/20250313184314.91410-1-hdegoede@redhat.com I've made a number of initial changes to this driver sufficient to get it working on the Dell Inspiron 14 Plus 7441 with the Qualcomm X Elite x1e80100 SoC and its CAMSS stack. link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/x1e80100-6.14-rc6-inspirion14-slim7x-camss?ref_type=heads This is a first pass which adds in the minimum to get the sensor going on the Qualcomm platform. What would be nice would be someone on the IPU6 side giving it a test. A big TBD here is the YAML for this file but, I'd like to make sure nothing has broken for IPU6/IPU7 with the modifications before diving into Documentation. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Bryan O'Donoghue (7): media: i2c: ov02e10: Fix initial indentation and spacing media: i2c: ov02e10: Drop IPU6 FPGA specific handshake GPIO media: i2c: ov02e10: Convert to regulator_bulk API media: i2c: ov02e10: Rework MCLK clock get logic to facilitate OF media: i2c: ov02e10: Implement specification t3 and t5 delays on power-up media: i2c: ov02e10: Remove redundant dev_dbg() and some extra dev_err() media: i2c: ov02e10: Add OF probe support Jingjing Xiong (1): media: i2c: add OV02E10 image sensor driver drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov02e10.c | 978 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 989 insertions(+) --- base-commit: f2151613e040973c868d28c8b00885dfab69eb75 change-id: 20250317-b4-media-comitters-next-25-03-13-ov02e10-23e68307d589 Best regards,