| Message ID | 20250318093410.3047828-5-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Convert LAN78xx to PHYLINK | expand |
On 18.03.2025 10:34:04, Oleksij Rempel wrote: > Include error code in the log message when PHY attachment fails, > providing better debugging information. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > changes v3: > - update commit message > --- > drivers/net/usb/lan78xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c > index e54b1ac2c4fc..d2bc6cbdbb66 100644 > --- a/drivers/net/usb/lan78xx.c > +++ b/drivers/net/usb/lan78xx.c > @@ -2693,8 +2693,8 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) > > ret = phylink_connect_phy(dev->phylink, phydev); > if (ret) { > - netdev_err(dev->net, "can't attach PHY to %s\n", > - dev->mdiobus->id); > + netdev_err(dev->net, "can't attach PHY to %s, error %pe\n", > + dev->mdiobus->id, ERR_PTR(ret)); > return -EIO; Probably unrelated to this patch, but what about propagating the error value? Marc > } > > -- > 2.39.5 > > >
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index e54b1ac2c4fc..d2bc6cbdbb66 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2693,8 +2693,8 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) ret = phylink_connect_phy(dev->phylink, phydev); if (ret) { - netdev_err(dev->net, "can't attach PHY to %s\n", - dev->mdiobus->id); + netdev_err(dev->net, "can't attach PHY to %s, error %pe\n", + dev->mdiobus->id, ERR_PTR(ret)); return -EIO; }
Include error code in the log message when PHY attachment fails, providing better debugging information. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- changes v3: - update commit message --- drivers/net/usb/lan78xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)