diff mbox series

[BlueZ,1/5] tools: iso-tester: add inclusion of time.h

Message ID 20250319103724.10433-1-ceggers@arri.de (mailing list archive)
State Accepted
Commit d26a7f96cdd4250f4de3792fd647c3b92581712e
Headers show
Series [BlueZ,1/5] tools: iso-tester: add inclusion of time.h | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch warning CheckSparse WARNING mesh/mesh-io-mgmt.c:524:67: warning: Variable length array is used.src/shared/bap.c:313:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:313:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:313:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild warning ScanBuild: 1 warning generated. tools/gatt-service.c:294:2: warning: 2nd function call argument is an uninitialized value tools/btgatt-server.c:1212:2: warning: Value stored to 'argv' is never read chr_write(chr, value, len); argv -= optind; ^~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~ 1 warning generated.

Commit Message

Christian Eggers March 19, 2025, 10:37 a.m. UTC 
Inclusion of <linux/errqueue.h> requires that 'struct timespec' has
already been defined:

| In file included from ../bluez-5.79/tools/iso-tester.c:21:
| /usr/include/linux/errqueue.h:57:25: error: array type has incomplete element type 'struct timespec'
|    57 |         struct timespec ts[3];
|       |                         ^~
---
 tools/iso-tester.c | 1 +
 1 file changed, 1 insertion(+)

Comments

bluez.test.bot@gmail.com March 19, 2025, 11:36 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=945530

---Test result---

Test Summary:
CheckPatch                    PENDING   0.23 seconds
GitLint                       PENDING   0.26 seconds
BuildEll                      PASS      20.50 seconds
BluezMake                     PASS      1506.66 seconds
MakeCheck                     PASS      12.74 seconds
MakeDistcheck                 PASS      157.32 seconds
CheckValgrind                 PASS      212.85 seconds
CheckSmatch                   WARNING   282.90 seconds
bluezmakeextell               PASS      97.90 seconds
IncrementalBuild              PENDING   0.31 seconds
ScanBuild                     WARNING   866.83 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
mesh/mesh-io-mgmt.c:524:67: warning: Variable length array is used.src/shared/bap.c:313:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:313:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:313:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:

##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
1 warning generated.
tools/gatt-service.c:294:2: warning: 2nd function call argument is an uninitialized value
tools/btgatt-server.c:1212:2: warning: Value stored to 'argv' is never read
        chr_write(chr, value, len);
        argv -= optind;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
        ^       ~~~~~~
1 warning generated.



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org March 19, 2025, 7:10 p.m. UTC | #2 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 19 Mar 2025 11:37:20 +0100 you wrote:
> Inclusion of <linux/errqueue.h> requires that 'struct timespec' has
> already been defined:
> 
> | In file included from ../bluez-5.79/tools/iso-tester.c:21:
> | /usr/include/linux/errqueue.h:57:25: error: array type has incomplete element type 'struct timespec'
> |    57 |         struct timespec ts[3];
> |       |                         ^~
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/5] tools: iso-tester: add inclusion of time.h
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d26a7f96cdd4
  - [BlueZ,2/5] mesh: include <time.h> before <ell/ell.h>
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f26f2f8de7f
  - [BlueZ,3/5] tools/btpclient: include <time.h> before <ell/ell.h>
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ba9f9fbde34a
  - [BlueZ,4/5] client/player: fix printf format mismatch
    (no matching commit)
  - [BlueZ,5/5] shared/bap: fix printf format mismatch
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=50a01b0c17e9

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index 640692b779c9..350775fddc96 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -17,6 +17,7 @@ 
 #include <errno.h>
 #include <poll.h>
 #include <stdbool.h>
+#include <time.h>
 
 #include <linux/errqueue.h>
 #include <linux/net_tstamp.h>