| Message ID | 20250324085506.55916-3-ravi@prevas.dk (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: mscc,vsc7514-switch: allow specifying 'phys' for switch ports | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Mon, Mar 24, 2025 at 09:55:06AM +0100, Rasmus Villemoes wrote: > Ports that use SGMII / QSGMII to interface to external phys (or as > fixed-link to a cpu mac) need to configure the internal SerDes > interface appropriately. Allow an optional 'phys' property to describe > those relationships. > > Signed-off-by: Rasmus Villemoes <ravi@prevas.dk> > --- Oops... I had thought 'phys' and 'phy-names' would be part of Documentation/devicetree/bindings/net/ethernet-controller.yaml... By the way, should you also accept 'phy-names' in the binding?
On Mon, 24 Mar 2025 09:55:06 +0100, Rasmus Villemoes wrote: > Ports that use SGMII / QSGMII to interface to external phys (or as > fixed-link to a cpu mac) need to configure the internal SerDes > interface appropriately. Allow an optional 'phys' property to describe > those relationships. > > Signed-off-by: Rasmus Villemoes <ravi@prevas.dk> > --- > .../devicetree/bindings/net/mscc,vsc7514-switch.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml:40:1: [error] syntax error: found character '\t' that cannot start any token (syntax) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml: ignoring, error parsing file ./Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml:40:1: found a tab character that violates indentation /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/mscc,ocelot.yaml: while scanning a plain scalar in "<unicode string>", line 39, column 21 found a tab character that violates indentation in "<unicode string>", line 40, column 1 make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/mscc,vsc7514-switch.example.dts' Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml:40:1: found a tab character that violates indentation make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/mscc,vsc7514-switch.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1522: dt_binding_check] Error 2 make: *** [Makefile:248: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250324085506.55916-3-ravi@prevas.dk The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Mar 24, 2025 at 12:00:55PM +0200, Vladimir Oltean wrote: > On Mon, Mar 24, 2025 at 09:55:06AM +0100, Rasmus Villemoes wrote: > > Ports that use SGMII / QSGMII to interface to external phys (or as > > fixed-link to a cpu mac) need to configure the internal SerDes > > interface appropriately. Allow an optional 'phys' property to describe > > those relationships. > > > > Signed-off-by: Rasmus Villemoes <ravi@prevas.dk> > > --- > > Oops... I had thought 'phys' and 'phy-names' would be part of > Documentation/devicetree/bindings/net/ethernet-controller.yaml... > > By the way, should you also accept 'phy-names' in the binding? No. There's only 1 phy, so not needed.
diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml index 07de52a3a2951..ea741be8edd74 100644 --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml @@ -37,6 +37,10 @@ allOf: patternProperties: "^port@[0-9a-f]+$": $ref: ethernet-switch-port.yaml# + phys: + maxitems: 1 + description: + Reference to SerDes lane. unevaluatedProperties: false - if: @@ -54,6 +58,10 @@ allOf: patternProperties: "^port@[0-9a-f]+$": $ref: /schemas/net/dsa/dsa-port.yaml# + phys: + maxitems: 1 + description: + Reference to SerDes lane. unevaluatedProperties: false properties:
Ports that use SGMII / QSGMII to interface to external phys (or as fixed-link to a cpu mac) need to configure the internal SerDes interface appropriately. Allow an optional 'phys' property to describe those relationships. Signed-off-by: Rasmus Villemoes <ravi@prevas.dk> --- .../devicetree/bindings/net/mscc,vsc7514-switch.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)