| Message ID | 20250324090813.2775011-5-pop.ioan-daniel@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for AD7405/ADUM770x | expand |
On 3/24/25 4:07 AM, Pop Ioan Daniel wrote: > Add devicetree bindings for ad7405/adum770x family. > > Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com> > --- > .../bindings/iio/adc/adi,ad7405.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > new file mode 100644 > index 000000000000..e312fa0cdb05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2025 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7405.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD7405 family > + > +maintainers: > + - Dragos Bogdan <dragos.bogdan@analog.com> > + > +description: | > + Analog Devices AD7405 is a high performance isolated ADC, 1-channel, > + 16-bit with a second-order Σ-Δ modulator that converts an analog input signal > + into a high speed, single-bit data stream. > + > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7405.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/adum7701.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/adum7702.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/ADuM7703.pdf > + > +properties: > + compatible: > + enum: > + - adi,ad7405 > + - adi,adum7701 > + - adi,adum7702 > + - adi,adum7703 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + There are no child nodes, so we don't need #address-cells or #size-cells. > + vdd1-supply: true > + > + vdd2-supply: true > + > + clocks: > + maxitems: 1 > + > + io-backends: > + maxItems: 1 > + > +required: > + - compatible > + - vdd1-supply > + - vdd2-supply > + - clocks > + - io-backends > + > +unevaluatedProperties: false Should be able to use additionalProperties: false here instead. > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> This include isn't used and can be removed. > + adc { > + #address-cells = <1>; > + #size-cells = <0>; Not needed as above. > + compatible = "adi,ad7405"; > + clocks = <&axi_clk_gen 0>; > + vdd1-supply = <&vdd1>; > + vdd2-supply = <&vdd2>; > + io-backends = <&iio_backend>; > + }; > +... > \ No newline at end of file
On Mon, Mar 24, 2025 at 11:07:59AM +0200, Pop Ioan Daniel wrote: > Add devicetree bindings for ad7405/adum770x family. > > Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com> > --- > .../bindings/iio/adc/adi,ad7405.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > new file mode 100644 > index 000000000000..e312fa0cdb05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2025 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7405.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD7405 family > + > +maintainers: > + - Dragos Bogdan <dragos.bogdan@analog.com> > + > +description: | > + Analog Devices AD7405 is a high performance isolated ADC, 1-channel, > + 16-bit with a second-order Σ-Δ modulator that converts an analog input signal > + into a high speed, single-bit data stream. > + > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7405.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/adum7701.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/adum7702.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/ADuM7703.pdf > + > +properties: > + compatible: > + enum: > + - adi,ad7405 > + - adi,adum7701 > + - adi,adum7702 > + - adi,adum7703 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + vdd1-supply: true > + > + vdd2-supply: true > + > + clocks: > + maxitems: 1 > + > + io-backends: > + maxItems: 1 > + > +required: > + - compatible > + - vdd1-supply > + - vdd2-supply > + - clocks > + - io-backends > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + adc { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "adi,ad7405"; > + clocks = <&axi_clk_gen 0>; > + vdd1-supply = <&vdd1>; > + vdd2-supply = <&vdd2>; > + io-backends = <&iio_backend>; > + }; > +... > \ No newline at end of file Fix this. With that, Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On Mon, 24 Mar 2025 11:07:59 +0200 Pop Ioan Daniel <pop.ioan-daniel@analog.com> wrote: > Add devicetree bindings for ad7405/adum770x family. > > Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com> Hi Pop, One more trivial thing inline. > --- > .../bindings/iio/adc/adi,ad7405.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > new file mode 100644 > index 000000000000..e312fa0cdb05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2025 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7405.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + adc { > + #address-cells = <1>; Odd alignment going on here. 1 more space I think. > + #size-cells = <0>; > + compatible = "adi,ad7405"; > + clocks = <&axi_clk_gen 0>; > + vdd1-supply = <&vdd1>; > + vdd2-supply = <&vdd2>; > + io-backends = <&iio_backend>; > + }; > +... > \ No newline at end of file
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml new file mode 100644 index 000000000000..e312fa0cdb05 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright 2025 Analog Devices Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/adi,ad7405.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD7405 family + +maintainers: + - Dragos Bogdan <dragos.bogdan@analog.com> + +description: | + Analog Devices AD7405 is a high performance isolated ADC, 1-channel, + 16-bit with a second-order Σ-Δ modulator that converts an analog input signal + into a high speed, single-bit data stream. + + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7405.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/adum7701.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/adum7702.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ADuM7703.pdf + +properties: + compatible: + enum: + - adi,ad7405 + - adi,adum7701 + - adi,adum7702 + - adi,adum7703 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + vdd1-supply: true + + vdd2-supply: true + + clocks: + maxitems: 1 + + io-backends: + maxItems: 1 + +required: + - compatible + - vdd1-supply + - vdd2-supply + - clocks + - io-backends + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + adc { + #address-cells = <1>; + #size-cells = <0>; + compatible = "adi,ad7405"; + clocks = <&axi_clk_gen 0>; + vdd1-supply = <&vdd1>; + vdd2-supply = <&vdd2>; + io-backends = <&iio_backend>; + }; +... \ No newline at end of file
Add devicetree bindings for ad7405/adum770x family. Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com> --- .../bindings/iio/adc/adi,ad7405.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7405.yaml