[0/2] revert "setsid" and "privatens" test ways from check

Message

Zorro Lang March 20, 2025, 7:28 p.m. UTC

To isolate check-parallel from traditional check, let's revert "setsid" and
"privatens" test ways from check at first, due to "check" doesn't need them.
This also helps to avoid some regression issues or behavior changes.

The run_setsid and related things are removed totally, the privatens is removed
from check too, but the run_privatens script is retained for check-parallel.
Later, check-parallel will run in private name space way, won't affect the
check running.

More details refer to two patches. And please feel free to tell me if I miss
something.

Thanks,
Zorro

Comments

Christoph Hellwig March 21, 2025, 7:26 a.m. UTC | #1

I can't really review this code as I don't understand it, but keeping
the special logic for the parallel run out of the main check script that
everyone uses sounds like a good idea.

Btw, any chance we could rename check-parallel to parallel-check or
similar?  The current name really messes up tab completion and mussle
memory for interactive xfstests run.

Dave Chinner March 24, 2025, 9:44 p.m. UTC | #2

On Fri, Mar 21, 2025 at 03:28:10AM +0800, Zorro Lang wrote:
> To isolate check-parallel from traditional check, let's revert "setsid" and
> "privatens" test ways from check at first, due to "check" doesn't need them.
> This also helps to avoid some regression issues or behavior changes.
> 
> The run_setsid and related things are removed totally, the privatens is removed
> from check too, but the run_privatens script is retained for check-parallel.
> Later, check-parallel will run in private name space way, won't affect the
> check running.
> 
> More details refer to two patches. And please feel free to tell me if I miss
> something.

Looks fine to me.

Reviewed-by: Dave Chinner <[e-mail]>