| Message ID | 20250323190450.111241-1-johan.korsnes@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5e8df79497ce522170b5964d92c7f7df28dc1fa7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: au1000_eth: Mark au1000_ReleaseDB() static | expand |
On Sun, Mar 23, 2025 at 08:04:50PM +0100, Johan Korsnes wrote: > This fixes the following build warning: > ``` > drivers/net/ethernet/amd/au1000_eth.c:574:6: warning: no previous prototype for 'au1000_ReleaseDB' [-Wmissing-prototypes] > 574 | void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) > | ^~~~~~~~~~~~~~~~ > ``` > > Signed-off-by: Johan Korsnes <johan.korsnes@gmail.com> > Cc: Andrew Lunn <andrew+netdev@lunn.ch> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > --- > drivers/net/ethernet/amd/au1000_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c > index 0671a066913b..9d35ac348ebe 100644 > --- a/drivers/net/ethernet/amd/au1000_eth.c > +++ b/drivers/net/ethernet/amd/au1000_eth.c > @@ -571,7 +571,7 @@ static struct db_dest *au1000_GetFreeDB(struct au1000_private *aup) > return pDB; > } > > -void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) > +static void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) > { > struct db_dest *pDBfree = aup->pDBfree; > if (pDBfree) Thanks for fixing it Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> You didn't specify the tree (net vs net-next in [PATCH ...]). If you want it to go to net you will need fixes tag, if to net-next it is fine. > -- > 2.49.0
On 24/03/2025 07:01, Michal Swiatkowski wrote: > On Sun, Mar 23, 2025 at 08:04:50PM +0100, Johan Korsnes wrote: >> This fixes the following build warning: >> ``` >> drivers/net/ethernet/amd/au1000_eth.c:574:6: warning: no previous prototype for 'au1000_ReleaseDB' [-Wmissing-prototypes] >> 574 | void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) >> | ^~~~~~~~~~~~~~~~ >> ``` >> >> Signed-off-by: Johan Korsnes <johan.korsnes@gmail.com> >> Cc: Andrew Lunn <andrew+netdev@lunn.ch> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: Eric Dumazet <edumazet@google.com> >> Cc: Jakub Kicinski <kuba@kernel.org> >> Cc: Paolo Abeni <pabeni@redhat.com> >> --- >> drivers/net/ethernet/amd/au1000_eth.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c >> index 0671a066913b..9d35ac348ebe 100644 >> --- a/drivers/net/ethernet/amd/au1000_eth.c >> +++ b/drivers/net/ethernet/amd/au1000_eth.c >> @@ -571,7 +571,7 @@ static struct db_dest *au1000_GetFreeDB(struct au1000_private *aup) >> return pDB; >> } >> >> -void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) >> +static void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) >> { >> struct db_dest *pDBfree = aup->pDBfree; >> if (pDBfree) > > Thanks for fixing it > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > > You didn't specify the tree (net vs net-next in [PATCH ...]). If you > want it to go to net you will need fixes tag, if to net-next it is fine. Thank you for the review. I don't mind adding fixes tags and re-submit, but would that be preferred in this case? Or will it just be noise for the maintainers? Kind regards, Johan > >> -- >> 2.49.0
On Mon, 24 Mar 2025 09:21:29 +0100 Johan Korsnes wrote: > > Thanks for fixing it > > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > > > > You didn't specify the tree (net vs net-next in [PATCH ...]). If you > > want it to go to net you will need fixes tag, if to net-next it is fine. > > Thank you for the review. I don't mind adding fixes tags and re-submit, > but would that be preferred in this case? Or will it just be noise for > the maintainers? Just noise. Michal, when PW bot guesses the tree correctly there is no need to flag the problem to the contributor. The tree designation makes our life easier but not enough to deal with reposts.
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sun, 23 Mar 2025 20:04:50 +0100 you wrote: > This fixes the following build warning: > ``` > drivers/net/ethernet/amd/au1000_eth.c:574:6: warning: no previous prototype for 'au1000_ReleaseDB' [-Wmissing-prototypes] > 574 | void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) > | ^~~~~~~~~~~~~~~~ > ``` > > [...] Here is the summary with links: - net: au1000_eth: Mark au1000_ReleaseDB() static https://git.kernel.org/netdev/net-next/c/5e8df79497ce You are awesome, thank you!
diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c index 0671a066913b..9d35ac348ebe 100644 --- a/drivers/net/ethernet/amd/au1000_eth.c +++ b/drivers/net/ethernet/amd/au1000_eth.c @@ -571,7 +571,7 @@ static struct db_dest *au1000_GetFreeDB(struct au1000_private *aup) return pDB; } -void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) +static void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) { struct db_dest *pDBfree = aup->pDBfree; if (pDBfree)
This fixes the following build warning: ``` drivers/net/ethernet/amd/au1000_eth.c:574:6: warning: no previous prototype for 'au1000_ReleaseDB' [-Wmissing-prototypes] 574 | void au1000_ReleaseDB(struct au1000_private *aup, struct db_dest *pDB) | ^~~~~~~~~~~~~~~~ ``` Signed-off-by: Johan Korsnes <johan.korsnes@gmail.com> Cc: Andrew Lunn <andrew+netdev@lunn.ch> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> --- drivers/net/ethernet/amd/au1000_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)