| Message ID | 20250325084639.801054-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ALSA: hda: cs35l56: Remove unnecessary NULL check before release_firmware() | expand |
On Tue, 25 Mar 2025 09:46:39 +0100, Chen Ni wrote: > > release_firmware() checks for NULL pointers internally. > Remove unneeded NULL check for fmw here. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Thanks, applied now. Takashi
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 4ef7878e8fd4..235d22049aa9 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -546,12 +546,10 @@ static void cs35l56_hda_release_firmware_files(const struct firmware *wmfw_firmw const struct firmware *coeff_firmware, char *coeff_filename) { - if (wmfw_firmware) - release_firmware(wmfw_firmware); + release_firmware(wmfw_firmware); kfree(wmfw_filename); - if (coeff_firmware) - release_firmware(coeff_firmware); + release_firmware(coeff_firmware); kfree(coeff_filename); }
release_firmware() checks for NULL pointers internally. Remove unneeded NULL check for fmw here. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- sound/pci/hda/cs35l56_hda.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)