[v3,0/2] selftests: livepatch: test if ftrace can trace a livepatched function

Message

Filipe Xavier March 24, 2025, 10:50 p.m. UTC

This patchset add ftrace helpers functions and
add a new test makes sure that ftrace can trace
a function that was introduced by a livepatch.

Signed-off-by: Filipe Xavier <[e-mail]>
Suggested-by: Marcos Paulo de Souza <[e-mail]>
Reviewed-by: Marcos Paulo de Souza <[e-mail]>
Acked-by: Miroslav Benes <[e-mail]>
---
Changes in v3:
- functions.sh: fixed sed to remove warning from shellcheck and add grep -Fw params.
- test-ftrace.sh: change constant to use common SYSFS_KLP_DIR.
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- functions.sh: change check traced function to accept a list of functions.
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Filipe Xavier (2):
      selftests: livepatch: add new ftrace helpers functions
      selftests: livepatch: test if ftrace can trace a livepatched function

 tools/testing/selftests/livepatch/functions.sh   | 49 ++++++++++++++++++++++++
 tools/testing/selftests/livepatch/test-ftrace.sh | 34 ++++++++++++++++
 2 files changed, 83 insertions(+)
---
base-commit: 848e076317446f9c663771ddec142d7c2eb4cb43
change-id: 20250306-ftrace-sftest-livepatch-60d9dc472235

Best regards,

Comments

Joe Lawrence March 25, 2025, 1:29 p.m. UTC | #1

On Mon, Mar 24, 2025 at 07:50:17PM -0300, Filipe Xavier wrote:
> This patchset add ftrace helpers functions and
> add a new test makes sure that ftrace can trace
> a function that was introduced by a livepatch.
> 
> Signed-off-by: Filipe Xavier <[e-mail]>
> Suggested-by: Marcos Paulo de Souza <[e-mail]>
> Reviewed-by: Marcos Paulo de Souza <[e-mail]>
> Acked-by: Miroslav Benes <[e-mail]>
> ---
> Changes in v3:
> - functions.sh: fixed sed to remove warning from shellcheck and add grep -Fw params.

Oh, now I see what shellcheck was complaining about.  I missed that
there was no '\' line continuation char at the end of the sed line.  I
thought it was complaining about starting the subsequent lines with the
'|' and '>' redirection chars.  Good eye on catching that :)

> - test-ftrace.sh: change constant to use common SYSFS_KLP_DIR.
> - Link to v2: https://lore.kernel.org/r/[e-mail]
> 

For both patches:
Acked-by: Joe Lawrence <[e-mail]>

Thanks,
-- Joe

Petr Mladek March 25, 2025, 1:56 p.m. UTC | #2

On Mon 2025-03-24 19:50:17, Filipe Xavier wrote:
> This patchset add ftrace helpers functions and
> add a new test makes sure that ftrace can trace
> a function that was introduced by a livepatch.
> 
> Signed-off-by: Filipe Xavier <[e-mail]>
> Acked-by: Miroslav Benes <[e-mail]>

For both patches:

Reviewed-by: Petr Mladek <[e-mail]>
Tested-by: Petr Mladek <[e-mail]>

Best Regards,
Petr

Petr Mladek March 25, 2025, 2:01 p.m. UTC | #3

On Mon 2025-03-24 19:50:17, Filipe Xavier wrote:
> This patchset add ftrace helpers functions and
> add a new test makes sure that ftrace can trace
> a function that was introduced by a livepatch.
> 
> Signed-off-by: Filipe Xavier <[e-mail]>
> Acked-by: Miroslav Benes <[e-mail]>

JFYI, the patchset has been committed into livepatching.git,
branch for-6.15/ftrace-test.

I had a dilemma whether to push it for 6.15 or postpone it.
But it is a selftest and quite trivial. And it has been
reviewed by several people. And it seems to work well
so I think that we could push it for 6.15.

Best Regards,
Petr

Filipe Xavier March 25, 2025, 2:46 p.m. UTC | #4

On 3/25/25 11:01 AM, Petr Mladek wrote:

> On Mon 2025-03-24 19:50:17, Filipe Xavier wrote:
>> This patchset add ftrace helpers functions and
>> add a new test makes sure that ftrace can trace
>> a function that was introduced by a livepatch.
>>
>> Signed-off-by: Filipe Xavier <[e-mail]>
>> Acked-by: Miroslav Benes <[e-mail]>
> JFYI, the patchset has been committed into livepatching.git,
> branch for-6.15/ftrace-test.
>
> I had a dilemma whether to push it for 6.15 or postpone it.
> But it is a selftest and quite trivial. And it has been
> reviewed by several people. And it seems to work well
> so I think that we could push it for 6.15.

It sounds good to me, thank you all very much for the support.

Cheers,

Filipe

> Best Regards,
> Petr