| Message ID | 20250324104012.367366-4-maxime.chevallier@bootlin.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ethtool: Introduce ethnl dump helpers | expand |
On Mon, 24 Mar 2025 11:40:05 +0100 Maxime Chevallier <maxime.chevallier@bootlin.com> wrote: > As we work on getting more objects out of a per-netdev DUMP, rename > ethnl_default_dump_one() into ethnl_default_dump_one_dev(), making it > explicit that this dumps everything for one netdev. Reviewed-by: Kory Maincent <kory.maincent@bootlin.com> Thank you!
On Mon, 24 Mar 2025 11:40:05 +0100 Maxime Chevallier wrote: > As we work on getting more objects out of a per-netdev DUMP, rename > ethnl_default_dump_one() into ethnl_default_dump_one_dev(), making it > explicit that this dumps everything for one netdev. Maybe ethnl_default_dump_dev() ?
On Tue, 25 Mar 2025 14:16:05 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Mon, 24 Mar 2025 11:40:05 +0100 Maxime Chevallier wrote: > > As we work on getting more objects out of a per-netdev DUMP, rename > > ethnl_default_dump_one() into ethnl_default_dump_one_dev(), making it > > explicit that this dumps everything for one netdev. > > Maybe ethnl_default_dump_dev() ? Sure, that's better indeed :) Maxime
diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c index 31ab89ca0bcc..63ede3638708 100644 --- a/net/ethtool/netlink.c +++ b/net/ethtool/netlink.c @@ -540,9 +540,9 @@ static int ethnl_default_doit(struct sk_buff *skb, struct genl_info *info) return ret; } -static int ethnl_default_dump_one(struct sk_buff *skb, struct net_device *dev, - const struct ethnl_dump_ctx *ctx, - const struct genl_info *info) +static int ethnl_default_dump_one_dev(struct sk_buff *skb, struct net_device *dev, + const struct ethnl_dump_ctx *ctx, + const struct genl_info *info) { void *ehdr; int ret; @@ -590,7 +590,8 @@ static int ethnl_dump_all(struct sk_buff *skb, struct netlink_callback *cb) rcu_read_unlock(); ctx->req_info->dev = dev; - ret = ethnl_default_dump_one(skb, dev, ctx, genl_info_dump(cb)); + ret = ethnl_default_dump_one_dev(skb, dev, ctx, + genl_info_dump(cb)); rcu_read_lock(); dev_put(dev); @@ -618,8 +619,8 @@ static int ethnl_default_dumpit(struct sk_buff *skb, /* Filtered DUMP request targeted to a single netdev. We already * hold a ref to the netdev from ->start() */ - ret = ethnl_default_dump_one(skb, ctx->req_info->dev, ctx, - genl_info_dump(cb)); + ret = ethnl_default_dump_one_dev(skb, ctx->req_info->dev, ctx, + genl_info_dump(cb)); netdev_put(ctx->req_info->dev, &ctx->req_info->dev_tracker); if (ret < 0 && ret != -EOPNOTSUPP && likely(skb->len))
As we work on getting more objects out of a per-netdev DUMP, rename ethnl_default_dump_one() into ethnl_default_dump_one_dev(), making it explicit that this dumps everything for one netdev. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- V4 : No changes net/ethtool/netlink.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)