mbox series

[iwl-next,0/2] idpf: add flow steering support

Message ID 20250324134939.253647-1-ahmed.zaki@intel.com (mailing list archive)
Headers show
Series idpf: add flow steering support | expand

Message

Ahmed Zaki March 24, 2025, 1:49 p.m. UTC 
Add basic flow steering. For now, we support IPv4 and TCP/UDP only.

Ahmed Zaki (1):
  idpf: add flow steering support

Sudheer Mogilappagari (1):
  virtchnl2: add flow steering support

 drivers/net/ethernet/intel/idpf/idpf.h        |  14 +
 .../net/ethernet/intel/idpf/idpf_ethtool.c    | 297 +++++++++++++++++-
 drivers/net/ethernet/intel/idpf/idpf_lib.c    |   6 +
 .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 104 ++++++
 .../net/ethernet/intel/idpf/idpf_virtchnl.h   |   6 +
 drivers/net/ethernet/intel/idpf/virtchnl2.h   | 233 +++++++++++++-
 6 files changed, 650 insertions(+), 10 deletions(-)

Comments

Alexander Lobakin March 26, 2025, 5:14 p.m. UTC | #1 
From: Ahmed Zaki <ahmed.zaki@intel.com>
Date: Mon, 24 Mar 2025 07:49:36 -0600

> Add basic flow steering. For now, we support IPv4 and TCP/UDP only.

1. Very poor cover letter. I'd suggest describing a bit more here.
2. net-next is closed, so this is RFC at max.
3. I haven't seen this reviewed properly on our internal ML.

> 
> Ahmed Zaki (1):
>   idpf: add flow steering support
> 
> Sudheer Mogilappagari (1):
>   virtchnl2: add flow steering support
> 
>  drivers/net/ethernet/intel/idpf/idpf.h        |  14 +
>  .../net/ethernet/intel/idpf/idpf_ethtool.c    | 297 +++++++++++++++++-
>  drivers/net/ethernet/intel/idpf/idpf_lib.c    |   6 +
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 104 ++++++
>  .../net/ethernet/intel/idpf/idpf_virtchnl.h   |   6 +
>  drivers/net/ethernet/intel/idpf/virtchnl2.h   | 233 +++++++++++++-
>  6 files changed, 650 insertions(+), 10 deletions(-)

Thanks,
Olek
Ahmed Zaki March 26, 2025, 5:36 p.m. UTC | #2 
On 2025-03-26 11:14 a.m., Alexander Lobakin wrote:
> From: Ahmed Zaki <ahmed.zaki@intel.com>
> Date: Mon, 24 Mar 2025 07:49:36 -0600
> 
>> Add basic flow steering. For now, we support IPv4 and TCP/UDP only.
> 
> 1. Very poor cover letter. I'd suggest describing a bit more here.

I'd call it concise.  Let me know what is missing or needs clarification 
  and I will add.

> 2. net-next is closed, so this is RFC at max.

It was sent before net-next was closed.