| Message ID | 20250326055053.3313146-9-Penny.Zheng@amd.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xen: introduce CONFIG_SYSCTL | expand |
On Wed, 26 Mar 2025, Penny Zheng wrote: > The following function is only to serve spinlock profiling via > XEN_SYSCTL_lockprof_op, so it shall be wrapped: > - spinlock_profile_control > > Signed-off-by: Penny Zheng <Penny.Zheng@amd.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
On 26.03.2025 06:50, Penny Zheng wrote: > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -123,13 +123,13 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) > ret = perfc_control(&op->u.perfc_op); > break; > #endif > -#endif /* CONFIG_SYSCTL */ > > #ifdef CONFIG_DEBUG_LOCK_PROFILE > case XEN_SYSCTL_lockprof_op: > ret = spinlock_profile_control(&op->u.lockprof_op); > break; > #endif > +#endif /* CONFIG_SYSCTL */ > case XEN_SYSCTL_debug_keys: In such a situation please take the opportunity and add the blank line that was missing ahead of the subsequent case label. Jan
diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c index 38caa10a2e..0389293b09 100644 --- a/xen/common/spinlock.c +++ b/xen/common/spinlock.c @@ -690,6 +690,7 @@ void cf_check spinlock_profile_reset(unsigned char key) spinlock_profile_iterate(spinlock_profile_reset_elem, NULL); } +#ifdef CONFIG_SYSCTL typedef struct { struct xen_sysctl_lockprof_op *pc; int rc; @@ -749,6 +750,7 @@ int spinlock_profile_control(struct xen_sysctl_lockprof_op *pc) return rc; } +#endif /* CONFIG_SYSCTL */ void _lock_profile_register_struct( int32_t type, struct lock_profile_qhead *qhead, int32_t idx) diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index 0da82d6e31..4602d84203 100644 --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -123,13 +123,13 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) ret = perfc_control(&op->u.perfc_op); break; #endif -#endif /* CONFIG_SYSCTL */ #ifdef CONFIG_DEBUG_LOCK_PROFILE case XEN_SYSCTL_lockprof_op: ret = spinlock_profile_control(&op->u.lockprof_op); break; #endif +#endif /* CONFIG_SYSCTL */ case XEN_SYSCTL_debug_keys: { char c;
The following function is only to serve spinlock profiling via XEN_SYSCTL_lockprof_op, so it shall be wrapped: - spinlock_profile_control Signed-off-by: Penny Zheng <Penny.Zheng@amd.com> --- v1 -> v2: - add transient #ifdef in sysctl.c for correct compilation --- xen/common/spinlock.c | 2 ++ xen/common/sysctl.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)