| Message ID | 20250327181750.3733881-2-quic_srichara@quicinc.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | mailbox: tmel-qmp: Introduce QCOM TMEL QMP mailbox driver | expand |
On Thu, Mar 27, 2025 at 11:47:49PM +0530, Sricharan R wrote: > +properties: > + compatible: > + items: > + - enum: > + - qcom,ipq5424-tmel blank line > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + mboxes: > + maxItems: 1 Why mbox is having an mbox? This does not look right and suggest the block is misrepresented. I read the diagram and description two times and still do not see how this fits there. > + > + "#mbox-cells": > + const: 1 Best regards, Krzysztof
On Thu, Mar 27, 2025 at 11:47:49PM +0530, Sricharan R wrote: > From: Sricharan Ramabadhran <quic_srichara@quicinc.com> > > TMEL(Trust Management Engine Lite) subsystem provides different kinds of Trust whatever SubSystem (TMEL SS) ... different to what? > services like secureboot, remote image authentication, key management, > crypto, OEM provisioning etc. > > The QMP mailbox is the primary means of communication between TMEL SS and What is QMP? > other subsystem on the SoC. A dedicated pair of inbound and outbound > mailboxes is implemented for each subsystem/external execution environment Is it implemented in the driver? Is it provided by the hardware? By the firmware? > which needs to communicate with TMEL for security services. The inbound > mailboxes are used to send IPC requests to TMEL, which are then processed > by TMEL firmware and accordingly the responses are sent back via outbound > mailboxes.
On 3/28/2025 1:32 PM, Krzysztof Kozlowski wrote: > On Thu, Mar 27, 2025 at 11:47:49PM +0530, Sricharan R wrote: >> +properties: >> + compatible: >> + items: >> + - enum: >> + - qcom,ipq5424-tmel > > blank line ok > >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + mboxes: >> + maxItems: 1 > > Why mbox is having an mbox? This does not look right and suggest the > block is misrepresented. I read the diagram and description two times > and still do not see how this fits there. TMEL/QMP secure functionalities are exposed to clients (like rproc) by registering TMEL as mailbox controller. The IPC bit to communicate with the TMEL/QMP controller itself is handled by the apcs mailbox. Hence it looks like a mbox inside mbox. Alternatively, would it be fine to fold the IPC bit handling in this driver itself for doing the regmap_write (instead of connecting to apcs mailbox separately) ? Also, there are couple of other ways of designing this as well. Earlier i mentioned this in the RFC post [1] for getting the design sorted out. [1] https://lore.kernel.org/lkml/20241205080633.2623142-1-quic_srichara@quicinc.com/T/ ------------------------------------------------------------- Had the below mentioned in the RFC earlier. The intention of posting this is to get the design reviewed/corrected since there are also other possible ways of having this SS support like: a) Make TMEL QMP as a 'rpmsg' driver and clients can connect using rmpsg_send b) Keep TMEL APIs seperately in drivers/firmware which would export APIs and QMP mailbox seperately. Clients can then call the exported APIS. c) Combine both TMEL and QMP as mailbox (this is the approach used here) Regards, Sricharan
On 3/28/2025 6:21 PM, Dmitry Baryshkov wrote: > On Thu, Mar 27, 2025 at 11:47:49PM +0530, Sricharan R wrote: >> From: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> >> TMEL(Trust Management Engine Lite) subsystem provides different kinds of > > Trust whatever SubSystem (TMEL SS) ... > > different to what? > To the ARM TrustZone firmware(TZ). So these services (secureboot, image authentication etc) were provided by the TZ in some SOCs. Here, TMEL provides those. Can add those details here. >> services like secureboot, remote image authentication, key management, >> crypto, OEM provisioning etc. >> >> The QMP mailbox is the primary means of communication between TMEL SS and > > What is QMP? Qualcomm Messaging Protocol > >> other subsystem on the SoC. A dedicated pair of inbound and outbound >> mailboxes is implemented for each subsystem/external execution environment > > Is it implemented in the driver? Is it provided by the hardware? By the > firmware? > TMEL firmware provides and processes the inbound requests and responds back on the outbound channel. Can mention this explicitly in the above. Regards, Sricharan
[Resending, since my previous response had some wrapping issue] >> TMEL(Trust Management Engine Lite) subsystem provides different kinds of > > Trust whatever SubSystem (TMEL SS) ... > > different to what? To the ARM TrustZone firmware(TZ). So these services (secureboot, authentication etc) were provided by the TZ in some SOCs. Here, TMEL provides those. Can add those details here. > >> services like secureboot, remote image authentication, key management, >> crypto, OEM provisioning etc. >> >> The QMP mailbox is the primary means of communication between TMEL SS and > > What is QMP? Qualcomm Messaging Protocol > >> other subsystem on the SoC. A dedicated pair of inbound and outbound >> mailboxes is implemented for each subsystem/external execution environment > > Is it implemented in the driver? Is it provided by the hardware? By the > firmware? > TMEL firmware provides and processes the inbound requests and responds back on the outbound channel. Can mention this explicitly in the above. Regards, Sricharan
On 01/04/2025 14:26, Sricharan Ramabadhran wrote: > > [Resending, since my previous response had some wrapping issue] > >>> TMEL(Trust Management Engine Lite) subsystem provides different kinds of >> >> Trust whatever SubSystem (TMEL SS) ... >> >> different to what? > > > To the ARM TrustZone firmware(TZ). So these services (secureboot, > authentication etc) were provided by the TZ in some SOCs. Here, > TMEL provides those. Can add those details here. Yes, please (and all other answers too). > >> >>> services like secureboot, remote image authentication, key management, >>> crypto, OEM provisioning etc. >>> >>> The QMP mailbox is the primary means of communication between TMEL SS >>> and >> >> What is QMP? > Qualcomm Messaging Protocol > >> >>> other subsystem on the SoC. A dedicated pair of inbound and outbound >>> mailboxes is implemented for each subsystem/external execution >>> environment >> >> Is it implemented in the driver? Is it provided by the hardware? By the >> firmware? >> > TMEL firmware provides and processes the inbound requests and responds > back on the outbound channel. Can mention this explicitly in the above. > > Regards, > Sricharan
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,ipq5424-tmel.yaml b/Documentation/devicetree/bindings/mailbox/qcom,ipq5424-tmel.yaml new file mode 100644 index 000000000000..5bdeab166a1f --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/qcom,ipq5424-tmel.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mailbox/qcom,ipq5424-tmel.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm TMEL IPCC channel + +maintainers: + - Sricharan Ramabadhran <quic_srichara@quicinc.com> + +description: + TMEL(Trust Management Engine Lite) SS provides different kinds of services + like secureboot, remote image authentication, key management, crypto, OEM + provisioning etc. + + The QMP mailbox is the primary means of communication between TMEL SS and + other subsystem on the SoC. A dedicated pair of inbound and outbound mailbox + is implemented for each subsystem/external execution environment which needs + to communicate with TMEL for security services. The inbound mailboxes are used + to send IPC requests to TMEL, which are then processed by TMEL firmware and + accordingly the responses are sent back via outbound mailboxes. + +properties: + compatible: + items: + - enum: + - qcom,ipq5424-tmel + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + mboxes: + maxItems: 1 + + "#mbox-cells": + const: 1 + +required: + - compatible + - reg + - interrupts + - mboxes + - "#mbox-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + mailbox@32090000 { + compatible = "qcom,ipq5424-tmel"; + reg = <0x32090000 0x2000>; + interrupts = <GIC_SPI 126 IRQ_TYPE_EDGE_RISING>; + mboxes = <&apcs_glb 20>; + #mbox-cells = <1>; + };