mbox series

[0/2] Add vcp driver

Message ID 20250402092134.12293-1-xiangzhi.tang@mediatek.com (mailing list archive)
Headers show
Series Add vcp driver | expand

Message

Xiangzhi Tang (唐相志) April 2, 2025, 9:19 a.m. UTC 
Add support MediaTek's Video Companion Processor(VCP) host driver to
control the MediaTek VCP Risc-V coprocessor.
The VCP host driver using rproc mechanism to load vcm firmware
from filesystem, and using SMC services to request ATF to setting
vcp boot sequence, and Host communicated with VCP FW depends on VCP
IPC interfaces

This series patches dependent on:
[1]
https://lore.kernel.org/all/20250307032942.10447-1-guangjie.song@mediatek.com/
[2]
https://patchwork.kernel.org/project/linux-mediatek/patch/20250317110331.2776-4-jjian.zhou@mediatek.com/

note: dependent on arm,smmu-v3 Mediatek patch, onwer https://patchwork.kernel.org/project/linux-mediatek/list/?submitter=216242 

Xiangzhi Tang (2):
  dt-bindings: remoteproc: Add VCP support for mt8196
  remoterpoc: mediatek: vcp: Add vcp remoteproc driver

 .../remoteproc/mediatek,mt8196-vcp.yaml       | 174 ++++
 drivers/remoteproc/Kconfig                    |  12 +
 drivers/remoteproc/Makefile                   |   4 +
 drivers/remoteproc/mtk_vcp_common.c           | 982 ++++++++++++++++++
 drivers/remoteproc/mtk_vcp_common.h           | 251 +++++
 drivers/remoteproc/mtk_vcp_rproc.c            | 724 +++++++++++++
 drivers/remoteproc/mtk_vcp_rproc.h            | 107 ++
 include/linux/remoteproc/mtk_vcp_public.h     | 138 +++
 include/linux/soc/mediatek/mtk_sip_svc.h      |   3 +
 9 files changed, 2395 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml
 create mode 100644 drivers/remoteproc/mtk_vcp_common.c
 create mode 100644 drivers/remoteproc/mtk_vcp_common.h
 create mode 100644 drivers/remoteproc/mtk_vcp_rproc.c
 create mode 100644 drivers/remoteproc/mtk_vcp_rproc.h
 create mode 100644 include/linux/remoteproc/mtk_vcp_public.h

Comments

Krzysztof Kozlowski April 2, 2025, 10:31 a.m. UTC | #1 
On 02/04/2025 11:19, Xiangzhi Tang wrote:
> Add support MediaTek's Video Companion Processor(VCP) host driver to
> control the MediaTek VCP Risc-V coprocessor.
> The VCP host driver using rproc mechanism to load vcm firmware
> from filesystem, and using SMC services to request ATF to setting
> vcp boot sequence, and Host communicated with VCP FW depends on VCP
> IPC interfaces
> 
> This series patches dependent on:
> [1]
> https://lore.kernel.org/all/20250307032942.10447-1-guangjie.song@mediatek.com/

They should not depend. It blocks your patch. I suggest decoupling from
dependencies.


Best regards,
Krzysztof
Xiangzhi Tang (唐相志) April 6, 2025, 8:05 a.m. UTC | #2 
On Wed, 2025-04-02 at 12:31 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 02/04/2025 11:19, Xiangzhi Tang wrote:
> > Add support MediaTek's Video Companion Processor(VCP) host driver
> > to
> > control the MediaTek VCP Risc-V coprocessor.
> > The VCP host driver using rproc mechanism to load vcm firmware
> > from filesystem, and using SMC services to request ATF to setting
> > vcp boot sequence, and Host communicated with VCP FW depends on VCP
> > IPC interfaces
> > 
> > This series patches dependent on:
> > [1]
> > 
https://lore.kernel.org/all/20250307032942.10447-1-guangjie.song@mediatek.com/
> 
> They should not depend. It blocks your patch. I suggest decoupling
> from
> dependencies.
> I run test "make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/remoteproc/mediatek,m
t8196-vcp.yaml", And, I have to cherry-pick first "

https://lore.kernel.org/all/20250307032942.10447-1-guangjie.song@mediatek.com/
" and "

https://patchwork.kernel.org/project/linux-mediatek/patch/20250317110331.2776-4-jjian.zhou@mediatek.com/
"
> 
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski April 6, 2025, 12:13 p.m. UTC | #3 
On 06/04/2025 10:05, Xiangzhi Tang (唐相志) wrote:
> On Wed, 2025-04-02 at 12:31 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 02/04/2025 11:19, Xiangzhi Tang wrote:
>>> Add support MediaTek's Video Companion Processor(VCP) host driver
>>> to
>>> control the MediaTek VCP Risc-V coprocessor.
>>> The VCP host driver using rproc mechanism to load vcm firmware
>>> from filesystem, and using SMC services to request ATF to setting
>>> vcp boot sequence, and Host communicated with VCP FW depends on VCP
>>> IPC interfaces
>>>
>>> This series patches dependent on:
>>> [1]
>>>
> https://lore.kernel.org/all/20250307032942.10447-1-guangjie.song@mediatek.com/
>>
>> They should not depend. It blocks your patch. I suggest decoupling
>> from
>> dependencies.
>> I run test "make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/remoteproc/mediatek,m
> t8196-vcp.yaml", And, I have to cherry-pick first "
> 

How is this related? Did you read my message? You should not depend and
you answer "I added dependency". Great, so your patch won't get accepted
and won't get tested. Lack of testing will result in lack of review.


Best regards,
Krzysztof