| Message ID | 20250403182758.1948569-1-sean.anderson@linux.dev (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add PCS core support | expand |
On Thu, Apr 3, 2025 at 11:28 AM Sean Anderson <sean.anderson@linux.dev> wrote: > > This adds device link support for PCS devices, providing > better probe ordering. > > Signed-off-by: Sean Anderson <sean.anderson@linux.dev> > --- > > drivers/of/property.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index c1feb631e383..f3e0c390ddba 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1379,6 +1379,7 @@ DEFINE_SIMPLE_PROP(pses, "pses", "#pse-cells") > DEFINE_SIMPLE_PROP(power_supplies, "power-supplies", NULL) > DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) > DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") > +DEFINE_SIMPLE_PROP(pcs_handle, "pcs-handle", NULL) > > static struct device_node *parse_gpios(struct device_node *np, > const char *prop_name, int index) > @@ -1535,6 +1536,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { > .parse_prop = parse_post_init_providers, > .fwlink_flags = FWLINK_FLAG_IGNORE, > }, > + { .parse_prop = parse_pcs_handle, }, Can you add this in the right order please? All the simple ones come before the SUFFIX ones so that it's less expensive/fewer comparisons before you parse the simple properties. -Saravana > {} > }; > > -- > 2.35.1.1320.gc452695387.dirty >
On 4/3/25 14:32, Saravana Kannan wrote: > On Thu, Apr 3, 2025 at 11:28 AM Sean Anderson <sean.anderson@linux.dev> wrote: >> >> This adds device link support for PCS devices, providing >> better probe ordering. >> >> Signed-off-by: Sean Anderson <sean.anderson@linux.dev> >> --- >> >> drivers/of/property.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/of/property.c b/drivers/of/property.c >> index c1feb631e383..f3e0c390ddba 100644 >> --- a/drivers/of/property.c >> +++ b/drivers/of/property.c >> @@ -1379,6 +1379,7 @@ DEFINE_SIMPLE_PROP(pses, "pses", "#pse-cells") >> DEFINE_SIMPLE_PROP(power_supplies, "power-supplies", NULL) >> DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) >> DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") >> +DEFINE_SIMPLE_PROP(pcs_handle, "pcs-handle", NULL) >> >> static struct device_node *parse_gpios(struct device_node *np, >> const char *prop_name, int index) >> @@ -1535,6 +1536,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { >> .parse_prop = parse_post_init_providers, >> .fwlink_flags = FWLINK_FLAG_IGNORE, >> }, >> + { .parse_prop = parse_pcs_handle, }, > > Can you add this in the right order please? All the simple ones come > before the SUFFIX ones so that it's less expensive/fewer comparisons > before you parse the simple properties. Ah, I couldn't figure out what the intended order was so I just stuck it at the end. --Sean
diff --git a/drivers/of/property.c b/drivers/of/property.c index c1feb631e383..f3e0c390ddba 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1379,6 +1379,7 @@ DEFINE_SIMPLE_PROP(pses, "pses", "#pse-cells") DEFINE_SIMPLE_PROP(power_supplies, "power-supplies", NULL) DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") +DEFINE_SIMPLE_PROP(pcs_handle, "pcs-handle", NULL) static struct device_node *parse_gpios(struct device_node *np, const char *prop_name, int index) @@ -1535,6 +1536,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { .parse_prop = parse_post_init_providers, .fwlink_flags = FWLINK_FLAG_IGNORE, }, + { .parse_prop = parse_pcs_handle, }, {} };
This adds device link support for PCS devices, providing better probe ordering. Signed-off-by: Sean Anderson <sean.anderson@linux.dev> --- drivers/of/property.c | 2 ++ 1 file changed, 2 insertions(+)