| Message ID | 20250404-dprates-v5-1-c93f561a095e@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Remove support for UHBR13.5 | expand |
On Fri, 04 Apr 2025, Arun R Murthy <arun.r.murthy@intel.com> wrote: > The retimer issue for UHBR13.5 is fixed in BMG. As I said before, I don't even know what "the retimer issue" was. It's never been explained anywhere. Please explain it to me. And don't send a new version of the patch. BR, Jani. > So for all platforms lesser than BMG(XE2_HPD/DISPLAY_VERx100 1401) > disable UHBR13.5. > commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") > removes UHBR13.5 for MTL. > > v2: Reframed the commit msg (Jani) > v4: Reframed the commit msg & update the max rate supported (Jani) > v5: Reframed the commit msg (Jani) > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index f21f9b441fc2a4e644c69410e6ec6b3d37907478..92bca701a989b03e2ad4b3d9e7d0a9ef12567e5a 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -481,7 +481,7 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp) > > static int dg2_max_source_rate(struct intel_dp *intel_dp) > { > - return intel_dp_is_edp(intel_dp) ? 810000 : 1350000; > + return intel_dp_is_edp(intel_dp) ? 810000 : 1000000; > } > > static int icl_max_source_rate(struct intel_dp *intel_dp) > @@ -550,7 +550,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) > }; > static const int icl_rates[] = { > 162000, 216000, 270000, 324000, 432000, 540000, 648000, 810000, > - 1000000, 1350000, > + 1000000, > }; > static const int bxt_rates[] = { > 162000, 216000, 243000, 270000, 324000, 432000, 540000
Any comments? Gentle Reminder! Thanks and Regards, Arun R Murthy -------------------- > -----Original Message----- > From: Murthy, Arun R <arun.r.murthy@intel.com> > Sent: Friday, April 4, 2025 10:25 AM > To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org > Cc: Jani Nikula <jani.nikula@linux.intel.com>; Deak, Imre > <imre.deak@intel.com>; Murthy, Arun R <arun.r.murthy@intel.com> > Subject: [PATCH v5 1/2] drm/i915/display/dp: Remove support for UHBR13.5 > > The retimer issue for UHBR13.5 is fixed in BMG. > So for all platforms lesser than BMG(XE2_HPD/DISPLAY_VERx100 1401) disable > UHBR13.5. > commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") > removes UHBR13.5 for MTL. > > v2: Reframed the commit msg (Jani) > v4: Reframed the commit msg & update the max rate supported (Jani) > v5: Reframed the commit msg (Jani) > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index > f21f9b441fc2a4e644c69410e6ec6b3d37907478..92bca701a989b03e2ad4b3d9 > e7d0a9ef12567e5a 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -481,7 +481,7 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp) > > static int dg2_max_source_rate(struct intel_dp *intel_dp) { > - return intel_dp_is_edp(intel_dp) ? 810000 : 1350000; > + return intel_dp_is_edp(intel_dp) ? 810000 : 1000000; > } > > static int icl_max_source_rate(struct intel_dp *intel_dp) @@ -550,7 +550,7 > @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) > }; > static const int icl_rates[] = { > 162000, 216000, 270000, 324000, 432000, 540000, 648000, > 810000, > - 1000000, 1350000, > + 1000000, > }; > static const int bxt_rates[] = { > 162000, 216000, 243000, 270000, 324000, 432000, 540000 > > -- > 2.25.1
On Mon, 14 Apr 2025, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: > Any comments? > Gentle Reminder! This is the level of clarity and accuracy I was hoping for in the commit message: """ Subject: drm/i915/dp: DG2 does not support UHBR 13.5 DG2 does not actually support UHBR 13.5 link rate. Reduce DG2 max link rate to UHBR 10, and drop UHBR 13.5 from the supported source rates for DG2. The VBT on DG2 platforms should already limit the max link rate to UHBR 10, but be defensive about it. """ > > Thanks and Regards, > Arun R Murthy > -------------------- > >> -----Original Message----- >> From: Murthy, Arun R <arun.r.murthy@intel.com> >> Sent: Friday, April 4, 2025 10:25 AM >> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org >> Cc: Jani Nikula <jani.nikula@linux.intel.com>; Deak, Imre >> <imre.deak@intel.com>; Murthy, Arun R <arun.r.murthy@intel.com> >> Subject: [PATCH v5 1/2] drm/i915/display/dp: Remove support for UHBR13.5 >> >> The retimer issue for UHBR13.5 is fixed in BMG. >> So for all platforms lesser than BMG(XE2_HPD/DISPLAY_VERx100 1401) disable >> UHBR13.5. >> commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") >> removes UHBR13.5 for MTL. >> >> v2: Reframed the commit msg (Jani) >> v4: Reframed the commit msg & update the max rate supported (Jani) >> v5: Reframed the commit msg (Jani) >> >> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> >> --- >> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c >> b/drivers/gpu/drm/i915/display/intel_dp.c >> index >> f21f9b441fc2a4e644c69410e6ec6b3d37907478..92bca701a989b03e2ad4b3d9 >> e7d0a9ef12567e5a 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >> @@ -481,7 +481,7 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp) >> >> static int dg2_max_source_rate(struct intel_dp *intel_dp) { >> - return intel_dp_is_edp(intel_dp) ? 810000 : 1350000; >> + return intel_dp_is_edp(intel_dp) ? 810000 : 1000000; >> } >> >> static int icl_max_source_rate(struct intel_dp *intel_dp) @@ -550,7 +550,7 >> @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) >> }; >> static const int icl_rates[] = { >> 162000, 216000, 270000, 324000, 432000, 540000, 648000, >> 810000, >> - 1000000, 1350000, >> + 1000000, >> }; >> static const int bxt_rates[] = { >> 162000, 216000, 243000, 270000, 324000, 432000, 540000 >> >> -- >> 2.25.1 >
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index f21f9b441fc2a4e644c69410e6ec6b3d37907478..92bca701a989b03e2ad4b3d9e7d0a9ef12567e5a 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -481,7 +481,7 @@ bool intel_dp_has_joiner(struct intel_dp *intel_dp) static int dg2_max_source_rate(struct intel_dp *intel_dp) { - return intel_dp_is_edp(intel_dp) ? 810000 : 1350000; + return intel_dp_is_edp(intel_dp) ? 810000 : 1000000; } static int icl_max_source_rate(struct intel_dp *intel_dp) @@ -550,7 +550,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) }; static const int icl_rates[] = { 162000, 216000, 270000, 324000, 432000, 540000, 648000, 810000, - 1000000, 1350000, + 1000000, }; static const int bxt_rates[] = { 162000, 216000, 243000, 270000, 324000, 432000, 540000
The retimer issue for UHBR13.5 is fixed in BMG. So for all platforms lesser than BMG(XE2_HPD/DISPLAY_VERx100 1401) disable UHBR13.5. commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") removes UHBR13.5 for MTL. v2: Reframed the commit msg (Jani) v4: Reframed the commit msg & update the max rate supported (Jani) v5: Reframed the commit msg (Jani) Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)