| Message ID | 20250407095119.588920-2-mitltlatltl@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | backlight: ktz8866: improve it and support slave | expand |
On 07/04/2025 11:51, Pengyu Luo wrote: > Kinetic ktz8866, found in many android devices, nowadays, some oem use > dual ktz8866 to support a larger panel and higher brightness, add the Just one space after 'and'. > binding for slave case. > > Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com> > --- > .../leds/backlight/kinetic,ktz8866.yaml | 29 +++++++++++++++---- > 1 file changed, 24 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > index c914e1276..825a6fbf1 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > @@ -19,7 +19,9 @@ allOf: > > properties: > compatible: > - const: kinetic,ktz8866 > + enum: > + - kinetic,ktz8866 > + - kinetic,ktz8866-slave Does not look right. That's the same device. Same devices have same compatible. > > reg: > maxItems: 1 > @@ -58,9 +60,16 @@ properties: > required: > - compatible > - reg > - - vddpos-supply > - - vddneg-supply > - - enable-gpios > + > +if: > + properties: > + compatible: > + const: kinetic,ktz8866 > +then: > + required: > + - vddpos-supply > + - vddneg-supply > + - enable-gpios I don't understand why other device does not need power. > > unevaluatedProperties: false > > @@ -68,7 +77,7 @@ examples: > - | > #include <dt-bindings/gpio/gpio.h> > > - i2c { > + i2c0 { No, don't change. > #address-cells = <1>; > #size-cells = <0>; > > @@ -84,3 +93,13 @@ examples: > kinetic,enable-lcd-bias; > }; > }; > + > + i2c1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + backlight@11 { > + compatible = "kinetic,ktz8866-slave"; > + reg = <0x11>; No real differences here, so drop the example. Anyway, new examples would start from - | (see other bindings). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml index c914e1276..825a6fbf1 100644 --- a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml @@ -19,7 +19,9 @@ allOf: properties: compatible: - const: kinetic,ktz8866 + enum: + - kinetic,ktz8866 + - kinetic,ktz8866-slave reg: maxItems: 1 @@ -58,9 +60,16 @@ properties: required: - compatible - reg - - vddpos-supply - - vddneg-supply - - enable-gpios + +if: + properties: + compatible: + const: kinetic,ktz8866 +then: + required: + - vddpos-supply + - vddneg-supply + - enable-gpios unevaluatedProperties: false @@ -68,7 +77,7 @@ examples: - | #include <dt-bindings/gpio/gpio.h> - i2c { + i2c0 { #address-cells = <1>; #size-cells = <0>; @@ -84,3 +93,13 @@ examples: kinetic,enable-lcd-bias; }; }; + + i2c1 { + #address-cells = <1>; + #size-cells = <0>; + + backlight@11 { + compatible = "kinetic,ktz8866-slave"; + reg = <0x11>; + }; + };
Kinetic ktz8866, found in many android devices, nowadays, some oem use dual ktz8866 to support a larger panel and higher brightness, add the binding for slave case. Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com> --- .../leds/backlight/kinetic,ktz8866.yaml | 29 +++++++++++++++---- 1 file changed, 24 insertions(+), 5 deletions(-)