| Message ID | 20250407133138.22449-5-bincai.liu@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add dsi support for mt8196 | expand |
On Mon, 2025-04-07 at 21:31 +0800, Bincai Liu wrote: > This power is new added in MT8196. So runtime PM is enable > to turn off dsi power to reduce power consumption. I think you should describe why old SoC is not necessary to do this. I guess that DSI and display pipeline share the same power in old SoC, so DSI could not turn off the common power in old SoC. Regards, CK > > Signed-off-by: Bincai Liu <bincai.liu@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index b1467d6bed06..21cfba1f9b89 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -12,6 +12,7 @@ > #include <linux/of_platform.h> > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > #include <linux/reset.h> > #include <linux/units.h> > > @@ -715,6 +716,7 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi) > dsi->data_rate = DIV_ROUND_UP_ULL(dsi->vm.pixelclock * bit_per_pixel, > dsi->lanes); > > + pm_runtime_get_sync(dsi->host.dev); > ret = clk_set_rate(dsi->hs_clk, dsi->data_rate); > if (ret < 0) { > dev_err(dev, "Failed to set data rate: %d\n", ret); > @@ -789,6 +791,7 @@ static void mtk_dsi_poweroff(struct mtk_dsi *dsi) > clk_disable_unprepare(dsi->digital_clk); > > phy_power_off(dsi->phy); > + pm_runtime_put_sync(dsi->host.dev); > > dsi->lanes_ready = false; > } > @@ -1272,6 +1275,7 @@ static int mtk_dsi_probe(struct platform_device *pdev) > dsi->bridge.funcs = &mtk_dsi_bridge_funcs; > dsi->bridge.of_node = dev->of_node; > dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; > + pm_runtime_enable(dev); > > return 0; > } > @@ -1282,6 +1286,7 @@ static void mtk_dsi_remove(struct platform_device *pdev) > > mtk_output_dsi_disable(dsi); > mipi_dsi_host_unregister(&dsi->host); > + pm_runtime_disable(&pdev->dev); > } > > static const struct mtk_dsi_driver_data mt8173_dsi_driver_data = {
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index b1467d6bed06..21cfba1f9b89 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -12,6 +12,7 @@ #include <linux/of_platform.h> #include <linux/phy/phy.h> #include <linux/platform_device.h> +#include <linux/pm_runtime.h> #include <linux/reset.h> #include <linux/units.h> @@ -715,6 +716,7 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi) dsi->data_rate = DIV_ROUND_UP_ULL(dsi->vm.pixelclock * bit_per_pixel, dsi->lanes); + pm_runtime_get_sync(dsi->host.dev); ret = clk_set_rate(dsi->hs_clk, dsi->data_rate); if (ret < 0) { dev_err(dev, "Failed to set data rate: %d\n", ret); @@ -789,6 +791,7 @@ static void mtk_dsi_poweroff(struct mtk_dsi *dsi) clk_disable_unprepare(dsi->digital_clk); phy_power_off(dsi->phy); + pm_runtime_put_sync(dsi->host.dev); dsi->lanes_ready = false; } @@ -1272,6 +1275,7 @@ static int mtk_dsi_probe(struct platform_device *pdev) dsi->bridge.funcs = &mtk_dsi_bridge_funcs; dsi->bridge.of_node = dev->of_node; dsi->bridge.type = DRM_MODE_CONNECTOR_DSI; + pm_runtime_enable(dev); return 0; } @@ -1282,6 +1286,7 @@ static void mtk_dsi_remove(struct platform_device *pdev) mtk_output_dsi_disable(dsi); mipi_dsi_host_unregister(&dsi->host); + pm_runtime_disable(&pdev->dev); } static const struct mtk_dsi_driver_data mt8173_dsi_driver_data = {
This power is new added in MT8196. So runtime PM is enable to turn off dsi power to reduce power consumption. Signed-off-by: Bincai Liu <bincai.liu@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 5 +++++ 1 file changed, 5 insertions(+)