| Message ID | PN3PR01MB9597382EFDE3452410A866AEB8B52@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use proper printk format in appletbdrm | expand |
On Tue, Apr 08, 2025 at 12:17:13PM +0530, Aditya Garg wrote: > The vsprint patch was originally being sent as a seperate patch [1], and > I was waiting it to be taken up. But as suggested by Petr, I'm sending > them via DRM. You need to do something about your tools, really. Now it's patch 3 threaded to patch 1, while the rest, including cover letter, seems okay.
> On 8 Apr 2025, at 2:11 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Apr 08, 2025 at 12:17:13PM +0530, Aditya Garg wrote: >> The vsprint patch was originally being sent as a seperate patch [1], and >> I was waiting it to be taken up. But as suggested by Petr, I'm sending >> them via DRM. > > You need to do something about your tools, really. Uhh, I'll just revert to the tried and tested macOS mail. Although I don't think a resend is necessary here now. > Now it's patch 3 threaded to patch 1, while the rest, including cover letter, > seems okay. > > > -- > With Best Regards, > Andy Shevchenko > >
On Tue, Apr 08, 2025 at 08:52:10AM +0000, Aditya Garg wrote: > > On 8 Apr 2025, at 2:11 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Apr 08, 2025 at 12:17:13PM +0530, Aditya Garg wrote: > >> The vsprint patch was originally being sent as a seperate patch [1], and > >> I was waiting it to be taken up. But as suggested by Petr, I'm sending > >> them via DRM. > > > > You need to do something about your tools, really. > > Uhh, I'll just revert to the tried and tested macOS mail. > > Although I don't think a resend is necessary here now. I dunno. If people are using `b4`, it might mess up the patch ordering, I haven't checked this myself (it depends if it takes [PATCH x/y] or message threading into account first). It seems not a big deal with _this_ series, but for the future it may be really a problem (esp. from [runtime] bisectability point of view). > > Now it's patch 3 threaded to patch 1, while the rest, including cover letter, > > seems okay.
On Tue 2025-04-08 12:38:50, Andy Shevchenko wrote: > On Tue, Apr 08, 2025 at 08:52:10AM +0000, Aditya Garg wrote: > > > On 8 Apr 2025, at 2:11 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > On Tue, Apr 08, 2025 at 12:17:13PM +0530, Aditya Garg wrote: > > >> The vsprint patch was originally being sent as a seperate patch [1], and > > >> I was waiting it to be taken up. But as suggested by Petr, I'm sending > > >> them via DRM. > > > > > > You need to do something about your tools, really. > > > > Uhh, I'll just revert to the tried and tested macOS mail. > > > > Although I don't think a resend is necessary here now. > > I dunno. If people are using `b4`, it might mess up the patch ordering, > I haven't checked this myself (it depends if it takes [PATCH x/y] or message > threading into account first). JFYI, it seems that b4 handles this correctly. AFAIK, it checks the [PATCH x/y] in subjects. But I am not sure what DRM guys are using. I guess that they are using patchwork. I am not sure how it handles this... Best Regards, Petr
Hi On 08-04-2025 12:17 pm, Aditya Garg wrote: > The vsprint patch was originally being sent as a seperate patch [1], and > I was waiting it to be taken up. But as suggested by Petr, I'm sending > them via DRM. > > v2: > Remove printf tests, will merge later through Kees' tree > > v3: > Re-add printf tests, since 6.15-rc1 has the necessary commits merged now. > > v4: > Do changes requested by Andy and add Petr's review to printf patch. > > Link: https://lore.kernel.org/lkml/1A03A5B4-93AC-4307-AE6A-4A4C4B7E9472@live.com/ [1] > > Aditya Garg (2): > printf: add tests for generic FourCCs > drm/appletbdrm: use %p4cl instead of %p4cc > > Hector Martin (1): > lib/vsprintf: Add support for generic FourCCs by extending %p4cc > > Documentation/core-api/printk-formats.rst | 32 +++++++++++++++++++ > drivers/gpu/drm/tiny/appletbdrm.c | 4 +-- > lib/tests/printf_kunit.c | 39 +++++++++++++++++++---- > lib/vsprintf.c | 35 ++++++++++++++++---- > scripts/checkpatch.pl | 2 +- > 5 files changed, 96 insertions(+), 16 deletions(-) > Can I have a feedback from some DRM maintainer on this? AFAIK merge window is over for some time now. It's been more than a week and last time when I submitted, it just stayed in the mailing list without any feedback. Thanks Aditya