| Message ID | cover.1743682608.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915/dsi: couple of fixing | expand |
Hi Jani Both patches look good to me after reviewing and testing the two patches with the hardware. The MIPI DSI panel is working with the patches. In the test, both clock and data timing have no change before and after patch. Please let me know if you have any questions. Regards William > -----Original Message----- > From: Nikula, Jani <jani.nikula@intel.com> > Sent: Thursday, April 3, 2025 8:22 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; Tseng, William > <william.tseng@intel.com> > Subject: [PATCH 0/2] drm/i915/dsi: couple of fixing > > When I was reviewing [1] these oddities caught my eye. > > BR, > Jani. > > [1] https://lore.kernel.org/r/20250311100626.533888-1- > william.tseng@intel.com > > Cc: William Tseng <william.tseng@intel.com> > > Jani Nikula (2): > drm/i915/dsi: separate clock and data lane prepare timing > drm/i915/dsi: unify naming and simplify checks for dphy params > > drivers/gpu/drm/i915/display/icl_dsi.c | 90 ++++++++------------------ > 1 file changed, 26 insertions(+), 64 deletions(-) > > -- > 2.39.5
On Tue, 08 Apr 2025, "Tseng, William" <william.tseng@intel.com> wrote: > Hi Jani > > Both patches look good to me after reviewing and testing the > two patches with the hardware. The MIPI DSI panel is working > with the patches. In the test, both clock and data timing have > no change before and after patch. > > Please let me know if you have any questions. If you think we should merge these, please provide your Reviewed-by and Tested-by, and I will. :) BR, Jani. > > > Regards > William > >> -----Original Message----- >> From: Nikula, Jani <jani.nikula@intel.com> >> Sent: Thursday, April 3, 2025 8:22 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani <jani.nikula@intel.com>; Tseng, William >> <william.tseng@intel.com> >> Subject: [PATCH 0/2] drm/i915/dsi: couple of fixing >> >> When I was reviewing [1] these oddities caught my eye. >> >> BR, >> Jani. >> >> [1] https://lore.kernel.org/r/20250311100626.533888-1- >> william.tseng@intel.com >> >> Cc: William Tseng <william.tseng@intel.com> >> >> Jani Nikula (2): >> drm/i915/dsi: separate clock and data lane prepare timing >> drm/i915/dsi: unify naming and simplify checks for dphy params >> >> drivers/gpu/drm/i915/display/icl_dsi.c | 90 ++++++++------------------ >> 1 file changed, 26 insertions(+), 64 deletions(-) >> >> -- >> 2.39.5 >
> -----Original Message----- > From: Nikula, Jani <jani.nikula@intel.com> > Sent: Wednesday, April 9, 2025 3:55 PM > To: Tseng, William <william.tseng@intel.com>; intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH 0/2] drm/i915/dsi: couple of fixing > > On Tue, 08 Apr 2025, "Tseng, William" <william.tseng@intel.com> wrote: > > Hi Jani > > > > Both patches look good to me after reviewing and testing the two > > patches with the hardware. The MIPI DSI panel is working with the > > patches. In the test, both clock and data timing have no change before > > and after patch. > > > > Please let me know if you have any questions. > > If you think we should merge these, please provide your Reviewed-by and > Tested-by, and I will. :) > Yes, we should merge these patches for sure. Here are the tags. Reviewed-by: William Tseng <william.tseng@intel.com> Tested-by: William Tseng <william.tseng@intel.com> Thank you for contacting me. Regards William > BR, > Jani. > > > > > > > > > > > Regards > > William > > > >> -----Original Message----- > >> From: Nikula, Jani <jani.nikula@intel.com> > >> Sent: Thursday, April 3, 2025 8:22 PM > >> To: intel-gfx@lists.freedesktop.org > >> Cc: Nikula, Jani <jani.nikula@intel.com>; Tseng, William > >> <william.tseng@intel.com> > >> Subject: [PATCH 0/2] drm/i915/dsi: couple of fixing > >> > >> When I was reviewing [1] these oddities caught my eye. > >> > >> BR, > >> Jani. > >> > >> [1] https://lore.kernel.org/r/20250311100626.533888-1- > >> william.tseng@intel.com > >> > >> Cc: William Tseng <william.tseng@intel.com> > >> > >> Jani Nikula (2): > >> drm/i915/dsi: separate clock and data lane prepare timing > >> drm/i915/dsi: unify naming and simplify checks for dphy params > >> > >> drivers/gpu/drm/i915/display/icl_dsi.c | 90 > >> ++++++++------------------ > >> 1 file changed, 26 insertions(+), 64 deletions(-) > >> > >> -- > >> 2.39.5 > > > > -- > Jani Nikula, Intel
On Wed, 09 Apr 2025, "Tseng, William" <william.tseng@intel.com> wrote: > Yes, we should merge these patches for sure. Here are the tags. > > Reviewed-by: William Tseng <william.tseng@intel.com> > Tested-by: William Tseng <william.tseng@intel.com> > > Thank you for contacting me. Thanks a lot, pushed to drm-intel-next. BR, Jani.