| Message ID | 20250407200508.121357-4-vbabka@suse.cz (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,1/2] MAINTAINERS: update SLAB ALLOCATOR maintainers | expand |
On 7 Apr 2025, at 16:05, Vlastimil Babka wrote: > Add a subsection for the page allocator, including compaction as it's > crucial for high-order allocations and works together with the > anti-fragmentation features. Volunteer myself as a reviewer. > > Cc: David Hildenbrand <david@redhat.com> > Cc: Zi Yan <ziy@nvidia.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Suren Baghdasaryan <surenb@google.com> > Cc: Brendan Jackman <jackmanb@google.com> > Cc: Michal Hocko <mhocko@kernel.org> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> > --- > Extra reviewers would be welcome, including/not limited the people I > Cc'd based on my recollection and get_maintainers --git > Also if I missed any related file please lmk. Thanks. > > MAINTAINERS | 10 ++++++++++ > 1 file changed, 10 insertions(+) Acked-by: Zi Yan <ziy@nvidia.com> I am happy to help review patches for page allocator and compaction too. Should I send a separate patch to add myself? Or you can add R: Zi Yan <ziy@nvidia.com> in your next version? > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4fe7cf5fc4ea..610636f622b1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15511,6 +15511,16 @@ F: mm/numa.c > F: mm/numa_emulation.c > F: mm/numa_memblks.c > > +MEMORY MANAGEMENT - PAGE ALLOCATOR > +M: Andrew Morton <akpm@linux-foundation.org> > +R: Vlastimil Babka <vbabka@suse.cz> > +L: linux-mm@kvack.org > +S: Maintained > +F: mm/compaction.c > +F: mm/page_alloc.c > +F: include/linux/gfp.h > +F: include/linux/compaction.h > + > MEMORY MANAGEMENT - SECRETMEM > M: Andrew Morton <akpm@linux-foundation.org> > M: Mike Rapoport <rppt@kernel.org> > -- > 2.49.0 Best Regards, Yan, Zi
On 4/7/25 22:12, Zi Yan wrote: > On 7 Apr 2025, at 16:05, Vlastimil Babka wrote: > >> Add a subsection for the page allocator, including compaction as it's >> crucial for high-order allocations and works together with the >> anti-fragmentation features. Volunteer myself as a reviewer. >> >> Cc: David Hildenbrand <david@redhat.com> >> Cc: Zi Yan <ziy@nvidia.com> >> Cc: Johannes Weiner <hannes@cmpxchg.org> >> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> >> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> >> Cc: Mel Gorman <mgorman@techsingularity.net> >> Cc: Suren Baghdasaryan <surenb@google.com> >> Cc: Brendan Jackman <jackmanb@google.com> >> Cc: Michal Hocko <mhocko@kernel.org> >> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> >> --- >> Extra reviewers would be welcome, including/not limited the people I >> Cc'd based on my recollection and get_maintainers --git >> Also if I missed any related file please lmk. Thanks. >> >> MAINTAINERS | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > > Acked-by: Zi Yan <ziy@nvidia.com> Thanks. > I am happy to help review patches for page allocator and > compaction too. Should I send a separate patch to add myself? > Or you can add > > R: Zi Yan <ziy@nvidia.com> > > in your next version? Sure, will do, thanks! >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 4fe7cf5fc4ea..610636f622b1 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -15511,6 +15511,16 @@ F: mm/numa.c >> F: mm/numa_emulation.c >> F: mm/numa_memblks.c >> >> +MEMORY MANAGEMENT - PAGE ALLOCATOR >> +M: Andrew Morton <akpm@linux-foundation.org> >> +R: Vlastimil Babka <vbabka@suse.cz> >> +L: linux-mm@kvack.org >> +S: Maintained >> +F: mm/compaction.c >> +F: mm/page_alloc.c >> +F: include/linux/gfp.h >> +F: include/linux/compaction.h >> + >> MEMORY MANAGEMENT - SECRETMEM >> M: Andrew Morton <akpm@linux-foundation.org> >> M: Mike Rapoport <rppt@kernel.org> >> -- >> 2.49.0 > > > Best Regards, > Yan, Zi
On Mon, Apr 07, 2025 at 10:05:10PM +0200, Vlastimil Babka wrote: > Extra reviewers would be welcome, including/not limited the people I > Cc'd based on my recollection and get_maintainers --git > Also if I missed any related file please lmk. Thanks. I appreciate the offer. I feel entirely unqualified to review patches to the page allocator, although I'll probably end up touching it quite a lot when we move to separately allocated folios.
On Mon, Apr 07, 2025 at 10:05:10PM +0200, Vlastimil Babka wrote: > Add a subsection for the page allocator, including compaction as it's > crucial for high-order allocations and works together with the > anti-fragmentation features. Volunteer myself as a reviewer. > > Cc: David Hildenbrand <david@redhat.com> > Cc: Zi Yan <ziy@nvidia.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Suren Baghdasaryan <surenb@google.com> > Cc: Brendan Jackman <jackmanb@google.com> > Cc: Michal Hocko <mhocko@kernel.org> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Thanks, I would love to help review allocator patches. Could you please add me as well in the next version? R: Johannes Weiner <hannes@cmpxchg.org>
On Mon 07-04-25 22:05:10, Vlastimil Babka wrote: > Add a subsection for the page allocator, including compaction as it's > crucial for high-order allocations and works together with the > anti-fragmentation features. Volunteer myself as a reviewer. > > Cc: David Hildenbrand <david@redhat.com> > Cc: Zi Yan <ziy@nvidia.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Suren Baghdasaryan <surenb@google.com> > Cc: Brendan Jackman <jackmanb@google.com> > Cc: Michal Hocko <mhocko@kernel.org> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Acked-by: Michal Hocko <mhocko@suse.com> Feel free to add R: Michal Hocko <mhocko@suse.com> Thanks > --- > Extra reviewers would be welcome, including/not limited the people I > Cc'd based on my recollection and get_maintainers --git > Also if I missed any related file please lmk. Thanks. > > MAINTAINERS | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4fe7cf5fc4ea..610636f622b1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15511,6 +15511,16 @@ F: mm/numa.c > F: mm/numa_emulation.c > F: mm/numa_memblks.c > > +MEMORY MANAGEMENT - PAGE ALLOCATOR > +M: Andrew Morton <akpm@linux-foundation.org> > +R: Vlastimil Babka <vbabka@suse.cz> > +L: linux-mm@kvack.org > +S: Maintained > +F: mm/compaction.c > +F: mm/page_alloc.c > +F: include/linux/gfp.h > +F: include/linux/compaction.h > + > MEMORY MANAGEMENT - SECRETMEM > M: Andrew Morton <akpm@linux-foundation.org> > M: Mike Rapoport <rppt@kernel.org> > -- > 2.49.0
On Mon Apr 7, 2025 at 8:05 PM UTC, Vlastimil Babka wrote: > Add a subsection for the page allocator, including compaction as it's > crucial for high-order allocations and works together with the > anti-fragmentation features. Volunteer myself as a reviewer. Thanks for volunteering and thanks for proposing this update. > Extra reviewers would be welcome, including/not limited the people I > Cc'd based on my recollection and get_maintainers --git > Also if I missed any related file please lmk. Thanks. If this is a "more the merrier" situation I'd also be happy to be an R: here: +R: Brendan Jackman <jackmanb@google.com>
On Tue, Apr 8, 2025 at 7:13 AM Brendan Jackman <jackmanb@google.com> wrote: > > On Mon Apr 7, 2025 at 8:05 PM UTC, Vlastimil Babka wrote: > > Add a subsection for the page allocator, including compaction as it's > > crucial for high-order allocations and works together with the > > anti-fragmentation features. Volunteer myself as a reviewer. > > Thanks for volunteering and thanks for proposing this update. > > > Extra reviewers would be welcome, including/not limited the people I > > Cc'd based on my recollection and get_maintainers --git > > Also if I missed any related file please lmk. Thanks. > > If this is a "more the merrier" situation I'd also be happy to be > an R: here: > > +R: Brendan Jackman <jackmanb@google.com> Same here. +R: Suren Baghdasaryan <surenb@google.com> Thanks Vlastimil!
On 07.04.25 22:05, Vlastimil Babka wrote: > Add a subsection for the page allocator, including compaction as it's > crucial for high-order allocations and works together with the > anti-fragmentation features. Volunteer myself as a reviewer. > > Cc: David Hildenbrand <david@redhat.com> > Cc: Zi Yan <ziy@nvidia.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Suren Baghdasaryan <surenb@google.com> > Cc: Brendan Jackman <jackmanb@google.com> > Cc: Michal Hocko <mhocko@kernel.org> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> > --- > Extra reviewers would be welcome, including/not limited the people I > Cc'd based on my recollection and get_maintainers --git > Also if I missed any related file please lmk. Thanks. Likely we have sufficient R: at this point (good!); as there is a bunch of stuff in page_alloc.c, I'll likely do my usual linux-mm scan + keyword notification to spot changes in there that I can review with confidence.
diff --git a/MAINTAINERS b/MAINTAINERS index 4fe7cf5fc4ea..610636f622b1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15511,6 +15511,16 @@ F: mm/numa.c F: mm/numa_emulation.c F: mm/numa_memblks.c +MEMORY MANAGEMENT - PAGE ALLOCATOR +M: Andrew Morton <akpm@linux-foundation.org> +R: Vlastimil Babka <vbabka@suse.cz> +L: linux-mm@kvack.org +S: Maintained +F: mm/compaction.c +F: mm/page_alloc.c +F: include/linux/gfp.h +F: include/linux/compaction.h + MEMORY MANAGEMENT - SECRETMEM M: Andrew Morton <akpm@linux-foundation.org> M: Mike Rapoport <rppt@kernel.org>
Add a subsection for the page allocator, including compaction as it's crucial for high-order allocations and works together with the anti-fragmentation features. Volunteer myself as a reviewer. Cc: David Hildenbrand <david@redhat.com> Cc: Zi Yan <ziy@nvidia.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: Suren Baghdasaryan <surenb@google.com> Cc: Brendan Jackman <jackmanb@google.com> Cc: Michal Hocko <mhocko@kernel.org> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- Extra reviewers would be welcome, including/not limited the people I Cc'd based on my recollection and get_maintainers --git Also if I missed any related file please lmk. Thanks. MAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)