diff mbox series

ALSA: hda/cirrus_scodec_test: Don't select dependencies

Message ID 20250409114520.914079-1-rf@opensource.cirrus.com (mailing list archive)
State New
Headers show
Series ALSA: hda/cirrus_scodec_test: Don't select dependencies | expand

Commit Message

Richard Fitzgerald April 9, 2025, 11:45 a.m. UTC 
Depend on SND_HDA_CIRRUS_SCODEC and GPIOLIB instead of selecting them.

KUNIT_ALL_TESTS should only build tests that have satisfied dependencies
and test components that are already being built. It must not cause
other stuff to be added to the build.

Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
 sound/pci/hda/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Takashi Iwai April 9, 2025, 12:55 p.m. UTC | #1 
On Wed, 09 Apr 2025 13:45:20 +0200,
Richard Fitzgerald wrote:
> 
> Depend on SND_HDA_CIRRUS_SCODEC and GPIOLIB instead of selecting them.
> 
> KUNIT_ALL_TESTS should only build tests that have satisfied dependencies
> and test components that are already being built. It must not cause
> other stuff to be added to the build.
> 
> Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test")
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index fb955a205d50..9c427270ff4f 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -96,9 +96,7 @@  config SND_HDA_CIRRUS_SCODEC
 
 config SND_HDA_CIRRUS_SCODEC_KUNIT_TEST
 	tristate "KUnit test for Cirrus side-codec library" if !KUNIT_ALL_TESTS
-	select SND_HDA_CIRRUS_SCODEC
-	select GPIOLIB
-	depends on KUNIT
+	depends on SND_HDA_CIRRUS_SCODEC && GPIOLIB && KUNIT
 	default KUNIT_ALL_TESTS
 	help
 	  This builds KUnit tests for the cirrus side-codec library.