[net-next,v1,00/11] net: pktgen: fix checkpatch code style errors/warnings

Message

Peter Seiderer April 10, 2025, 7:17 a.m. UTC

Fix checkpatch detected code style errors/warnings detected in
the file net/core/pktgen.c (remaining checkpatch checks will be addressed
in a follow up patch set).

Peter Seiderer (11):
  net: pktgen: fix code style (ERROR: "foo * bar" should be "foo *bar")
  net: pktgen: fix code style (ERROR: space prohibited after that '&')
  net: pktgen: fix code style (ERROR: else should follow close brace
    '}')
  net: pktgen: fix code style (WARNING: please, no space before tabs)
  net: pktgen: fix code style (WARNING: suspect code indent for
    conditional statements)
  net: pktgen: fix code style (WARNING: Block comments)
  net: pktgen: fix code style (WARNING: Missing a blank line after
    declarations)
  net: pktgen: fix code style (WARNING: macros should not use a trailing
    semicolon)
  net: pktgen: fix code style (WARNING: braces {} are not necessary for
    single statement blocks)
  net: pktgen: fix code style (WARNING: quoted string split across
    lines)
  net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)

 net/core/pktgen.c | 111 ++++++++++++++++++++++++++--------------------
 1 file changed, 64 insertions(+), 47 deletions(-)

Comments

Toke Høiland-Jørgensen April 10, 2025, 11:24 a.m. UTC | #1

Peter Seiderer <[e-mail]> writes:

> Fix checkpatch detected code style errors/warnings detected in
> the file net/core/pktgen.c (remaining checkpatch checks will be addressed
> in a follow up patch set).
>
> Peter Seiderer (11):
>   net: pktgen: fix code style (ERROR: "foo * bar" should be "foo *bar")
>   net: pktgen: fix code style (ERROR: space prohibited after that '&')
>   net: pktgen: fix code style (ERROR: else should follow close brace
>     '}')
>   net: pktgen: fix code style (WARNING: please, no space before tabs)
>   net: pktgen: fix code style (WARNING: suspect code indent for
>     conditional statements)
>   net: pktgen: fix code style (WARNING: Block comments)
>   net: pktgen: fix code style (WARNING: Missing a blank line after
>     declarations)
>   net: pktgen: fix code style (WARNING: macros should not use a trailing
>     semicolon)
>   net: pktgen: fix code style (WARNING: braces {} are not necessary for
>     single statement blocks)
>   net: pktgen: fix code style (WARNING: quoted string split across
>     lines)
>   net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)
>
>  net/core/pktgen.c | 111 ++++++++++++++++++++++++++--------------------
>  1 file changed, 64 insertions(+), 47 deletions(-)

Most of these are pretty marginal improvements, so I'm a little on the
fence about whether they are worth it. But, well, they do improve things
slightly, so if the maintainers are OK with the churn:

Reviewed-by: Toke Høiland-Jørgensen <[e-mail]>

[e-mail] April 14, 2025, 10:57 p.m. UTC | #2

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Thu, 10 Apr 2025 09:17:37 +0200 you wrote:
> Fix checkpatch detected code style errors/warnings detected in
> the file net/core/pktgen.c (remaining checkpatch checks will be addressed
> in a follow up patch set).
> 
> Peter Seiderer (11):
>   net: pktgen: fix code style (ERROR: "foo * bar" should be "foo *bar")
>   net: pktgen: fix code style (ERROR: space prohibited after that '&')
>   net: pktgen: fix code style (ERROR: else should follow close brace
>     '}')
>   net: pktgen: fix code style (WARNING: please, no space before tabs)
>   net: pktgen: fix code style (WARNING: suspect code indent for
>     conditional statements)
>   net: pktgen: fix code style (WARNING: Block comments)
>   net: pktgen: fix code style (WARNING: Missing a blank line after
>     declarations)
>   net: pktgen: fix code style (WARNING: macros should not use a trailing
>     semicolon)
>   net: pktgen: fix code style (WARNING: braces {} are not necessary for
>     single statement blocks)
>   net: pktgen: fix code style (WARNING: quoted string split across
>     lines)
>   net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)
> 
> [...]

Here is the summary with links:
  - [net-next,v1,01/11] net: pktgen: fix code style (ERROR: "foo * bar" should be "foo *bar")
    https://git.kernel.org/netdev/net-next/c/81e92f4fb825
  - [net-next,v1,02/11] net: pktgen: fix code style (ERROR: space prohibited after that '&')
    https://git.kernel.org/netdev/net-next/c/eb1fd49ef660
  - [net-next,v1,03/11] net: pktgen: fix code style (ERROR: else should follow close brace '}')
    (no matching commit)
  - [net-next,v1,04/11] net: pktgen: fix code style (WARNING: please, no space before tabs)
    (no matching commit)
  - [net-next,v1,05/11] net: pktgen: fix code style (WARNING: suspect code indent for conditional statements)
    https://git.kernel.org/netdev/net-next/c/1d8f07bf4aab
  - [net-next,v1,06/11] net: pktgen: fix code style (WARNING: Block comments)
    https://git.kernel.org/netdev/net-next/c/870b856cb478
  - [net-next,v1,07/11] net: pktgen: fix code style (WARNING: Missing a blank line after declarations)
    https://git.kernel.org/netdev/net-next/c/ca8ee665211a
  - [net-next,v1,08/11] net: pktgen: fix code style (WARNING: macros should not use a trailing semicolon)
    (no matching commit)
  - [net-next,v1,09/11] net: pktgen: fix code style (WARNING: braces {} are not necessary for single statement blocks)
    (no matching commit)
  - [net-next,v1,10/11] net: pktgen: fix code style (WARNING: quoted string split across lines)
    https://git.kernel.org/netdev/net-next/c/08fcb1f242b9
  - [net-next,v1,11/11] net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)
    (no matching commit)

You are awesome, thank you!