| Message ID | 20250411050613.10550-1-kevinpaul468@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Removing deprecated strncpy() | expand |
>This patch suggests the replacement of strncpy with strscpy as per >Documentation/process/deprecated. >The strncpy() fails to guarntee NULL termination, The function adds zero pads >which isn't really convenient for short strings as it may cause performce issues > >strscpy() is a preffered replacement because it overcomes the limitations of >strncpy mentioned above > Please read my comment for your previous patch: - Add "net-next" to your email subject like this: [PATCH net-next] - Fix many typos in your changelog: guarntee -> guarantee, performce --> performance, preffered --> preferred >Compile Tested > >Signed-off-by: Kevin Paul Reddy Janagari <kevinpaul468@gmail.com> >--- > net/tipc/node.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/net/tipc/node.c b/net/tipc/node.c index >ccf5e427f43e..cb43f2016a70 100644 >--- a/net/tipc/node.c >+++ b/net/tipc/node.c >@@ -1581,7 +1581,7 @@ int tipc_node_get_linkname(struct net *net, u32 >bearer_id, u32 addr, > tipc_node_read_lock(node); > link = node->links[bearer_id].link; > if (link) { >- strncpy(linkname, tipc_link_name(link), len); >+ strscpy(linkname, tipc_link_name(link), len); please merge this change into your previous patch. We do not need a separate patch for the same purpose.
diff --git a/net/tipc/node.c b/net/tipc/node.c index ccf5e427f43e..cb43f2016a70 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -1581,7 +1581,7 @@ int tipc_node_get_linkname(struct net *net, u32 bearer_id, u32 addr, tipc_node_read_lock(node); link = node->links[bearer_id].link; if (link) { - strncpy(linkname, tipc_link_name(link), len); + strscpy(linkname, tipc_link_name(link), len); err = 0; } tipc_node_read_unlock(node);
This patch suggests the replacement of strncpy with strscpy as per Documentation/process/deprecated. The strncpy() fails to guarntee NULL termination, The function adds zero pads which isn't really convenient for short strings as it may cause performce issues strscpy() is a preffered replacement because it overcomes the limitations of strncpy mentioned above Compile Tested Signed-off-by: Kevin Paul Reddy Janagari <kevinpaul468@gmail.com> --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)