| Message ID | 20250410133332.294556-6-linux.amoon@gmail.com |
|---|---|
| State | Accepted |
| Commit | fef364bd4c9cf712c91e0013f5f304f4e7f09198 |
| Headers | show |
| Series | Messon: Simplify error handling with dev_err_probe() | expand |
On 10/04/2025 15:33, Anand Moon wrote: > Use dev_err_probe() for phy resources to indicate the deferral > reason when waiting for the resource to come up. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > drivers/phy/amlogic/phy-meson-axg-pcie.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c > index 60be5cdc600b3..54baf7b8930e1 100644 > --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c > +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c > @@ -131,19 +131,15 @@ static int phy_axg_pcie_probe(struct platform_device *pdev) > struct phy_axg_pcie_priv *priv; > struct device_node *np = dev->of_node; > void __iomem *base; > - int ret; > > priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > > priv->phy = devm_phy_create(dev, np, &phy_axg_pcie_ops); > - if (IS_ERR(priv->phy)) { > - ret = PTR_ERR(priv->phy); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to create PHY\n"); > - return ret; > - } > + if (IS_ERR(priv->phy)) > + return dev_err_probe(dev, PTR_ERR(priv->phy), > + "failed to create PHY\n"); > > base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c index 60be5cdc600b3..54baf7b8930e1 100644 --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c @@ -131,19 +131,15 @@ static int phy_axg_pcie_probe(struct platform_device *pdev) struct phy_axg_pcie_priv *priv; struct device_node *np = dev->of_node; void __iomem *base; - int ret; priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; priv->phy = devm_phy_create(dev, np, &phy_axg_pcie_ops); - if (IS_ERR(priv->phy)) { - ret = PTR_ERR(priv->phy); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - return ret; - } + if (IS_ERR(priv->phy)) + return dev_err_probe(dev, PTR_ERR(priv->phy), + "failed to create PHY\n"); base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base))
Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- drivers/phy/amlogic/phy-meson-axg-pcie.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)