MAINTAINERS: Add mmap trace events to MEMORY MAPPING

Commit Message

Liam R. Howlett April 11, 2025, 5:33 p.m. UTC

MEMORY MAPPING does not list the mmap.h trace point file, but does list
the mmap.c file.  Couple the trace points with the users and authors of
the trace points for notifications of updates.

Cc:Andrew Morton <[e-mail]>
Cc:Lorenzo Stoakes <[e-mail]>
Cc:Vlastimil Babka <[e-mail]>
Cc:Jann Horn <[e-mail]>
Signed-off-by: Liam R. Howlett <[e-mail]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

SeongJae Park April 11, 2025, 5:47 p.m. UTC | #1

On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <[e-mail]> wrote:

> MEMORY MAPPING does not list the mmap.h trace point file, but does list
> the mmap.c file.  Couple the trace points with the users and authors of
> the trace points for notifications of updates.
> 
> Cc:Andrew Morton <[e-mail]>
> Cc:Lorenzo Stoakes <[e-mail]>
> Cc:Vlastimil Babka <[e-mail]>
> Cc:Jann Horn <[e-mail]>
> Signed-off-by: Liam R. Howlett <[e-mail]>

Aced-by: SeongJae Park <[e-mail]>

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15571,6 +15571,7 @@ L:	[e-mail]
>  S:	Maintained
>  W:	http://www.linux-mm.org
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	include/trace/events/mmap.h

Should mmap_lock.h also be added here?

>  F:	mm/mlock.c
>  F:	mm/mmap.c
>  F:	mm/mprotect.c
> -- 
> 2.43.0


Thanks,
SJ

Steven Rostedt April 11, 2025, 6:33 p.m. UTC | #2

On Fri, 11 Apr 2025 13:33:28 -0400
"Liam R. Howlett" <[e-mail]> wrote:

> MEMORY MAPPING does not list the mmap.h trace point file, but does list
> the mmap.c file.  Couple the trace points with the users and authors of
> the trace points for notifications of updates.
> 
> Cc:Andrew Morton <[e-mail]>
> Cc:Lorenzo Stoakes <[e-mail]>
> Cc:Vlastimil Babka <[e-mail]>
> Cc:Jann Horn <[e-mail]>
> Signed-off-by: Liam R. Howlett <[e-mail]>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15571,6 +15571,7 @@ L:	[e-mail]
>  S:	Maintained
>  W:	http://www.linux-mm.org
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	include/trace/events/mmap.h

Acked-by: Steven Rostedt (Google) <[e-mail]>

-- Steve

>  F:	mm/mlock.c
>  F:	mm/mmap.c
>  F:	mm/mprotect.c

Liam R. Howlett April 12, 2025, 1:17 p.m. UTC | #3

* SeongJae Park <[e-mail]> [250411 13:47]:
> On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <[e-mail]> wrote:
> 
> > MEMORY MAPPING does not list the mmap.h trace point file, but does list
> > the mmap.c file.  Couple the trace points with the users and authors of
> > the trace points for notifications of updates.
> > 
> > Cc:Andrew Morton <[e-mail]>
> > Cc:Lorenzo Stoakes <[e-mail]>
> > Cc:Vlastimil Babka <[e-mail]>
> > Cc:Jann Horn <[e-mail]>
> > Signed-off-by: Liam R. Howlett <[e-mail]>
> 
> Aced-by: SeongJae Park <[e-mail]>
> 
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15571,6 +15571,7 @@ L:	[e-mail]
> >  S:	Maintained
> >  W:	http://www.linux-mm.org
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:	include/trace/events/mmap.h
> 
> Should mmap_lock.h also be added here?

Oh, well..

mmap_lock.h (include/trace/events/mmap_lock.h) has to do with
mm/mmap_lock.c, which also isn't listed here.  Both exist for tracing as
well.

There is also include/linux/mmap_lock.h, which is the locking itself.
The mmap lock is used more broadly than just these files: mm/pagewalk.c
and mm/ksm.c, for instance.

So I guess that's a more difficult decision.

Thanks for bringing this up,
Liam

SeongJae Park April 12, 2025, 3:47 p.m. UTC | #4

On Sat, 12 Apr 2025 09:17:21 -0400 "Liam R. Howlett" <[e-mail]> wrote:

> * SeongJae Park <[e-mail]> [250411 13:47]:
[...]
> > > @@ -15571,6 +15571,7 @@ L:	[e-mail]
> > >  S:	Maintained
> > >  W:	http://www.linux-mm.org
> > >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > > +F:	include/trace/events/mmap.h
> > 
> > Should mmap_lock.h also be added here?
> 
> Oh, well..
> 
> mmap_lock.h (include/trace/events/mmap_lock.h) has to do with
> mm/mmap_lock.c, which also isn't listed here.  Both exist for tracing as
> well.
> 
> There is also include/linux/mmap_lock.h, which is the locking itself.
> The mmap lock is used more broadly than just these files: mm/pagewalk.c
> and mm/ksm.c, for instance.
> 
> So I guess that's a more difficult decision.

Makes perfect sense.  Thank you for kindly clarifying this.


Thanks,
SJ

[...]

Vlastimil Babka April 15, 2025, 9:05 a.m. UTC | #5

On 4/11/25 19:33, Liam R. Howlett wrote:
> MEMORY MAPPING does not list the mmap.h trace point file, but does list
> the mmap.c file.  Couple the trace points with the users and authors of
> the trace points for notifications of updates.
> 
> Cc:Andrew Morton <[e-mail]>
> Cc:Lorenzo Stoakes <[e-mail]>
> Cc:Vlastimil Babka <[e-mail]>
> Cc:Jann Horn <[e-mail]>
> Signed-off-by: Liam R. Howlett <[e-mail]>

Acked-by: Vlastimil Babka <[e-mail]>

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15571,6 +15571,7 @@ L:	[e-mail]
>  S:	Maintained
>  W:	http://www.linux-mm.org
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	include/trace/events/mmap.h
>  F:	mm/mlock.c
>  F:	mm/mmap.c
>  F:	mm/mprotect.c

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 4c7fdc41a6bfb..d8e9a10adc81d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15571,6 +15571,7 @@  L:	[e-mail]
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/trace/events/mmap.h
 F:	mm/mlock.c
 F:	mm/mmap.c
 F:	mm/mprotect.c