[v2,0/2] Fix false warning in inode_to_wb

Message

Andreas Gruenbacher April 11, 2025, 5:38 p.m. UTC

Changes in v2:

- In inode_to_wb(), only check if the SB_I_CGROUPWB flag is set so that
  the consistency checks remain active even when cgroup writeback isn't
  actively used.

- Improve the description of "gfs2: replace sd_aspace with sd_inode".

Thanks,
Andreas

Andreas Gruenbacher (1):
  gfs2: replace sd_aspace with sd_inode

Jan Kara (1):
  writeback: Fix false warning in inode_to_wb()

 fs/gfs2/glock.c             |  3 +--
 fs/gfs2/glops.c             |  4 ++--
 fs/gfs2/incore.h            |  9 ++++++++-
 fs/gfs2/meta_io.c           |  2 +-
 fs/gfs2/meta_io.h           |  4 +---
 fs/gfs2/ops_fstype.c        | 31 ++++++++++++++++++-------------
 fs/gfs2/super.c             |  2 +-
 include/linux/backing-dev.h |  3 ++-
 8 files changed, 34 insertions(+), 24 deletions(-)

Comments

Tetsuo Handa April 12, 2025, 2:21 p.m. UTC | #1

Please add

  Reported-by: [e-mail]
  Closes: https://syzkaller.appspot.com/bug?extid=e14d6cd6ec241f507ba7

to both patches.

Also,

  -static inline struct bdi_writeback *inode_to_wb(const struct inode *inode)
  +static inline struct bdi_writeback *inode_to_wb(struct inode *inode)

change is not needed.

Andreas Gruenbacher April 12, 2025, 4:37 p.m. UTC | #2

On Sat, Apr 12, 2025 at 4:21 PM Tetsuo Handa
<[e-mail]> wrote:
> Please add
>
>   Reported-by: [e-mail]
>   Closes: https://syzkaller.appspot.com/bug?extid=e14d6cd6ec241f507ba7
>
> to both patches.

I'm quite reluctant to acknowledge syzbot for this. The bug has been
reported several times by several people, long before syzbot.

> Also,
>
>   -static inline struct bdi_writeback *inode_to_wb(const struct inode *inode)
>   +static inline struct bdi_writeback *inode_to_wb(struct inode *inode)
>
> change is not needed.

Ah, not anymore, indeed.

Thanks,
Andreas