diff mbox series

drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE

Message ID 20250411-aux-select-kms-v1-1-c4276f905a56@oss.qualcomm.com (mailing list archive)
State New
Headers show
Series drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE | expand

Commit Message

Dmitry Baryshkov April 11, 2025, 3:09 p.m. UTC 
The aux bridge uses devm_drm_of_get_bridge() from the panel bridge (and
correctly selects DRM_PANEL_BRIDGE). However panel bridge is not a
separate module, it is compiled into the drm_kms_helper.o. Select
DRM_KMS_HELPER too to express this dependency.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 drivers/gpu/drm/bridge/Kconfig | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 2bdde620f7f2bff2ff1cb7dc166859eaa0c78a7c
change-id: 20250411-aux-select-kms-086618b92d6e

Best regards,

Comments

Neil Armstrong April 14, 2025, 7:38 a.m. UTC | #1 
On 11/04/2025 17:09, Dmitry Baryshkov wrote:
> The aux bridge uses devm_drm_of_get_bridge() from the panel bridge (and
> correctly selects DRM_PANEL_BRIDGE). However panel bridge is not a
> separate module, it is compiled into the drm_kms_helper.o. Select
> DRM_KMS_HELPER too to express this dependency.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>   drivers/gpu/drm/bridge/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 09a1be234f7173bdf88e385507bbe5e5c6d583a6..b9e0ca85226a603a24f90c6879d1499f824060cb 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -16,6 +16,7 @@ config DRM_AUX_BRIDGE
>   	tristate
>   	depends on DRM_BRIDGE && OF
>   	select AUXILIARY_BUS
> +	select DRM_KMS_HELPER
>   	select DRM_PANEL_BRIDGE
>   	help
>   	  Simple transparent bridge that is used by several non-DRM drivers to
> 
> ---
> base-commit: 2bdde620f7f2bff2ff1cb7dc166859eaa0c78a7c
> change-id: 20250411-aux-select-kms-086618b92d6e
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Dmitry Baryshkov April 16, 2025, 11:11 p.m. UTC | #2 
On Fri, 11 Apr 2025 18:09:40 +0300, Dmitry Baryshkov wrote:
> The aux bridge uses devm_drm_of_get_bridge() from the panel bridge (and
> correctly selects DRM_PANEL_BRIDGE). However panel bridge is not a
> separate module, it is compiled into the drm_kms_helper.o. Select
> DRM_KMS_HELPER too to express this dependency.
> 
> 

Applied to drm-misc-next, thanks!

[1/1] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE
      commit: b12fa5e76e1463fc5a196f2717040e4564e184b6

Best regards,
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 09a1be234f7173bdf88e385507bbe5e5c6d583a6..b9e0ca85226a603a24f90c6879d1499f824060cb 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -16,6 +16,7 @@  config DRM_AUX_BRIDGE
 	tristate
 	depends on DRM_BRIDGE && OF
 	select AUXILIARY_BUS
+	select DRM_KMS_HELPER
 	select DRM_PANEL_BRIDGE
 	help
 	  Simple transparent bridge that is used by several non-DRM drivers to