| Message ID | 76e0ce0e312f691abae7ce0fd422f73306166926.1744292503.git.quic_gkohli@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Enable TSENS and thermal zone for QCS615 SoC | expand |
On 4/10/25 4:00 PM, Gaurav Kohli wrote: > Add TSENS and thermal devicetree node for QCS615 SoC. > > Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com> > --- subject: "arm64: dts: qcom: qcs615: .."> arch/arm64/boot/dts/qcom/qcs615.dtsi | 281 +++++++++++++++++++++++++++ > 1 file changed, 281 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi > index edfb796d8dd3..f0d8aed7da29 100644 > --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi > @@ -3668,6 +3668,17 @@ usb_2_dwc3: usb@a800000 { > maximum-speed = "high-speed"; > }; > }; > + > + tsens0: tsens@c222000 { > + compatible = "qcom,qcs615-tsens", "qcom,tsens-v2"; > + reg = <0x0 0xc263000 0x0 0x1ff>, > + <0x0 0xc222000 0x0 0x8>; Pad the address part to 8 hex digits with leading zeroes> + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>, &pdc 26 > + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>; &pdc 28 Please align the <s > + #qcom,sensors = <16>; > + interrupt-names = "uplow", "critical"; it would make sense for interrupt-names to come right under interrupts > + #thermal-sensor-cells = <1>; > + }; > }; > > arch_timer: timer { > @@ -3677,4 +3688,274 @@ arch_timer: timer { > <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, > <GIC_PPI 0 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>; > }; > + > + thermal-zones { > + aoss-thermal { > + thermal-sensors = <&tsens0 0>; > + > + trips { > + > + trip-point0 { > + temperature = <110000>; > + hysteresis = <5000>; > + type = "passive"; > + }; > + }; > + }; > + > + cpuss-0-thermal { > + thermal-sensors = <&tsens0 1>; > + > + trips { > + > + trip-point0 { > + temperature = <115000>; > + hysteresis = <5000>; > + type = "passive"; > + }; > + > + trip-point1 { > + temperature = <118000>; > + hysteresis = <5000>; > + type = "passive"; > + }; Please drop the passive trip point for the *CPU* tzones, see commit 06eadce936971dd11279e53b6dfb151804137836 ("arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU") and add a single critical point instead, see commit 03f2b8eed73418269a158ccebad5d8d8f2f6daa1 ("arm64: dts: qcom: x1e80100: Apply consistent critical thermal shutdown") Konrad
thanks for review! On 4/12/2025 5:13 AM, Konrad Dybcio wrote: > On 4/10/25 4:00 PM, Gaurav Kohli wrote: >> Add TSENS and thermal devicetree node for QCS615 SoC. >> >> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com> >> --- > > subject: "arm64: dts: qcom: qcs615: .."> arch/arm64/boot/dts/qcom/qcs615.dtsi | 281 +++++++++++++++++++++++++++ >> 1 file changed, 281 insertions(+) >> will fix this. >> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi >> index edfb796d8dd3..f0d8aed7da29 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi >> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi >> @@ -3668,6 +3668,17 @@ usb_2_dwc3: usb@a800000 { >> maximum-speed = "high-speed"; >> }; >> }; >> + >> + tsens0: tsens@c222000 { >> + compatible = "qcom,qcs615-tsens", "qcom,tsens-v2"; >> + reg = <0x0 0xc263000 0x0 0x1ff>, >> + <0x0 0xc222000 0x0 0x8>; > Pad the address part to 8 hex digits with leading zeroes> + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>, > > &pdc 26 > >> + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>; > > &pdc 28 we don't want to mark this as wake up capable, so using this approach. > > Please align the <s > >> + #qcom,sensors = <16>; >> + interrupt-names = "uplow", "critical"; > > it would make sense for interrupt-names to come right under interrupts yes, will update in next patch set. >> + #thermal-sensor-cells = <1>; >> + }; >> }; >> >> arch_timer: timer { >> @@ -3677,4 +3688,274 @@ arch_timer: timer { >> <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, >> <GIC_PPI 0 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>; >> }; >> + >> + thermal-zones { >> + aoss-thermal { >> + thermal-sensors = <&tsens0 0>; >> + >> + trips { >> + >> + trip-point0 { >> + temperature = <110000>; >> + hysteresis = <5000>; >> + type = "passive"; >> + }; >> + }; >> + }; >> + >> + cpuss-0-thermal { >> + thermal-sensors = <&tsens0 1>; >> + >> + trips { >> + >> + trip-point0 { >> + temperature = <115000>; >> + hysteresis = <5000>; >> + type = "passive"; >> + }; >> + >> + trip-point1 { >> + temperature = <118000>; >> + hysteresis = <5000>; >> + type = "passive"; >> + }; > > Please drop the passive trip point for the *CPU* tzones, see > we are using trip-point 0 for cpu idle injection mitigation which i will add in subsequent patches, if you are fine i will add cpu idle injection cooling map in this series only ? > commit 06eadce936971dd11279e53b6dfb151804137836 > ("arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU") > > and add a single critical point instead, see > As critical shutdown is already supported by hardware, so we are not defining here. > commit 03f2b8eed73418269a158ccebad5d8d8f2f6daa1 > ("arm64: dts: qcom: x1e80100: Apply consistent critical thermal shutdown") > > Konrad
On 4/14/25 10:28 AM, Gaurav Kohli wrote: > thanks for review! > > On 4/12/2025 5:13 AM, Konrad Dybcio wrote: >> On 4/10/25 4:00 PM, Gaurav Kohli wrote: >>> Add TSENS and thermal devicetree node for QCS615 SoC. >>> >>> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com> >>> --- >> >> subject: "arm64: dts: qcom: qcs615: .."> arch/arm64/boot/dts/qcom/qcs615.dtsi | 281 +++++++++++++++++++++++++++ >>> 1 file changed, 281 insertions(+) >>> > will fix this. >>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi >>> index edfb796d8dd3..f0d8aed7da29 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi >>> @@ -3668,6 +3668,17 @@ usb_2_dwc3: usb@a800000 { >>> maximum-speed = "high-speed"; >>> }; >>> }; >>> + >>> + tsens0: tsens@c222000 { >>> + compatible = "qcom,qcs615-tsens", "qcom,tsens-v2"; >>> + reg = <0x0 0xc263000 0x0 0x1ff>, >>> + <0x0 0xc222000 0x0 0x8>; >> Pad the address part to 8 hex digits with leading zeroes> + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>, >> >> &pdc 26 >> >>> + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>; >> >> &pdc 28 > we don't want to mark this as wake up capable, so using this approach. Why not? >>> + >>> + cpuss-0-thermal { >>> + thermal-sensors = <&tsens0 1>; >>> + >>> + trips { >>> + >>> + trip-point0 { >>> + temperature = <115000>; >>> + hysteresis = <5000>; >>> + type = "passive"; >>> + }; >>> + >>> + trip-point1 { >>> + temperature = <118000>; >>> + hysteresis = <5000>; >>> + type = "passive"; >>> + }; >> >> Please drop the passive trip point for the *CPU* tzones, see >> > > we are using trip-point 0 for cpu idle injection mitigation which i will add in subsequent patches, if you are fine i will add cpu idle injection cooling map in this series only ? The folks working on qcs9xxx have made this point too, but I'm lukewarm on duplicating meaningless dt description everywhere. I've asked them to conduct some measurements on whether random default settings (that would be preset in the driver and require no additional dt fluff) show any significant difference - if not, we can save up on boilerplate. So let's wait to hear back from them on this. >> commit 06eadce936971dd11279e53b6dfb151804137836 >> ("arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU") >> >> and add a single critical point instead, see >> > As critical shutdown is already supported by hardware, so we are not defining here. The hardware critical shutdown will literally pull the plug out with the OS having no chance to sync the filesystem etc. Please define one that's like 5 degC below the hardware limit, so that the operating system can try to take some steps to avoid data loss Konrad
On Mon, Apr 14, 2025 at 01:58:12PM +0530, Gaurav Kohli wrote: > thanks for review! > > On 4/12/2025 5:13 AM, Konrad Dybcio wrote: > > On 4/10/25 4:00 PM, Gaurav Kohli wrote: > > > Add TSENS and thermal devicetree node for QCS615 SoC. > > > > > > Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com> > > > --- > > > > > + cpuss-0-thermal { > > > + thermal-sensors = <&tsens0 1>; > > > + > > > + trips { > > > + > > > + trip-point0 { > > > + temperature = <115000>; > > > + hysteresis = <5000>; > > > + type = "passive"; > > > + }; > > > + > > > + trip-point1 { > > > + temperature = <118000>; > > > + hysteresis = <5000>; > > > + type = "passive"; > > > + }; > > > > Please drop the passive trip point for the *CPU* tzones, see > > > > we are using trip-point 0 for cpu idle injection mitigation which i will add > in subsequent patches, if you are fine i will add cpu idle injection cooling > map in this series only ? I'd second Konrad here. Please drop them now and add them in the patch adding CPUidle injection cooling. Otherwise they are a perfect target for anybody to clean them away. > > commit 06eadce936971dd11279e53b6dfb151804137836 > > ("arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU") > > > > and add a single critical point instead, see > > > As critical shutdown is already supported by hardware, so we are not > defining here. What about letting Linux to know about it and perform a slightly graceful shutdown? > > commit 03f2b8eed73418269a158ccebad5d8d8f2f6daa1 > > ("arm64: dts: qcom: x1e80100: Apply consistent critical thermal shutdown") > > > > Konrad >
diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi index edfb796d8dd3..f0d8aed7da29 100644 --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi @@ -3668,6 +3668,17 @@ usb_2_dwc3: usb@a800000 { maximum-speed = "high-speed"; }; }; + + tsens0: tsens@c222000 { + compatible = "qcom,qcs615-tsens", "qcom,tsens-v2"; + reg = <0x0 0xc263000 0x0 0x1ff>, + <0x0 0xc222000 0x0 0x8>; + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>; + #qcom,sensors = <16>; + interrupt-names = "uplow", "critical"; + #thermal-sensor-cells = <1>; + }; }; arch_timer: timer { @@ -3677,4 +3688,274 @@ arch_timer: timer { <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, <GIC_PPI 0 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>; }; + + thermal-zones { + aoss-thermal { + thermal-sensors = <&tsens0 0>; + + trips { + + trip-point0 { + temperature = <110000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + cpuss-0-thermal { + thermal-sensors = <&tsens0 1>; + + trips { + + trip-point0 { + temperature = <115000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <118000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + + }; + + cpuss-1-thermal { + thermal-sensors = <&tsens0 2>; + + trips { + + trip-point0 { + temperature = <115000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <118000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + + }; + + cpuss-2-thermal { + thermal-sensors = <&tsens0 3>; + + trips { + + trip-point0 { + temperature = <115000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <118000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + cpuss-3-thermal { + thermal-sensors = <&tsens0 4>; + + trips { + + trip-point0 { + temperature = <115000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <118000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + cpu-1-0-thermal { + thermal-sensors = <&tsens0 5>; + + trips { + + trip-point0 { + temperature = <115000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <118000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + cpu-1-1-thermal { + thermal-sensors = <&tsens0 6>; + + trips { + + trip-point0 { + temperature = <115000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <118000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + + }; + + cpu-1-2-thermal { + thermal-sensors = <&tsens0 7>; + + trips { + + trip-point0 { + temperature = <115000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <118000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + cpu-1-3-thermal { + thermal-sensors = <&tsens0 8>; + + trips { + + trip-point0 { + temperature = <115000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <118000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + + }; + + gpu-thermal { + thermal-sensors = <&tsens0 9>; + + trips { + + trip-point0 { + temperature = <105000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <110000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + + }; + + q6-hvx-thermal { + thermal-sensors = <&tsens0 10>; + + trips { + + trip-point0 { + temperature = <105000>; + hysteresis = <5000>; + type = "passive"; + }; + + trip-point1 { + temperature = <110000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + mdm-core-thermal { + thermal-sensors = <&tsens0 11>; + + trips { + trip-point0 { + temperature = <110000>; + hysteresis = <10000>; + type = "passive"; + }; + }; + }; + + camera-thermal { + thermal-sensors = <&tsens0 12>; + + trips { + trip-point0 { + temperature = <110000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + wlan-thermal { + thermal-sensors = <&tsens0 13>; + + trips { + trip-point0 { + temperature = <110000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + display-thermal { + thermal-sensors = <&tsens0 14>; + + trips { + trip-point0 { + temperature = <110000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + + video-thermal { + thermal-sensors = <&tsens0 15>; + + trips { + trip-point0 { + temperature = <110000>; + hysteresis = <5000>; + type = "passive"; + }; + }; + }; + }; };
Add TSENS and thermal devicetree node for QCS615 SoC. Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com> --- arch/arm64/boot/dts/qcom/qcs615.dtsi | 281 +++++++++++++++++++++++++++ 1 file changed, 281 insertions(+)